qt/qt-license-service.git, branch dev The Qt License Service is a gateway between Qt License Server and Qt developer tools (i.e. Qt Creator and Qt Design Studio) Fix of a bug where daemon grants non-valid license 2023-04-19T11:36:08+00:00 Sami Littow sami.littow@qt.io 2023-04-14T05:54:38+00:00 481ae1cb9e52dfe198030e9a4a6e562005f04ca7 (clitoolhandler.h) - Server response validity was only checked when requesting longterm reservation - Could have exploited with telnet - Server response JSON status field check moved to the beginning of method (HttpClient, Licenser classes) - Pass the REST endpoint to the HTTP client per request, rather than trying to guess it in HTTP client Change-Id: I13d05b33f1032a91d393e7315552f1b9d391142d Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io> 
(clitoolhandler.h)
- Server response validity was only checked when requesting longterm reservation
- Could have exploited with telnet
- Server response JSON status field check moved to the beginning of method

(HttpClient, Licenser classes)
- Pass the REST endpoint to the HTTP client per request, rather than
  trying to guess it in HTTP client

Change-Id: I13d05b33f1032a91d393e7315552f1b9d391142d
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
Fix Windows build 2023-04-19T09:26:53+00:00 Arttu Tarkiainen arttu.tarkiainen@qt.io 2023-04-14T12:40:05+00:00 b8e7c76ea05ab2ab1dbec0efe547ee2ff259e374 Add missing cast and only include pthread lib on Unix platforms. Change-Id: I0c40edb5b97ab80fbed126d332b661dcfdb2fb79 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
Add missing cast and only include pthread lib on Unix platforms.

Change-Id: I0c40edb5b97ab80fbed126d332b661dcfdb2fb79
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Coin: fix exec of build script on Windows 2023-04-19T09:26:37+00:00 Arttu Tarkiainen arttu.tarkiainen@qt.io 2023-04-18T08:08:47+00:00 08e3fca11732403e8071d4685459f326d738d0e4 golang's exec package does not allow running executables from the current directory with a relative path argument on Windows after its 1.19 release. Adapt the build instructions to use an absolute path instead. Change-Id: I5bbb6bdee1919af322389ff4fb0980b92994bc5d Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> Reviewed-by: Sami Littow <sami.littow@qt.io> 
golang's exec package does not allow running executables from the
current directory with a relative path argument on Windows after
its 1.19 release. Adapt the build instructions to use an absolute
path instead.

Change-Id: I5bbb6bdee1919af322389ff4fb0980b92994bc5d
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Reviewed-by: Sami Littow <sami.littow@qt.io>
Add only deploy folder to artifacts 2023-04-14T11:46:17+00:00 Heikki Halmet heikki.halmet@qt.io 2023-04-14T11:16:40+00:00 7827d8173c7d661d7e1f9eefbe19bd64103034c4 Change-Id: Ied1fbd1ce806e59e45ac3e467c0362c923d3b808 Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
Change-Id: Ied1fbd1ce806e59e45ac3e467c0362c923d3b808
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Change Id's for license service targets 2023-04-14T11:46:15+00:00 Heikki Halmet heikki.halmet@qt.io 2023-04-14T11:20:29+00:00 38d5d64bb60c28ab935e983a23f1c5133b30611f Change-Id: I2c042844f77a8f31431beee242f2c07119071f6e Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
Change-Id: I2c042844f77a8f31431beee242f2c07119071f6e
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Upload artifacts to Coin storage 2023-04-14T07:33:12+00:00 Heikki Halmet heikki.halmet@qt.io 2023-04-13T08:53:32+00:00 3bd5276efde97a0783f3e07c29050dd0fcf3a6da Change-Id: I9a3669951eeb9107e8bc28029563c44506fbf3a4 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
Change-Id: I9a3669951eeb9107e8bc28029563c44506fbf3a4
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Cleanup: remove commented out code 2023-04-13T12:40:09+00:00 Arttu Tarkiainen arttu.tarkiainen@qt.io 2023-04-12T10:38:20+00:00 cda096486013d2f5ab39f0a2fd86235ef27fc67c Change-Id: Id5253f628acc7823fcf697a1115cd13952d2125d Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
Change-Id: Id5253f628acc7823fcf697a1115cd13952d2125d
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Fix issues caused by invoking exit() on non-main thread 2023-04-13T12:40:02+00:00 Arttu Tarkiainen arttu.tarkiainen@qt.io 2023-04-05T14:31:47+00:00 f5055dd810d50feb81d4b4a5553b7199d877f5fc These could cause unpredictable behavior, resulting in crashes if the daemon would be started twice, trying to bind the TCP server socket to an address with already taken port, etc. Fix by: - Add generic runtime exception class for daemon thrown errors. - Replace exit() calls that could occur on non-main thread with throwing the new exception. - Add test case failing without the fix. Change-Id: I5cfe679bdd9a034b1913edf30be00acfe3f3232c Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
These could cause unpredictable behavior, resulting in crashes
if the daemon would be started twice, trying to bind the TCP
server socket to an address with already taken port, etc.

Fix by:

- Add generic runtime exception class for daemon thrown errors.

- Replace exit() calls that could occur on non-main thread with
  throwing the new exception.

- Add test case failing without the fix.

Change-Id: I5cfe679bdd9a034b1913edf30be00acfe3f3232c
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>
Fix segmentation fault after sending SIGINT signal 2023-04-13T12:39:58+00:00 Arttu Tarkiainen arttu.tarkiainen@qt.io 2023-04-05T09:55:01+00:00 35f678a084503bac03c6d466fd9265d003c5545a In case the daemon had not served any clients, the Licenser:: m_currentClient pointer was initialized into undefined value, and was deleted unconditionally on the class destructor, causing a segfault. Instead of keeping the pointer as class member, only store the managed client handler object in the scope of Licenser::listen(). Floating clients are then moved into runtime storage, either directly or under respective parents, and site license clients should be destroyed after they are handled. This fixes the above mentioned issue, and also prevents leaking of consequent site license clients after the first one. Also add a simple test case. Task-number: QLS-285 Change-Id: Ife58207a3a8598590c6755d5e03c218172d35d36 Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io> 
In case the daemon had not served any clients, the Licenser::
m_currentClient pointer was initialized into undefined value,
and was deleted unconditionally on the class destructor, causing
a segfault.

Instead of keeping the pointer as class member, only store the
managed client handler object in the scope of Licenser::listen().
Floating clients are then moved into runtime storage, either directly
or under respective parents, and site license clients should be
destroyed after they are handled.

This fixes the above mentioned issue, and also prevents leaking of
consequent site license clients after the first one.

Also add a simple test case.

Task-number: QLS-285
Change-Id: Ife58207a3a8598590c6755d5e03c218172d35d36
Reviewed-by: Arttu Tarkiainen <arttu.tarkiainen@qt.io>
change 2022 to 2023 2023-04-13T12:07:09+00:00 Riku Zeng riku.zeng@qt.io 2023-04-13T11:54:42+00:00 330aee98846b63e9706424216efc84fa23541f57 Change-Id: I3b95199abf2908367d5f2902943b94dcc567927f Reviewed-by: Iikka Eklund <iikka.eklund@qt.io> 
Change-Id: I3b95199abf2908367d5f2902943b94dcc567927f
Reviewed-by: Iikka Eklund <iikka.eklund@qt.io>