qt/qtcharts.git/tests/manual/chartviewer, branch dev QtCharts module Enable strict mode 6.11 in qtcharts 2026-05-06T03:43:09+00:00 Tomi Korpipaa tomi.korpipaa@qt.io 2026-03-27T10:34:50+00:00 00393d5d9251fc85be401a89088edfb2a122b972 Task-number: QTBUG-145281 Pick-to: 6.11 Change-Id: I7e95cd63d537648de1977ad7ee4ae92c0ff1c4af Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> 
Task-number: QTBUG-145281
Pick-to: 6.11
Change-Id: I7e95cd63d537648de1977ad7ee4ae92c0ff1c4af
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Mark the module as free of Q_FOREACH, except where it isn't 2023-08-18T10:30:49+00:00 Marc Mutz marc.mutz@qt.io 2023-08-07T08:14:49+00:00 11ea4943beb40aa60dfde1d50a4d931b9818ce3d The density of Q_FOREACH uses is exremely high here, too high for this author, unfamiliar with this code, to tackle in a short amount of time. Even if they're not concentrated in just a few TUs, we need to make progress on a global QT_NO_FOREACH default, so grab the nettle and stick to our strategy: Mark the whole module with QT_NO_FOREACH, to prevent new uses from creeping in, and whitelist the affected TUs by #undef'ing QT_NO_FOREACH locally, at the top of each file. For TUs that are part of a larger executable, this requires these files to be compiled separately, so add them to NO_PCH_SOURCES (which implies NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115824 to keep track of this, and other such follow-up changes in this module. Task-number: QTBUG-115824 Change-Id: I7d3d11f5313b14f866557583c2e4e18bba893e58 Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> 
The density of Q_FOREACH uses is exremely high here, too high for this
author, unfamiliar with this code, to tackle in a short amount of
time. Even if they're not concentrated in just a few TUs, we need to
make progress on a global QT_NO_FOREACH default, so grab the nettle
and stick to our strategy:

Mark the whole module with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115824 to keep track of
this, and other such follow-up changes in this module.

Task-number: QTBUG-115824
Change-Id: I7d3d11f5313b14f866557583c2e4e18bba893e58
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Mark chartviewer as free of Q_FOREACH, except where it isn't 2023-08-17T17:27:04+00:00 Marc Mutz marc.mutz@qt.io 2023-08-07T08:14:49+00:00 a15f7570c67aabbab9beaa1e8eeb9631edebea58 The density of Q_FOREACH uses is exremely high here, too high for this author, unfamiliar with this code, to tackle in a short amount of time. Even if they're not concentrated in just a few TUs, we need to make progress on a global QT_NO_FOREACH default, so grab the nettle and stick to our strategy: Mark the whole test with QT_NO_FOREACH, to prevent new uses from creeping in, and whitelist the affected TUs by #undef'ing QT_NO_FOREACH locally, at the top of each file. For TUs that are part of a larger executable, this requires these files to be compiled separately, so add them to NO_PCH_SOURCES (which implies NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115824 to keep track of this, and other such follow-up changes in this module. The use in the charts.h header file to be fixed, because uses in header files makes any .cpp file including the header (in PCH builds: all) incompatible with QT_NO_FOREACH. Task-number: QTBUG-115824 Change-Id: I92481adee921665b2e8b755a5778d0b52a39a6c6 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> 
The density of Q_FOREACH uses is exremely high here, too high for this
author, unfamiliar with this code, to tackle in a short amount of
time. Even if they're not concentrated in just a few TUs, we need to
make progress on a global QT_NO_FOREACH default, so grab the nettle
and stick to our strategy:

Mark the whole test with QT_NO_FOREACH, to prevent new uses from
creeping in, and whitelist the affected TUs by #undef'ing
QT_NO_FOREACH locally, at the top of each file. For TUs that are part
of a larger executable, this requires these files to be compiled
separately, so add them to NO_PCH_SOURCES (which implies
NO_UNITY_BUILD_SOURCES, too). Created QTBUG-115824 to keep track of
this, and other such follow-up changes in this module.

The use in the charts.h header file to be fixed, because uses in
header files makes any .cpp file including the header (in PCH builds:
all) incompatible with QT_NO_FOREACH.

Task-number: QTBUG-115824
Change-Id: I92481adee921665b2e8b755a5778d0b52a39a6c6
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Change the license of all CMakeLists.txt and *.cmake files to BSD 2022-08-23T23:37:18+00:00 Lucie Gérard lucie.gerard@qt.io 2022-08-22T14:06:10+00:00 bc9534b5f57e0c53b9db6f37dac13b2a24451aaa Task-number: QTBUG-105718 Change-Id: I98da78de677349b0e4cdf8e8d988df7bb3990ddd Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io> 
Task-number: QTBUG-105718
Change-Id: I98da78de677349b0e4cdf8e8d988df7bb3990ddd
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
CMake: Don't use PUBLIC_LIBRARIES for tests and test helpers 2022-07-27T11:48:13+00:00 Alexandru Croitor alexandru.croitor@qt.io 2022-07-26T16:05:24+00:00 273ba7e9a0d93fa07b27f5344538b1cf09d76efd Change-Id: If82067ad0bbfca620da4eb01dfd738563351df19 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io> 
Change-Id: If82067ad0bbfca620da4eb01dfd738563351df19
Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
Add license headers to cmake files 2022-07-08T11:42:34+00:00 Lucie Gérard lucie.gerard@qt.io 2022-07-06T09:06:25+00:00 1d0c06c6409392220b888c18cfbf1d2eef3f5346 CMakeLists.txt and .cmake files of significant size (more than 2 lines according to our check in tst_license.pl) now have the copyright and license header. Existing copyright statements remain intact Task-number: QTBUG-88621 Change-Id: I47400c953dbec676442d195cc32aba55c590741e Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io> 
CMakeLists.txt and .cmake files of significant size
(more than 2 lines according to our check in tst_license.pl)
now have the copyright and license header.

Existing copyright statements remain intact

Task-number: QTBUG-88621
Change-Id: I47400c953dbec676442d195cc32aba55c590741e
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Use SPDX license identifiers 2022-06-16T08:24:16+00:00 Lucie Gérard lucie.gerard@qt.io 2022-06-10T12:30:14+00:00 64e73727869ee6792e70f5aaa71dc4ad37c20fc0 Replace the current license disclaimer in files by a SPDX-License-Identifier. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: Ibb797d52859b5c504f7300f4a5dc956a7b44ac11 Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: Ibb797d52859b5c504f7300f4a5dc956a7b44ac11
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>
Conform with coding style: spacing-only changes 2021-10-13T09:50:22+00:00 Edward Welbourne edward.welbourne@qt.io 2021-10-11T15:42:19+00:00 08f0ba6a5a94ae4b4c70a2d8d726b8dc9c36b5cf Spaces are required around operators, case labels are meant to line up with their switch, no spaces immediately inside parentheses, only one space between words. Change-Id: I4f2182a31247bfe83f43b98ff424e008a4c545fd Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> 
Spaces are required around operators,
case labels are meant to line up with their switch,
no spaces immediately inside parentheses,
only one space between words.

Change-Id: I4f2182a31247bfe83f43b98ff424e008a4c545fd
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>
Add cmake build 2021-01-06T13:30:18+00:00 Michal Klocek michal.klocek@qt.io 2020-07-29T06:43:00+00:00 7cec30a15f4712e782bb1011d2b93e6bf77cce6b Task-number: QTBUG-89091 Change-Id: Ie511e6bc262f197b2c21e52ec7696a0d50e06d18 Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io> 
Task-number: QTBUG-89091
Change-Id: Ie511e6bc262f197b2c21e52ec7696a0d50e06d18
Reviewed-by: Joerg Bornemann <joerg.bornemann@qt.io>
Do not use include with error, prepare for cmake 2020-12-08T13:49:27+00:00 Michal Klocek michal.klocek@qt.io 2020-12-04T12:47:51+00:00 1393b587d3b23877602d84cd49489ff033190875 Reporting errors for every single include does not make so much sense and it complicates cmake port (adds a need for lot of extra #special case). Change-Id: I42cf4d7366798caaba5fd6729691051909a5a0c1 Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io> 
Reporting errors for every single include does not
make so much sense and it complicates cmake port (adds
a need for lot of extra #special case).

Change-Id: I42cf4d7366798caaba5fd6729691051909a5a0c1
Reviewed-by: Miikka Heikkinen <miikka.heikkinen@qt.io>