qt/qtdeclarative.git, branch 5.13 Qt Declarative (Quick 2) Fix a layout bug caused by a delegate item that was moved by the user 2019-11-12T13:25:42+00:00 Jan Arve Sæther jan-arve.saether@qt.io 2019-10-14T12:39:48+00:00 c89f7a221b7c31a0a4e1b0eed2e91d7633f4eab2 The position of the first item in the list of visualItems was used to know how to layout the rest of the visual items. However, this did not work if the first item was actually moved (e.g. due to a DnD operation). We therefore store the position of the first visual item after each time we arrange it, and use that as a basis on where to start layouting from. Task-number: QTBUG-78076 Change-Id: I837f5b7d61a13d98d23287685c6fd66817360906 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> 
The position of the first item in the list of visualItems was used to
know how to layout the rest of the visual items.
However, this did not work if the first item was actually moved (e.g.
due to a DnD operation). We therefore store the position of the first
visual item after each time we arrange it, and use that as a basis on
where to start layouting from.

Task-number: QTBUG-78076
Change-Id: I837f5b7d61a13d98d23287685c6fd66817360906
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Doc: add section on imperative vs declarative to best practices page 2019-11-11T13:01:08+00:00 Mitch Curtis mitch.curtis@qt.io 2019-11-11T10:18:15+00:00 63042da9c94fd8d04583631249a7bfa54ba2656f Change-Id: I6ea16474e5e59f76f7b2c5806e381a1a4b05db20 Fixes: QTBUG-79903 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Change-Id: I6ea16474e5e59f76f7b2c5806e381a1a4b05db20
Fixes: QTBUG-79903
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
QQuickAccessibleAttached: keep track of name being explicitly set 2019-11-06T12:43:50+00:00 Mitch Curtis mitch.curtis@qt.io 2019-11-05T14:49:23+00:00 b802031e2d8b4b38267f1ec2c00507bfd8ed1f5f This allows types to attach an accessible name to an item, so long as the user hasn't done so themselves. Task-number: QTBUG-66583 Change-Id: I04f26815ffeaf1198fee25dc414253de8b8dfabe Reviewed-by: Liang Qi <liang.qi@qt.io> 
This allows types to attach an accessible name to an item, so long as
the user hasn't done so themselves.

Task-number: QTBUG-66583
Change-Id: I04f26815ffeaf1198fee25dc414253de8b8dfabe
Reviewed-by: Liang Qi <liang.qi@qt.io>
QQmlVMEMetaObject: Scope MemberData for allocating write 2019-11-05T17:18:56+00:00 Ulf Hermann ulf.hermann@qt.io 2019-11-04T12:12:03+00:00 21844350df530a65071e8679d5e047adf553e0f7 If we need to allocate in order to write a property of the object, we need to make sure that the member data is not garbage collected during that allocation. Change-Id: I885cdc547588c1b20450e1586765cd0266b4c4f0 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
If we need to allocate in order to write a property of the object, we
need to make sure that the member data is not garbage collected during
that allocation.

Change-Id: I885cdc547588c1b20450e1586765cd0266b4c4f0
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
QQuickItem::setParentItem: Check for d->window after deref'ing it 2019-10-31T10:56:13+00:00 Ulf Hermann ulf.hermann@qt.io 2019-10-31T09:22:12+00:00 15d1b173d030f5ae5ca72f511d33c80979503268 The window may have been deleted. In that case there is nothing to do. Amends commit 73ad6e87bbeceea5830ab3a6b3dc66fa99e30f45. Change-Id: Ib591f34b51f58d49ed0b065be7025f8e54777c10 Reviewed-by: Liang Qi <liang.qi@qt.io> 
The window may have been deleted. In that case there is nothing to do.
Amends commit 73ad6e87bbeceea5830ab3a6b3dc66fa99e30f45.

Change-Id: Ib591f34b51f58d49ed0b065be7025f8e54777c10
Reviewed-by: Liang Qi <liang.qi@qt.io>
QQmlProperty: handle reads of QQmlPropertyMap correctly 2019-10-30T11:51:23+00:00 Fabian Kosmale fabian.kosmale@qt.io 2019-10-30T09:15:23+00:00 bcbc3c9cec1f7d7bb8c9d5f5ea94eb5c81ec2853 Fixes: QTBUG-79614 Change-Id: Iaf84c0178dc88072a367da2b42b09554b85c7d57 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
Fixes: QTBUG-79614
Change-Id: Iaf84c0178dc88072a367da2b42b09554b85c7d57
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
QML Drag: Prevent crash when using image provider url 2019-10-30T08:17:36+00:00 Fabian Kosmale fabian.kosmale@qt.io 2019-10-29T15:11:21+00:00 234dbbf25567ce44a8c8e099d003f04a12f2b371 For attached property objects, qmlEngine will not return an engine. However, QQuickDragAttached's parent is the object to which it is attached, and from that one we can get the engine. Fixes: QTBUG-72045 Change-Id: I40748dd11ea3eb4604c37e932b2cfd3baad6fd1f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
For attached property objects, qmlEngine will not return an engine.
However, QQuickDragAttached's parent is the object to which it is
attached, and from that one we can get the engine.

Fixes: QTBUG-72045
Change-Id: I40748dd11ea3eb4604c37e932b2cfd3baad6fd1f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Merge remote-tracking branch 'origin/5.13.2' into 5.13 2019-10-29T12:26:08+00:00 Qt Forward Merge Bot qt_forward_merge_bot@qt-project.org 2019-10-29T12:26:08+00:00 cdf00b076ee8934598fa6cd1af01f83e80ac73e0 Change-Id: I2b55bea338aa854d940a6da9b6703866209e6ba6 
Change-Id: I2b55bea338aa854d940a6da9b6703866209e6ba6
QQuickItem::setParentItem: add child earlier 2019-10-29T07:00:49+00:00 Fabian Kosmale fabian.kosmale@qt.io 2019-10-28T12:41:11+00:00 73ad6e87bbeceea5830ab3a6b3dc66fa99e30f45 Calling (de)refWindow can trigger QQuickItem::windowChanged, which in turn can call a user defined windowChanged handler. If that signal handler were to call setParentItem, we would encounter an inconsistent state: The item already has its parent set, but that parent would lack the item in its children list (as we would only call refWindow at a later point). Fixes: QTBUG-79573 Fixes: QTBUG-73439 Change-Id: I46adaa54a0521b5cd7f37810b3dd1a206e6a09c6 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
Calling (de)refWindow can trigger QQuickItem::windowChanged, which in turn
can call a user defined windowChanged handler. If that signal handler
were to call setParentItem, we would encounter an inconsistent state:
The item already has its parent set, but that parent would lack the item
in its children list (as we would only call refWindow at a later point).

Fixes: QTBUG-79573
Fixes: QTBUG-73439
Change-Id: I46adaa54a0521b5cd7f37810b3dd1a206e6a09c6
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
qv4compileddata: do not use raw constexpr 2019-10-28T09:52:45+00:00 Fabian Kosmale fabian.kosmale@qt.io 2019-10-28T07:35:08+00:00 76b86342d47df953009457a554245aace49eecf6 Necessary after change 50481fb909c2bbbc26a193e23783e5b0151168b9 in qtbase Fixes: QTBUG-79563 Change-Id: I72c94cd87b881f2fb3fee005f73583f64cbf68e4 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
Necessary after change 50481fb909c2bbbc26a193e23783e5b0151168b9 in qtbase

Fixes: QTBUG-79563
Change-Id: I72c94cd87b881f2fb3fee005f73583f64cbf68e4
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>