tst_QQuickPopup::popupWindowPositioning is flaky on Ubuntu 24 and openSuSE. With the Universal style, the popup may be positioned incorrectly if the parent window has not yet finished being placed. Explicitly set the window position and check it using ensurePositionTopLeft. Fix flaky tst_QQuickPopup::popupWindowPositioning. Pick-to: 6.8 Change-Id: I67860ed75d6b2b177662f38fb2f2cdffb8446b13 Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit 64e2b195ff09f2c75217a9e27ffab05e0a5318b1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 24f37f6446e375a40c67402793f571873dcd6121)
Make inherits() return false for empty arguments. In QTBUG-149360, users try to use qmllint on Qt5 projects and qmllint's resolveType() method might return null on missing or incomplete QtQuick QML modules, which might make the qdslintplugin and quicklintplugin crash when passing the null result of resolveType() to inherits(). Task-number: QTBUG-149360 Change-Id: I5c7cf13f2a809e4b07e31e94fe693f64bde5464a Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 0bb3e54c65bec9ef93be3648a596304e4f11c4a0) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 5400d8618e84e51ddeb35b8ab458103f278b9cda) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
The failure was: FAIL! : tst_qquickiconimage::color() Compared values are not the same Actual (iconImageWindowGrab.pixelColor(centerPixelPos)): #00000000 Expected (QColor(Qt::green)) : #ff00ff00 Loc: [[...]/tst_qquickiconimage.cpp(413)] Fix it by accounting for the DPR. Change-Id: I1ab3acd878688550adc32c3f96d00b9be3ba98e4 Reviewed-by: SanthoshKumar Selvaraj <santhosh.kumar.selvaraj@qt.io> (cherry picked from commit 30aac146828646560694e1c3a0b7620b7d63e4f5) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 0b8a1d9d972394cc1fae9b30a2d4d9058e492cdc)
The QFileSelector could simultaneously be marked as owned and QObject-owned by the QQmlFileSelector. In that case it would be double-freed when the QQmlFileSelector was deleted. Fixes: QTBUG-149994 Pick-to: 6.8 Change-Id: I7f6553820bc297691c8be8b9b35d310d405f9eae Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io> (cherry picked from commit 39e4dcd2f326b879c56f4557641b0868f8d918ad) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 1e0967890cf7c521beb9010f9fd7328ad51d8363)
The animation code can trigger UB due to overflow in multiple locations. This applies the same fix as 9d103def6fcf1fee2d81a16cf4c81717afe2b818 from qtbase. Fixes: QTBUG-149496 Pick-to: 6.8 6.5 5.15 Change-Id: I61984daa34916f1bd9b389a7ffac718295b01d4e Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> (cherry picked from commit 54f7b169b73f395532a0a0ee460a06d5543a91bf) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 4e8ebddbe0abf9927d00b789e99940feaa4a7846)
The animation code can trigger UB when multiplication overflows. This applies the same fix as f6e15019c569f3df919a9f82c69b401bff7276bd from qtbase. Unfortunately, the QML code is basically a fork of what we have in corelib/animation (avoiding the QObject dependency), which cannot be easily unified. This necessiates fixing basically the same code twice. Task-number: QTBUG-149496 Pick-to: 6.8 6.5 5.15 Change-Id: If8de07232627b8094d6a45b5e0f71aec957de462 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> (cherry picked from commit 5c399cd2a45f507291a93d3b9ac05b341b6a6675) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit dfada6507c983d82941079136bac8f719e29e757)
Change-Id: Iaeff16107dae5f432ca3208f7aca57e56dee3a8f Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
When the gc has run, we might have already collected the m_propertyAndMethodStorage of an object, even though the object itself is still not destroyed: This is due to use using deleteLater. Most places already handle that via QQmlData::wasDeleted checks, but code involving QQmlVMEResolvedList and QQmlConnections do not, and also interact directly with m_propertyAndMethodStorage. Should something trigger a binding re-evaluation before the event loop has a chance to spin and deliver the QDeferredDeleteEvents, we might end up with null pointers, which weren't handled so far. We add some additional null-checks to avoid triggering crashes from dereferencing stale pointers. Note that QQmlVMEResolvedList already had code to handle a null m_propertyAndMethodStorage in its constructor, but then ignored the possibility later on. Ideally, we instead would have a way to keep the storage exactly as long as the object, but that turns out to be rather tricky. So for now we fix the symptoms. Fixes: QTBUG-148459 Pick-to: 6.8 Change-Id: I7ebe889fc4ed3a2f2b433e060e5f82399892f41f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit c89b2cf16d3184513d6de4cd07482cde90f7f586) (cherry picked from commit 16453be10e49380da7e059f4ddfd37b2731ac9c1) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Populating a deferred property can re-enter quickBeginDeferred():
writing the property notifies its observers, and a binding among them
may read the same property back. If the deferred binding evaluates to
null, the pointer stays null, so the caller's "if (!delegate ||
complete)" check does not stop that second execution.
The second QtQuickPrivate::beginDeferred() then incremented
QQmlEnginePrivate::inProgressCreations and stored its DeferredState in
the delegate, where it replaced the outer one. The outer state ended up
in a local variable of the nested call and was destroyed without ever
being completed, so the counter was never decremented and the engine
complained on teardown:
There are still "N" items in the process of being created at engine
destruction.
Bail out when the delegate is already executing.
This is hit in practice by kirigami-addons' FormRadioDelegate, which
uses RadioButton { contentItem: null }, in combination with
qqc2-desktop-style, whose indicator reads control.contentItem from its
x/y bindings.
Fixes: QTBUG-148846
Change-Id: I0ddb8ef374efeb68ce59db285d54664e99606854
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
(cherry picked from commit 77fc1fd6d4d3b2c3222564f34a0f80ea102fa9e4)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit a5fca50366313c05cb0e1a573761871d93554cfb)
The base properties of grouped properties don't have to be read-only, but making them read-only is generally a good idea. Also, describe the dilemma of assigning both, the whole object and individual properties. Pick-to: 6.8 Change-Id: I803eb152a350e72d36ef1cc801b99a5c7c453222 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> (cherry picked from commit 02adb073a928a2c0db8b5ec19f9401d7700213c7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 10c548765c4a845c91bc27af424f96c176a4173c)