qt/qtdeclarative.git, branch 6.4 Qt Declarative (Quick 2) Doc: Remove mention of module version requirement 2023-06-25T17:55:33+00:00 Paul Wicking paul.wicking@qt.io 2023-06-21T05:07:23+00:00 8cd3364039a78395555ee522f8ad82ef30ccecd7 Fixes: QTBUG-114715 Change-Id: I7b5821820ba582fb21eaa56e3cf102fc3d61be00 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 9c33258ff56f4028a62c13fda866452bdb9caf38) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Fixes: QTBUG-114715
Change-Id: I7b5821820ba582fb21eaa56e3cf102fc3d61be00
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 9c33258ff56f4028a62c13fda866452bdb9caf38)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
NinePatchImage: support the compressed texture image 2023-05-16T04:20:21+00:00 Jaehak Lee jaehak.lee@mobis.co.kr 2023-04-25T09:17:58+00:00 a782eb71f659a8f6fdd825cc69482ce4cd7612f3 The compressed texture image is supported by qquickimage and the qquickninepatchimage is inherited by qquickimage. But the compressed texture is not shown when the source of qquickninepatchimage is set as compressed texture because the updatePaintNode of qquickninepatchimage only consider non-compressed texture. This patch is not intended to use the HW compressed image as an actual 9-patch image, but to display them using the super class qquickimage in the case of an HW compressed image other than a normal pixmap image. If the source is HW compressed textures such as ASTC, KTX, and PKM, we have to call updatePaintNode of QQuickImage before checking the validity of the pixmap image. (because nullptr is returned if pixmap image is not valid) The containers themselves (pkm, ktx) are universally supported but the compressed texture formats is up to the underlying 3D API implementation and may vary. So, if the format is not supported by RHI, we skip the test. Refer to QTBUG-113565 for a detailed discussion on texture formats. And when using the software backend, we also skip test cases. Fixes: QTBUG-113446 Change-Id: I2704f86e94b50b3c187eca359fdc1a69eb217811 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit ed69a9d4f3e889b05548e7cebe957afc3a3e577f) 
The compressed texture image is supported by qquickimage and
the qquickninepatchimage is inherited by qquickimage.
But the compressed texture is not shown when the source of
qquickninepatchimage is set as compressed texture because the
updatePaintNode of qquickninepatchimage only consider non-compressed
texture.

This patch is not intended to use the HW compressed image as an
actual 9-patch image, but to display them using the super class
qquickimage in the case of an HW compressed image other than a normal
pixmap image.

If the source is HW compressed textures such as ASTC, KTX, and PKM,
we have to call updatePaintNode of QQuickImage before checking the
validity of the pixmap image.
(because nullptr is returned if pixmap image is not valid)

The containers themselves (pkm, ktx) are universally supported but
the compressed texture formats is up to the underlying 3D API
implementation and may vary.
So, if the format is not supported by RHI, we skip the test.
Refer to QTBUG-113565 for a detailed discussion on texture formats.

And when using the software backend, we also skip test cases.

Fixes: QTBUG-113446
Change-Id: I2704f86e94b50b3c187eca359fdc1a69eb217811
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit ed69a9d4f3e889b05548e7cebe957afc3a3e577f)
QQuickFlickable: avoid processing the same event twice 2023-05-11T08:13:43+00:00 Richard Moe Gustavsen richard.gustavsen@qt.io 2023-04-26T09:33:09+00:00 afcdf6cfad6db20668d22ecabca1f45d712e2383 If Flickable has an exclusive grab (e.g if it's being dragged), and at the same time, a child has a passive grab (e.g a TapHandler inside a child of the content item), Flickable ends up getting the same pointer events twice. The reason this happens is because Flickable has a childMouseEventFilter. So the flickable will first get all the pointer events since it has an exclusive grab, just to see that the filter will receive the same events once more, as they next are delivered to the passive grabbers. The result is that Flickable will handle all pointer events (move, release etc) twice when it has en exclusive grab, which will even cause the flickable from stop flicking prematurely if the mouse release ends up outside the bounds of the flickable (because of a double call to handleReleaseEvent(), which will set stealMouse to false too early). To fix this, this patch will make sure that we don't handle any pointer events in the childMouseEventFilter if we already have an exclusive grab. After all, having an exclusive grab means that we're already getting the events the "normal" way, and shouldn't handle the same events once more. Fixes: QTBUG-104987 Change-Id: Iaed49cb860cf50ea38a70a6e546d9dcf25cce444 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> (cherry picked from commit 1bac9de1136c8d52650199f9defefae2f1d6a1a5) 
If Flickable has an exclusive grab (e.g if it's being dragged), and
at the same time, a child has a passive grab (e.g a TapHandler inside
a child of the content item), Flickable ends up getting the same pointer
events twice.

The reason this happens is because Flickable has a childMouseEventFilter.
So the flickable will first get all the pointer events since it has an
exclusive grab, just to see that the filter will receive the same
events once more, as they next are delivered to the passive grabbers.

The result is that Flickable will handle all pointer events
(move, release etc) twice when it has en exclusive grab, which will
even cause the flickable from stop flicking prematurely if the mouse
release ends up outside the bounds of the flickable (because of a double
call to handleReleaseEvent(), which will set stealMouse to false too
early).

To fix this, this patch will make sure that we don't handle any pointer
events in the childMouseEventFilter if we already have an exclusive grab.
After all, having an exclusive grab means that we're already getting the
events the "normal" way, and shouldn't handle the same events once more.

Fixes: QTBUG-104987
Change-Id: Iaed49cb860cf50ea38a70a6e546d9dcf25cce444
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit 1bac9de1136c8d52650199f9defefae2f1d6a1a5)
Material: Fix incorrect path in qt_attribution.json 2023-04-30T11:18:41+00:00 Topi Reinio topi.reinio@qt.io 2022-12-09T17:11:11+00:00 58961f035cac4b7b5331d4d8154889680b2ad4b9 qtattributionsscanner now uses a non-zero exit code when 'Files' points to non-existent file(s). Fix the documentation build failing with src/quickcontrols/material/qt_attribution.json: Path 'ElevationEffect.qml' does not exist Change-Id: I978811b06afce5496443afec1e21138bbc9249e9 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Kai Köhne <kai.koehne@qt.io> (cherry picked from commit c796092f638eec28382346669a9b05f9508c8301) Reviewed-by: Topi Reiniö <topi.reinio@qt.io> 
qtattributionsscanner now uses a non-zero exit code
when 'Files' points to non-existent file(s).

Fix the documentation build failing with

  src/quickcontrols/material/qt_attribution.json:
    Path 'ElevationEffect.qml' does not exist

Change-Id: I978811b06afce5496443afec1e21138bbc9249e9
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
(cherry picked from commit c796092f638eec28382346669a9b05f9508c8301)
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Flickable: Send movement signal when flick starts 2023-04-29T23:56:43+00:00 Seokha Ko seokha.ko@qt.io 2023-04-14T08:15:50+00:00 987e4b3fe9266607226038306bab616a168ad740 If there are multiple moves between touch down and release, but they are merged, or if there is only one move, flick occurs but no movement signal is generated. So, send movementStarted if the view is moving in handleReleaseEvent Fixes: QTBUG-112924 Change-Id: I774799bac2a00296a72005dcfa9ade6683836d08 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit e6a363efe86dd6acbceade28d5eddbdca9c7b805) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
If there are multiple moves between touch down and release,
but they are merged, or if there is only one move,
flick occurs but no movement signal is generated.
So, send movementStarted if the view is moving in
handleReleaseEvent

Fixes: QTBUG-112924
Change-Id: I774799bac2a00296a72005dcfa9ade6683836d08
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit e6a363efe86dd6acbceade28d5eddbdca9c7b805)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Blacklist failing tests in tst_flickableinterop 2023-04-28T02:38:23+00:00 Seokha Ko seokha.ko@qt.io 2023-04-27T09:03:02+00:00 25fa4fcad2677cf2b5eb4c0e1facb6a9e08bb5ee pinchHandlerOnFlickable fail with QTBUG-112924. Blacklist it for now. It will be handled in QTBUG-113226 Fixes: QTBUG-113226 Fixes: QTBUG-112924 Change-Id: I58c646f957fb6f397405dc477d00eee770602e80 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit 407675b1913a5138c636a730cf3f6a65ffed87fb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
pinchHandlerOnFlickable fail with QTBUG-112924.
Blacklist it for now.
It will be handled in QTBUG-113226

Fixes: QTBUG-113226
Fixes: QTBUG-112924
Change-Id: I58c646f957fb6f397405dc477d00eee770602e80
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit 407675b1913a5138c636a730cf3f6a65ffed87fb)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Clarify unsupported topologies in QSSGGeometry docs 2023-04-19T11:19:03+00:00 Laszlo Agocs laszlo.agocs@qt.io 2023-04-17T08:49:21+00:00 787ec49bfde2dbafe8a457c775ff2f8579d16a2c Should have added a note about this in Qt 6.0 already. Task-number: QTBUG-111012 Change-Id: I650abdb69d4f1dd6aff6d8e84970fc5e91384f02 Reviewed-by: Andy Nichols <andy.nichols@qt.io> (cherry picked from commit 284238bcc4d831748d6a8b50057caa5463716266) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Should have added a note about this in Qt 6.0 already.

Task-number: QTBUG-111012
Change-Id: I650abdb69d4f1dd6aff6d8e84970fc5e91384f02
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
(cherry picked from commit 284238bcc4d831748d6a8b50057caa5463716266)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Support building for Raspberry Pi 1 or Zero 2023-04-18T08:26:13+00:00 Dimitrios Apostolou jimis@qt.io 2023-03-15T18:22:30+00:00 d696b20ef42d4e9d63d8145bd55475d6ebec3c61 Cross-compiling (using Clang-13) for Raspberry Pi OS on Raspberry Pi 1 and Zero, requires adding "-target arm-linux-gnueabihf" to the compiler flags, which defines macro __ARM_ARCH_6KZ__ to detect for armv6. Fixes error: qtdeclarative/src/qml/../3rdparty/masm/wtf/Platform.h:312:6: error: "Not supported ARM architecture" More details: it turns out that the already checked macro __ARM_ARCH_6ZK__ is a typo with significance because older versions of GCC only had this. On the other hand __ARM_ARCH_6KZ__ (that this patch checks for) is the correct spelling, and it's the only one defined by Clang. Newer versions of GCC define both. Change-Id: I60532bfcaa62677f88ed2cff05d872a14c4c2111 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 35d6c73620761609e21b835211c67cff7829b44d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Cross-compiling (using Clang-13) for Raspberry Pi OS on Raspberry Pi 1
and Zero, requires adding "-target arm-linux-gnueabihf" to the compiler
flags, which defines macro __ARM_ARCH_6KZ__ to detect for armv6.

Fixes error:

  qtdeclarative/src/qml/../3rdparty/masm/wtf/Platform.h:312:6: error: "Not supported ARM architecture"

More details: it turns out that the already checked macro
__ARM_ARCH_6ZK__ is a typo with significance because older versions of
GCC only had this. On the other hand __ARM_ARCH_6KZ__ (that this patch
checks for) is the correct spelling, and it's the only one defined by
Clang. Newer versions of GCC define both.

Change-Id: I60532bfcaa62677f88ed2cff05d872a14c4c2111
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 35d6c73620761609e21b835211c67cff7829b44d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Fix word selection on touch 2023-04-18T08:10:05+00:00 Tomi Korpipaa tomi.korpipaa@qt.io 2023-04-12T10:41:57+00:00 d0c73a757048cfffd7ab824d0ff8685295197af7 The cursor position update on mouseReleaseEvent broke touch-and-hold word selection on touch devices. Now only do it if we don't have an active selection. Fixes: QTBUG-111504 Fixes: QTBUG-110850 Change-Id: I5c63d8516d1eef3de10289c6d5c5b3d1d3e8623f Reviewed-by: Sami Varanka <sami.varanka@qt.io> Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit d6ddfa3d4ca3fbbaddc2acd7ebe3f8296fc68b68) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
The cursor position update on mouseReleaseEvent broke
touch-and-hold word selection on touch devices. Now only do it
if we don't have an active selection.

Fixes: QTBUG-111504
Fixes: QTBUG-110850
Change-Id: I5c63d8516d1eef3de10289c6d5c5b3d1d3e8623f
Reviewed-by: Sami Varanka <sami.varanka@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit d6ddfa3d4ca3fbbaddc2acd7ebe3f8296fc68b68)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Fix stack layout index when loaded asynchronously 2023-04-14T13:44:30+00:00 Santhosh Kumar santhosh.kumar.selvaraj@qt.io 2023-03-31T15:44:10+00:00 5b7e125ddfb22451602298f54831ed57446e9b7d Lazy loading of stack layout causes incorrect index value in the attached property for the child items. This is because, attachedProperties are created and updated for the child object, after being added to the stack layout. This patchset triggers childItemsChanged() to reset child objects of stack layout with right index value. Fixes: QTBUG-111902 Change-Id: Iad06d028d0f977189b5da1122904dc754060a609 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> (cherry picked from commit e397e5b43c9a9844e652adf5ef55365e0a40f57b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Lazy loading of stack layout causes incorrect index value in the
attached property for the child items. This is because,
attachedProperties are created and updated for the child object, after
being added to the stack layout.

This patchset triggers childItemsChanged() to reset child objects of
stack layout with right index value.

Fixes: QTBUG-111902
Change-Id: Iad06d028d0f977189b5da1122904dc754060a609
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
(cherry picked from commit e397e5b43c9a9844e652adf5ef55365e0a40f57b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>