qt/qtdeclarative.git, branch 6.6

SelectionRectangle: ensure we remove or update selection handles if selection changes

2024-04-05T06:56:56+00:00

If you make a selection with SelectionRectangle and then resize a
row, the selection handles will not move to the resized position.
Likewise, if you do a selection, but then clear the selection
by interacting with the ItemSelectionModel directly, the
selection handles will not be updated to reflect the changes.

To fix this bug, this patch will add a callback from TableView to
SelectionRectangle that can be used to notify when changes are
done outside of SelectionRectangle. This especially allows us to:

- Remove the selection handles if the active selection is cleared
  or changed programatically (or anyway not by SelectionRectangle).
- Keep the selection handles, and update their position, when rows
  or columns are merely resized.

This change also allows us to clean up qquickselectionrectangle.cpp
a bit, and remove e.g a now superfluous tap handler listener.

Task-number: QTBUG-121143
Pick-to: 6.5
Change-Id: Id170520d49bc92c0bb9d16deaba741cab6f5c553
Reviewed-by: Santhosh Kumar 
(cherry picked from commit f0fbedbe69532d9f5d1bc622f0b5b1ed16f23f2b)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 7adfb01943b8681a51d6c01fed6d06b864f6d010)
Reviewed-by: Ulf Hermann

Fix heap-buffer-overflow in ESTable::remove

2024-04-05T01:55:16+00:00

Fixes a heap-buffer-overflow issue in ESTable::remove due to an off by
one error in the count provided to memmove calls.

Task-number: QTBUG-123999
Pick-to: 6.5 6.2 5.15
Change-Id: I4ee0fbc16ba8936ea921e5f1d1bb267dae0b1d5f
Reviewed-by: Qt CI Bot 
Reviewed-by: Fabian Kosmale 
(cherry picked from commit d3e36454830012e4fd4c538ddeab7cddbfacdc24)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 3241bb2e5e9a4a8c35254fc279d216b6da81780e)

Controls: Bypass bindings when setting x and y in resizeBackground

2024-04-04T16:37:51+00:00

Using setX() and setY() instead can remove the binding for them.

Fixes: QTBUG-120033
Pick-to: 6.5 6.2
Change-Id: I77fc5360b2d10436b5e258b5f0ceb96b949eccbe
Reviewed-by: Ulf Hermann 
(cherry picked from commit bb7ba7667b4cf3565aa1849d08cc71b9ac011e77)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit ac17f948cdb46e0fe900c72af35fc3ac84e29000)

qmltest: add a 'modifiers' argument to mouseMove()

2024-04-03T21:09:06+00:00

As it stood, TestCase::mouseMove() didn't take a 'modifier'
argument. All the other mouse functions do that, including
mouseDrag(). But even for mouseDrag, the modifier argument was
only applied to mousePress() and mouseRelease(), but not to
the in-between mouse moves.

This patch will implement support for providing a modifier
argument also to mouseMove(). This is needed in order to
test API that distinguishes a normal drag from a ctrl+drag, like
e.g SelectionRectangle.

Pick-to: 6.5
Change-Id: Idd800eda4b5b4fd4e9cda94155ca4ec36e935d13
Reviewed-by: Santhosh Kumar 
(cherry picked from commit 92f39a3919375af7e0eeaa31d010fc7fde7f6c4f)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 7a9478f69446b67550c41dd6340891b456074cb4)

QQmlEngine: Set translationsDirectory in loadFromModule

2024-04-03T13:11:43+00:00

In the process, loadFromModule had to be split in two parts. The type
resolution has to happen so that the translationDirectory can be set and
the translations have to be loaded before loading the actual module.

Pick-to: 6.5
Fixes: QTBUG-116589
Change-Id: Ife7999f418ba35bfb0eed9050198e5a886fa74ae
Reviewed-by: Fabian Kosmale 
(cherry picked from commit 986b4d155bd39836b1aa3c3da332ef07d2a949fd)
Reviewed-by: Ulf Hermann 
(cherry picked from commit 8206c3d86c27327e31bcefaef6a6606e207c9b18)

Small fixes in tst_spinbox.qml

2024-04-02T16:50:48+00:00

Ammends cf15ba9b085ac783fd3315f1b103c012947cb7db

This patch addresses the comments that were posted in codereview but not
included in the previous patch before staging.

Change-Id: I5ad25213824d39459110cee1368eef9cfc8650c5
Reviewed-by: Mitch Curtis 
(cherry picked from commit 580c431fb07c18cbfb85a1a327cb6b27e5803440)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 34f7cc12b99ab858318bbf37a6c1acfd0b0247c1)

Mark MultiEffect itemRect properly as readonly

2024-04-02T16:50:48+00:00

Change-Id: Id3a7031959f9b386b919d0a00c02e7bdcadf8a92
Reviewed-by: 
Reviewed-by: Tomi Korpipää 
(cherry picked from commit e3b1d3532b1f33bb8e8e6435df8b159e04c34068)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit a2d96ea925a708cdaf49043ab94dbe508dcc70b1)

QQuickSelectionRectangle: Fix crash when target is null

2024-04-02T14:33:33+00:00

Change-Id: I9eb92583f2cfe1a0a6bee54e3e3f31528c3b6993
Reviewed-by: Richard Moe Gustavsen 
(cherry picked from commit ab88fcd990523070f2c018f4599b9bfa023d3b95)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 47cf611d54938d0b7916aa72167b52f50b846723)

Add unit test for QML_ELEMENT as Q_GADGET in a namespace

2024-03-30T21:28:12+00:00

It was fixed by fa081b89f0bf8813e11d00436ab0dc9fb5efb378.

Task-number: QTBUG-123592
Pick-to: 6.5
Change-Id: I6eb60f65efe608f99b92ccd595b19eac5b78d710
Reviewed-by: Ulf Hermann 
(cherry picked from commit a6e6cb7812b0a03cb0040093ea94c4d5f0f9200a)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 8b62cbc0fed70a340d607d549301f46745f9d728)

Fix namespace in namespace detection of a foreign type

2024-03-30T03:04:35+00:00

Add full qualified name to QML_FOREIGN, otherwise it
won't detect a namespace in a namespace.

Task-number: QTBUG-123535
Pick-to: 6.5
Change-Id: I679edc2566739ee52bf531ecec64789350fcdd11
Reviewed-by: Ulf Hermann 
(cherry picked from commit fa081b89f0bf8813e11d00436ab0dc9fb5efb378)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 80fa9f25b3321ac2e8ae2c181505f4b1acee75d8)