qt/qtdeclarative.git, branch 6.8 Qt Declarative (Quick 2) qmlls highlighter: Avoid warnings 2025-04-21T17:04:25+00:00 Fabian Kosmale fabian.kosmale@qt.io 2025-04-11T12:29:46+00:00 4f0c0fafede5beaa918be85c80a1db1c75b430f4 highlightComponent is meant to handle inline components; however, it is also called for the "main" component, as DomType::QmlComponent covers both. Check if there is actually a ComponentKeywordRegion, otherwise just skip the work, as trying to add a highlight for a non-existent region triggers warnings. Change-Id: Ife7bfd46804bfbe7be0ca23b2012cb35c6fc6d36 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit cfdeadfbddded1ff7ceddad4fa3874cd8be5c015) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit f766a944f1541daa269b7e6b10bc7978a4b7343b) 
highlightComponent is meant to handle inline components; however, it is
also called for the "main" component, as DomType::QmlComponent covers
both.

Check if there is actually a ComponentKeywordRegion, otherwise just skip
the work, as trying to add a highlight for a non-existent region
triggers warnings.

Change-Id: Ife7bfd46804bfbe7be0ca23b2012cb35c6fc6d36
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit cfdeadfbddded1ff7ceddad4fa3874cd8be5c015)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit f766a944f1541daa269b7e6b10bc7978a4b7343b)
DeliveryAgent: clear deviceDeliveryTargets before hover delivery 2025-04-18T08:13:39+00:00 Shawn Rutledge shawn.rutledge@qt.io 2025-04-16T11:49:36+00:00 b25be970eed9bff96c74c0ab8d78788c72d87035 deliverPointerEvent() and deliverSinglePointEventUntilAccepted() already clear the QQuickPointingDeviceExtra::deliveryTargets list before each event delivery (since a97759a336c597327cb82eebc9f45c793aec32c9 and 262d7eb305e1dea8dac660bec3ccc50193258ea9). deliverHoverEvent() needs to do that too: in case there are a lot of hover delivery targets and the user doesn't move the mouse for a long time, but the scene is continuously updated, flushFrameSynchronousEvents() keeps sending hover events, and this list would keep growing if we don't clear it each time. Fixes: QTBUG-135975 Pick-to: 6.8.3 6.5 Change-Id: Ia91e3c977b45fc964228d3aad89938435f437449 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit f43f6e49333aea97856c426a1ecf12afe80c1184) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 9fbc709a9381efed45ca8316847f716deee0bd95) 
deliverPointerEvent() and deliverSinglePointEventUntilAccepted() already
clear the QQuickPointingDeviceExtra::deliveryTargets list before each
event delivery (since a97759a336c597327cb82eebc9f45c793aec32c9 and
262d7eb305e1dea8dac660bec3ccc50193258ea9). deliverHoverEvent() needs to
do that too: in case there are a lot of hover delivery targets and the
user doesn't move the mouse for a long time, but the scene is
continuously updated, flushFrameSynchronousEvents() keeps sending hover
events, and this list would keep growing if we don't clear it each time.

Fixes: QTBUG-135975
Pick-to: 6.8.3 6.5
Change-Id: Ia91e3c977b45fc964228d3aad89938435f437449
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit f43f6e49333aea97856c426a1ecf12afe80c1184)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 9fbc709a9381efed45ca8316847f716deee0bd95)
Fix division by zero in QQuickSvgParser 2025-04-18T05:11:09+00:00 Mitch Curtis mitch.curtis@qt.io 2025-04-01T05:25:37+00:00 5482f67da7705ede34c987c61ee45e3221d7b2b7 df97b6b2de6282bd6422f1e531a42475dadc980d in Qt Base added an assert which detected this. This patch adds an early return if we're about to divide by zero, similar to 7ca1222296a9650f24979df57cc2c974a7e571ed. It also amends that patch to move the start point == end point check to pathArc(), since it's called from more places. Fixes: QTBUG-135387 Pick-to: 6.5 5.15 Change-Id: If9c5655d5e736825e98d3e93201bf889a1785e49 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> (cherry picked from commit 8d597bea22728268beff583a79e2005b1df423bf) Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io> (cherry picked from commit 503cbb4ad07a06941761607f46964c9540595225) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> 
df97b6b2de6282bd6422f1e531a42475dadc980d in Qt Base added an
assert which detected this.

This patch adds an early return if we're about to divide by zero,
similar to 7ca1222296a9650f24979df57cc2c974a7e571ed. It also
amends that patch to move the start point == end point check
to pathArc(), since it's called from more places.

Fixes: QTBUG-135387
Pick-to: 6.5 5.15
Change-Id: If9c5655d5e736825e98d3e93201bf889a1785e49
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
(cherry picked from commit 8d597bea22728268beff583a79e2005b1df423bf)
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
(cherry picked from commit 503cbb4ad07a06941761607f46964c9540595225)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
qmltc: Cleanly reject custom parsed properties 2025-04-17T18:35:53+00:00 Ulf Hermann ulf.hermann@qt.io 2025-04-11T11:02:07+00:00 a1ed03f4c4f6311d34119e7d4c41645047e49e43 Process all properties of custom parsed types and generate errors if the custom parsed properties are actually used. Then print an extra error stating that qmltc does not support custom parsers. Fixes: QTBUG-134206 Change-Id: I37e4f3f8d0ee4e0926c0d64c99a4a521b093a1ab Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io> (cherry picked from commit afb51a7e91607a6c99c14d0ae8cd46f8d2954fd2) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8ee7354d0872bbdfd5de740de17b218694039bb8) 
Process all properties of custom parsed types and generate errors if the
custom parsed properties are actually used. Then print an extra error
stating that qmltc does not support custom parsers.

Fixes: QTBUG-134206
Change-Id: I37e4f3f8d0ee4e0926c0d64c99a4a521b093a1ab
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
(cherry picked from commit afb51a7e91607a6c99c14d0ae8cd46f8d2954fd2)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 8ee7354d0872bbdfd5de740de17b218694039bb8)
QQmlBind: Only restore previous state if current state is still active 2025-04-17T18:35:53+00:00 Ulf Hermann ulf.hermann@qt.io 2025-04-10T11:38:36+00:00 3d486bfce5480c12fcdb48abd2086a45bf98a6b9 If some other Binding has overridden the one we're currently clearing, we should not restore the previous state. Amends commit e2fa7ab91310ea74c30e9458dfbe20d257578659 [ChangeLog][QtQml] The Binding element now only restores previous bindings or values if its own binding is still active on destruction or changes to its "when" property. If it has been overridden by another Binding element, it will not disable that one anymore. Fixes: QTBUG-134922 Change-Id: Iac2883e7649dc0d2fb2669efa847becbb886ca64 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: YaNing Lu <luyaning@uniontech.com> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 6a8478829747289cdcce2a6e9628b31cfd865f15) Reviewed-by: Semih Yavuz <semih.yavuz@qt.io> (cherry picked from commit 1c3bbebb23179a6f39ac63f8f31c3240793f006d) Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io> 
If some other Binding has overridden the one we're currently clearing,
we should not restore the previous state.

Amends commit e2fa7ab91310ea74c30e9458dfbe20d257578659

[ChangeLog][QtQml] The Binding element now only restores previous
bindings or values if its own binding is still active on destruction or
changes to its "when" property. If it has been overridden by another
Binding element, it will not disable that one anymore.

Fixes: QTBUG-134922
Change-Id: Iac2883e7649dc0d2fb2669efa847becbb886ca64
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: YaNing Lu <luyaning@uniontech.com>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 6a8478829747289cdcce2a6e9628b31cfd865f15)
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
(cherry picked from commit 1c3bbebb23179a6f39ac63f8f31c3240793f006d)
Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
QtQml: Reject uncreatable value types even if marked as QML_UNCREATABLE 2025-04-17T18:35:53+00:00 Ulf Hermann ulf.hermann@qt.io 2025-04-09T12:57:57+00:00 b81df9a31d8fa9b4f3a2e72060a13e5ec225c91d We simply cannot do anything sensible with them. Clarify the warning to say that only object types can be marked uncreatable. Also fix Qt.labs.folderlistmodel. It had such a type. Task-number: QTBUG-135032 Change-Id: Id062908c66c4c4ab15e0deb5c92d0ca7ca447899 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit b15ab35bfa66663b050dc17a8ed4b032addb0e8f) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 87c7799bd78e53492c0eb593123880d1b6e751ad) 
We simply cannot do anything sensible with them. Clarify the warning to
say that only object types can be marked uncreatable.

Also fix Qt.labs.folderlistmodel. It had such a type.

Task-number: QTBUG-135032
Change-Id: Id062908c66c4c4ab15e0deb5c92d0ca7ca447899
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit b15ab35bfa66663b050dc17a8ed4b032addb0e8f)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 87c7799bd78e53492c0eb593123880d1b6e751ad)
QtQml: Avoid maybe-uninitialized warnings in QJSPrimitiveValue 2025-04-17T18:35:53+00:00 Ulf Hermann ulf.hermann@qt.io 2025-04-11T12:30:03+00:00 7184c9e72b1b80dceef5e863d096172d85345ac8 The compiler can't see that we only access m_string if it has previously been initialized. However, we can just zero the storage on construction. Pick-to: 6.5 Fixes: QTBUG-135367 Change-Id: I1b04d81e18063650501bdc24474c9672e999189d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit b417a509f5636161e9fb6beed19f32f7a40dac7c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit ed87fe9ed6c4085c3e01568e675db0683cdf29af) 
The compiler can't see that we only access m_string if it has
previously been initialized. However, we can just zero the storage on
construction.

Pick-to: 6.5
Fixes: QTBUG-135367
Change-Id: I1b04d81e18063650501bdc24474c9672e999189d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit b417a509f5636161e9fb6beed19f32f7a40dac7c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit ed87fe9ed6c4085c3e01568e675db0683cdf29af)
Qml Tooling: Check for debug message service before using it 2025-04-17T18:35:52+00:00 Ulf Hermann ulf.hermann@qt.io 2025-04-11T13:39:25+00:00 f9b6b9241d019e0b03187fa83b919162446e2cf7 The debug message service can get confused by the presence of other message handlers. Try again to restore the original one in the destructor if it couldn't be restored on state change. Pick-to: 6.5 Fixes: QTBUG-134772 Change-Id: I59f36f92a4e0fad54aa617937612d2f9f20e577c Reviewed-by: hjk <hjk@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> (cherry picked from commit 373782c1c094c22f0efe03b5d2f726631f9ccf46) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 2daede332a27a8a460870782355a7cf612176708) 
The debug message service can get confused by the presence of other
message handlers. Try again to restore the original one in the
destructor if it couldn't be restored on state change.

Pick-to: 6.5
Fixes: QTBUG-134772
Change-Id: I59f36f92a4e0fad54aa617937612d2f9f20e577c
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
(cherry picked from commit 373782c1c094c22f0efe03b5d2f726631f9ccf46)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 2daede332a27a8a460870782355a7cf612176708)
qv4codegen: Track the correct location for assign instructions 2025-04-17T14:26:27+00:00 Olivier De Cannière olivier.decanniere@qt.io 2025-04-14T14:09:55+00:00 39e1b2bc1c5432f2498c9c56250244e612f9ce14 This fixes a qmllint warning about unqualified access in the wrong place in the following unconventional but valid case: Warning: .../Main.qml:5:9: Unqualified access [unqualified] console.log(a = 1) ^^^^^^^ Warning: .../Main.qml:5:21: Unqualified access [unqualified] console.log(a = 1) ^ Pick-to: 6.5 Change-Id: I8eaa43f520c394b094917fe37dc6115ec2f7af74 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 4beea6bc83f315ec57fd07ea0c21767dc63127d6) Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This fixes a qmllint warning about unqualified access in the wrong place
in the following unconventional but valid case:

Warning: .../Main.qml:5:9: Unqualified access [unqualified]
        console.log(a = 1)
        ^^^^^^^

Warning: .../Main.qml:5:21: Unqualified access [unqualified]
        console.log(a = 1)
                    ^

Pick-to: 6.5
Change-Id: I8eaa43f520c394b094917fe37dc6115ec2f7af74
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 4beea6bc83f315ec57fd07ea0c21767dc63127d6)
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Fix data race on QSGDistanceFieldGlyphNode::m_totalAllocation 2025-04-17T09:48:05+00:00 David Faure david.faure@kdab.com 2025-04-12T08:48:24+00:00 5431c800dce0ba8e7f217c43bd88c3b2568a3b13 Different instances of QSGRenderThread call into different instances of QSGDistanceFieldGlyphNode concurrently, this static counter needs to be made thread-safe. Pick-to: 6.5 Change-Id: Ie8299824e799a9b15bae354314d1fa5c371cf5dc Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 53bd0bb6b06c2d4b4570d22f41dfe3951db785ba) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit b2d7869485b8679bb1f393023af440927bee464d) 
Different instances of QSGRenderThread call into different instances
of QSGDistanceFieldGlyphNode concurrently, this static counter needs
to be made thread-safe.

Pick-to: 6.5
Change-Id: Ie8299824e799a9b15bae354314d1fa5c371cf5dc
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 53bd0bb6b06c2d4b4570d22f41dfe3951db785ba)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit b2d7869485b8679bb1f393023af440927bee464d)