qt/qtdeclarative.git, branch v5.9.7 Qt Declarative (Quick 2) Add changes file for Qt 5.9.7 2018-10-05T19:31:02+00:00 Antti Kokko antti.kokko@qt.io 2018-10-03T08:05:03+00:00 9e5de38fbb1d46d2fbd3ace3d5267a2e708d144d + b6d78236e1a87c6f2696fc3ea7214459f6da278c Bump version + cb9537d83046dfbfdbe4977999b606fed879d2d7 Fix out of bounds stack access with the byte code interpreter + 75306a2f438e1d2b3969a7a3b7ffd8e39b84cd11 Fix truncating of doubles to integers + b6ce37a9b7c5058a33d05d307d74f35ebbf1b9e7 QQuickPathViewPrivate: fix heap-use-after-free + 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b stabilize and standardize tst_qquickwidget + 67f88f2342427e8ceb50acdd63444eaa527675b9 Doc: Fix broken link targets + 0e38ce39cd63318f2a10239239b173f17725eecf Remove const from QQuickPointerEvent::device property + 3b3e0c4d80090120fb94fcd42221ddd79a8d0933 Doc: Add precision to scene graph description + 5f364acefa3ce8bc770dd4ddb6d962d9f2ecf292 Doc: Extend ItemSelectionModel QML documentation + 8763b916cd8c65f3519814b00b9a2202c74801ad Doc: Use [] instead of new Array() in snippet + b067e607f1cfd5bee94710d6a6a7c2fa048e9b23 Doc: fix QJSEngine code snippet Change-Id: Ifa84661534e603437e6eeba2ee84a34373f5c84f Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
+ b6d78236e1a87c6f2696fc3ea7214459f6da278c Bump version
+ cb9537d83046dfbfdbe4977999b606fed879d2d7 Fix out of bounds stack access with the byte code interpreter
+ 75306a2f438e1d2b3969a7a3b7ffd8e39b84cd11 Fix truncating of doubles to integers
+ b6ce37a9b7c5058a33d05d307d74f35ebbf1b9e7 QQuickPathViewPrivate: fix heap-use-after-free
+ 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b stabilize and standardize tst_qquickwidget
+ 67f88f2342427e8ceb50acdd63444eaa527675b9 Doc: Fix broken link targets
+ 0e38ce39cd63318f2a10239239b173f17725eecf Remove const from QQuickPointerEvent::device property
+ 3b3e0c4d80090120fb94fcd42221ddd79a8d0933 Doc: Add precision to scene graph description
+ 5f364acefa3ce8bc770dd4ddb6d962d9f2ecf292 Doc: Extend ItemSelectionModel QML documentation
+ 8763b916cd8c65f3519814b00b9a2202c74801ad Doc: Use [] instead of new Array() in snippet
+ b067e607f1cfd5bee94710d6a6a7c2fa048e9b23 Doc: fix QJSEngine code snippet

Change-Id: Ifa84661534e603437e6eeba2ee84a34373f5c84f
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Doc: fix QJSEngine code snippet 2018-08-02T09:41:39+00:00 Samuel Gaist samuel.gaist@edeltech.ch 2017-09-27T21:18:52+00:00 b067e607f1cfd5bee94710d6a6a7c2fa048e9b23 The code snippet showing how to use QJSValue::call was wrong. This patch corrects that. Change-Id: Ib4c6479f3ef63f4f95af845d0af228d3c71f0731 Reviewed-by: Sze Howe Koh <szehowe.koh@gmail.com> (cherry picked from commit ec2388860141dcde6387f4cba482955de648e5aa) Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
The code snippet showing how to use QJSValue::call was wrong. This patch
corrects that.

Change-Id: Ib4c6479f3ef63f4f95af845d0af228d3c71f0731
Reviewed-by: Sze Howe Koh <szehowe.koh@gmail.com>
(cherry picked from commit ec2388860141dcde6387f4cba482955de648e5aa)
Reviewed-by: Samuel Gaist <samuel.gaist@idiap.ch>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Doc: Use [] instead of new Array() in snippet 2018-08-01T09:23:39+00:00 Paul Wicking paul.wicking@qt.io 2018-07-31T13:52:04+00:00 8763b916cd8c65f3519814b00b9a2202c74801ad This change removes warning about using new Array() as constructor with the snippet in Qt Creator. Task-number: QTBUG-65891 Change-Id: I858601c21d703e4226db4f4c4d9ef52ec6418ed8 Reviewed-by: Nico Vertriest <nico.vertriest@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> (cherry picked from commit a30138cae86268d71415bc88cfba157977f4a442) 
This change removes warning about using new Array() as constructor
with the snippet in Qt Creator.

Task-number: QTBUG-65891
Change-Id: I858601c21d703e4226db4f4c4d9ef52ec6418ed8
Reviewed-by: Nico Vertriest <nico.vertriest@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit a30138cae86268d71415bc88cfba157977f4a442)
Doc: Extend ItemSelectionModel QML documentation 2018-07-31T09:39:24+00:00 Paul Wicking paul.wicking@qt.io 2018-07-16T13:35:47+00:00 5f364acefa3ce8bc770dd4ddb6d962d9f2ecf292 This change provides a bare minimum documentation for the ItemSelectionModel QML type. Task-number: QTBUG-58090 Change-Id: I0e232f8e05e7629d6f573f8dce21154d0ec307e5 Reviewed-by: Topi Reiniö <topi.reinio@qt.io> (cherry picked from commit 9ee7b52f3234d12c7617ddf716f54e1923d3cded) 
This change provides a bare minimum documentation for the
ItemSelectionModel QML type.

Task-number: QTBUG-58090
Change-Id: I0e232f8e05e7629d6f573f8dce21154d0ec307e5
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
(cherry picked from commit 9ee7b52f3234d12c7617ddf716f54e1923d3cded)
Doc: Add precision to scene graph description 2018-07-31T09:39:20+00:00 Paul Wicking paul.wicking@qt.io 2018-07-20T18:20:10+00:00 3b3e0c4d80090120fb94fcd42221ddd79a8d0933 Task-number: QTBUG-60913 Change-Id: I3a9d8925337a12a849e39a70f168dbfc7f007e5f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> (cherry picked from commit 785451a30921f11a88d45c1f9e1a00f6c7e571d8) Reviewed-by: Topi Reiniö <topi.reinio@qt.io> 
Task-number: QTBUG-60913
Change-Id: I3a9d8925337a12a849e39a70f168dbfc7f007e5f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 785451a30921f11a88d45c1f9e1a00f6c7e571d8)
Reviewed-by: Topi Reiniö <topi.reinio@qt.io>
Remove const from QQuickPointerEvent::device property 2018-07-30T10:27:50+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-07-27T17:21:05+00:00 0e38ce39cd63318f2a10239239b173f17725eecf A property never has const pointer as its type. Getting this wrong also causes problems with the QML type registration not matching the actual type. Task-number: QTBUG-61749 Change-Id: Ic3c47499cc4dff6df0beecf5b1413c76509ca6f5 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> (cherry picked from commit 1d815780e020a7315dfc4762b6b0280834203e7e) 
A property never has const pointer as its type.  Getting this wrong also
causes problems with the QML type registration not matching the actual type.

Task-number: QTBUG-61749
Change-Id: Ic3c47499cc4dff6df0beecf5b1413c76509ca6f5
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
(cherry picked from commit 1d815780e020a7315dfc4762b6b0280834203e7e)
Doc: Fix broken link targets 2018-07-26T08:20:27+00:00 Paul Wicking paul.wicking@qt.io 2018-07-24T13:32:04+00:00 67f88f2342427e8ceb50acdd63444eaa527675b9 * Rename two section titles that caused confusion for the autolinker. * Add see also link to correct location from SpriteSequence QML type. Task-number: QTBUG-58640 Change-Id: I62b941d00198ac56d998ca14b926c7bb37f6c91e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> (cherry picked from commit afccf3b4654c04c57d4f7e6da09f88e27ffb5a54) 
* Rename two section titles that caused confusion for the autolinker.
* Add see also link to correct location from SpriteSequence QML type.

Task-number: QTBUG-58640
Change-Id: I62b941d00198ac56d998ca14b926c7bb37f6c91e
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit afccf3b4654c04c57d4f7e6da09f88e27ffb5a54)
stabilize and standardize tst_qquickwidget 2018-06-26T17:23:21+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-01-31T19:05:38+00:00 239b8f6ee869dbe1f27ec4fa5d5247eff502c47b In tst_qquickwidget::enterLeave(), start with the cursor outside the same as we do in QtQuick tests: move the window first, then position the cursor to the right of it and downwards (because the window might not necessarily go where you want it to). Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the default anyway. Task-number: QTBUG-64397 Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
In tst_qquickwidget::enterLeave(), start with the cursor outside the
same as we do in QtQuick tests: move the window first, then position
the cursor to the right of it and downwards (because the window might
not necessarily go where you want it to).

Don't hard-code 5000ms timeout on qWaitForWindowExposed(): it's the
default anyway.

Task-number: QTBUG-64397
Change-Id: I67e4566c2c7f9e361a79e3a091436c3391f39786
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
QQuickPathViewPrivate: fix heap-use-after-free 2018-06-25T13:51:03+00:00 Mitch Curtis mitch.curtis@qt.io 2018-06-19T14:04:24+00:00 b6ce37a9b7c5058a33d05d307d74f35ebbf1b9e7 The TabBar auto tests in Qt Quick Controls 2 repeats the following process very quickly for several data rows: 1. Creates a TabBar (PathView, when using the Universal style) 2. Moves items in its QQmlObjectModel 3. Deletes the TabBar When run with ASAN, this test would fail, because the TabButtons (which are child items of the PathView) would try to access a deleted QQuickItemChangeListener upon their destruction. The underlying issue is that QQuickPathView::modelUpdated() is called, and before a refill() can happen, the view is deleted. QQuickPathView::refill() was the only execution path that was releasing the cached items (QQuickPathViewPrivate::itemCache), and since part of releasing an item involves removing the QQuickPathView as a change listener from the item, the item would access the deleted view (listener) when the item was being destroyed. This patch fixes the issue by also releasing cached items in QQuickPathViewPrivate::clear(), which is always called by the destructor. Task-number: QTBUG-68964 Change-Id: Ic5bf0943be79948c86bf7c07ef13ecd1a7b971ba Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Robin Burchell <robin.burchell@crimson.no> (cherry picked from commit 49c244e3c5a9138e6785515ebb64334705236ed4) 
The TabBar auto tests in Qt Quick Controls 2 repeats the following
process very quickly for several data rows:

1. Creates a TabBar (PathView, when using the Universal style)
2. Moves items in its QQmlObjectModel
3. Deletes the TabBar

When run with ASAN, this test would fail, because the TabButtons
(which are child items of the PathView) would try to access a deleted
QQuickItemChangeListener upon their destruction.

The underlying issue is that QQuickPathView::modelUpdated() is called,
and before a refill() can happen, the view is deleted.
QQuickPathView::refill() was the only execution path that was releasing
the cached items (QQuickPathViewPrivate::itemCache), and since part of
releasing an item involves removing the QQuickPathView as a change
listener from the item, the item would access the deleted view
(listener) when the item was being destroyed.

This patch fixes the issue by also releasing cached items in
QQuickPathViewPrivate::clear(), which is always called by the
destructor.

Task-number: QTBUG-68964
Change-Id: Ic5bf0943be79948c86bf7c07ef13ecd1a7b971ba
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Robin Burchell <robin.burchell@crimson.no>
(cherry picked from commit 49c244e3c5a9138e6785515ebb64334705236ed4)
Fix truncating of doubles to integers 2018-06-21T15:05:57+00:00 Simon Hausmann simon.hausmann@qt.io 2018-06-05T11:06:54+00:00 75306a2f438e1d2b3969a7a3b7ffd8e39b84cd11 When analyzing the data flow and determining that a double is or'ed with 0, we correctly assume a cast to an integer and insert a convert instruction in the IR instead of the actual bitwise or.. The JIT implements that, but the interpreter doesn't, resulting in incorrect values. This problem is specific to the SSA optimizer and the underlying isel requirements in 5.9 and does not apply to the design of the code generator in 5.11 and onwards. Task-number: QTBUG-68640 Change-Id: I954086b118b022bc6a8e00f17517c2d378825613 Reviewed-by: Lars Knoll <lars.knoll@qt.io> Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io> 
When analyzing the data flow and determining that a double is or'ed with
0, we correctly assume a cast to an integer and insert a convert
instruction in the IR instead of the actual bitwise or.. The JIT
implements that, but the interpreter doesn't, resulting in incorrect
values.

This problem is specific to the SSA optimizer and the underlying isel
requirements in 5.9 and does not apply to the design of the code
generator in 5.11 and onwards.

Task-number: QTBUG-68640
Change-Id: I954086b118b022bc6a8e00f17517c2d378825613
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
Reviewed-by: Erik Verbruggen <erik.verbruggen@qt.io>