Change-Id: Ia3e2d2de252a6e14cdcc3b15065423e17a9641b3 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
Change-Id: I16f69ecf074dce69bce247b603ce1349063fadac Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
The condition for fixing up the alias property index was wrong. Instead of checking the last list element, it was checking the first element twice. To avoid further mistakes and to make the logic easier to reason about, use std::find and std::distance to compute the index, and rely on the compiler to potentially optimize the loops. Amends 5b775e96c067995bf21cdf5a3641c50d5b7b272d Pick-to: 6.11 dev Fixes: QTBUG-144701 Change-Id: I589378b6cbc8d68f550ff7ec67be9a420ebee4d5 Reviewed-by: Jani Heikkinen <jani.heikkinen@qt.io>
Change-Id: I8bb4e4d500dd5bc7c857fdcdec25c8d029883899 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
Change-Id: I690bc41d021630caeb891a42f9b91ff4778f0a27 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
tst_qquicktext::contentSize(spyWidth.size()) fails consistently on Windows. Instead of blacklisting it, add QEXPECT_FAIL to it. And remove the test blacklists for other Windows compilers, as they also look to be consistently failing and not flaky (QUIP 24). Task-number: QTBUG-88646 Task-number: QTQAINFRA-7559 Pick-to: 6.8 Change-Id: I4e1519767b1804cbe09954d1f25ca11c6c478ac4 Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> (cherry picked from commit c4179b8e121ef9caae8c11adddb8cad2dfc08662) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
When a ViewportOnly rebuild is triggered in TableView by a row or column insertion or removal, delegate items that survive the operation (i.e. are not part of the removed range) should not be pooled and reused. Instead they should simply stay in place and have their context properties updated to reflect any shift in flat index, row or column. This avoids a full pool cycle, preserves any ongoing visual state such as animations, and suppresses unnecessary pooled/reused signals. To achieve this, released items are now staged in a temporary m_releasedItems cache rather than moved directly to the reuse pool. During the rebuild, resolveModelItem() first searches the cache for an item whose QPersistentModelIndex matches the requested cell. If found, the item is reclaimed directly. Once the rebuild is complete, commitReleasedItems() transfers any remaining cached items (those whose cells genuinely disappeared) to the reuse pool, like before. In order to achieve this, a new QPersistentModelIndex is stored on each delegate item. That way we know which cell it originally belonged to, even after changes to the model shifted its row and column position. A new auto-test, verifyThatOnlyRemovedRowsArePooled, is included that verifies the new expected behaviour. The changes in this patch also uncovered that the test model used throughout in the test file was implemented with too many assumptions, and therefore needed some TLC. Fixes: QTBUG-116650 Fixes: QTBUG-134741 Change-Id: I0b935320b6e7dca215df438f5981a154a8c10385 Reviewed-by: SanthoshKumar Selvaraj <santhosh.kumar.selvaraj@qt.io> (cherry picked from commit de4b7283c978ca384f6c8bf9f27387158804b601) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Task-number: QTQAINFRA-7720 Pick-to: 6.8 Change-Id: I475c277aa69f5cfc754206e555258d4f344d1764 Reviewed-by: Simo Fält <simo.falt@qt.io> (cherry picked from commit 254fbf03550d658ff3c712f43916ce9ac37da04c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
When the suggestion model becomes empty, we used to call setCurrentItemAtIndex(-1), which goes through updateDisplayText() and ends up setting the field text to textAt(-1) (an empty string). This can overwrite the user’s input and can trigger binding loops when the model is filtered by SearchField.text. Fix this by resetting with setCurrentIndex(-1) (and clearing the highlight), and by returning early from updateDisplayText() when currentIndex < 0 so we only update the text when there’s an actual selection. Pick-to: 6.10 Fixes: QTBUG-144241 Change-Id: I41c052e2fc1123100c68b0a31645b6f505640cbb Reviewed-by: Jani Korteniemi <jani.korteniemi@qt.io> Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> (cherry picked from commit 67d43908fbae0e3c766a8a99c5d515508a6a207e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Use `this` as the context object, because the lambda acts only on `this`, too. Amends 5af4c9b237a23ce12ca7c56eb6c9ecda17743228 (5.10). Pick-to: 6.8 Task-number: QTBUG-145828 Change-Id: I481cc6dbb7bd4b003c606a9499ccc5ec946d154b Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 92186e50c3548dd0e22b23bf28c9050e443a1502) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>