qt/qtdeclarative.git, branch v6.3.1 Qt Declarative (Quick 2) QSGBatchRenderer: look for ShaderManager by type only, ignore name 2022-06-06T17:56:46+00:00 Marc Mutz marc.mutz@qt.io 2022-06-02T16:29:06+00:00 47ef121e1a436fd46129cdaa1a4398c82045eb97 There's only ever one of them, and accessing objectName() from a different than the owning thread is UB (data race). The default-constructed QString() is needed, cf. QTBUG-103986. This is a hotfix for QTBUG-102403, which ran afoul of the guards added in qtbase/3f32dcd1ddcbe04c77ccd83e2eaa566d7212e732 to fix QTBUG-99775. Task-number: QTBUG-102403 Change-Id: Idf07b1119ec393e7fd179e8b545cfeb70f5916ec Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io> (cherry picked from commit 543806e96da237a4625b593ed773813e0cdfe3fb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
There's only ever one of them, and accessing objectName() from a
different than the owning thread is UB (data race).

The default-constructed QString() is needed, cf. QTBUG-103986.

This is a hotfix for QTBUG-102403, which ran afoul of the guards added
in qtbase/3f32dcd1ddcbe04c77ccd83e2eaa566d7212e732 to fix QTBUG-99775.

Task-number: QTBUG-102403
Change-Id: Idf07b1119ec393e7fd179e8b545cfeb70f5916ec
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@qt.io>
(cherry picked from commit 543806e96da237a4625b593ed773813e0cdfe3fb)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Update dependencies on '6.3.1' in qt/qtdeclarative 2022-06-06T10:17:24+00:00 Qt Submodule Update Bot qt_submodule_update_bot@qt-project.org 2022-06-06T01:29:16+00:00 3e91ad66056ff2ccfb4ba6b85f500827348e9397 Change-Id: I6d5169fc6f83fa24e138571f49ca2d3f3b0babff Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org> 
Change-Id: I6d5169fc6f83fa24e138571f49ca2d3f3b0babff
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
Update dependencies on '6.3.1' in qt/qtdeclarative 2022-06-03T05:09:40+00:00 Qt Submodule Update Bot qt_submodule_update_bot@qt-project.org 2022-06-03T03:19:00+00:00 4ba2c85d12a0953fca1c89b4144019160a0961d5 Change-Id: I187e1c3e528b2ce1997972571d28f87e6dc31b38 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org> 
Change-Id: I187e1c3e528b2ce1997972571d28f87e6dc31b38
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
QV4::CompiledData: fix GCC 12 -Werror=uninitialized errors 2022-06-02T12:30:27+00:00 Marc Mutz marc.mutz@qt.io 2022-06-01T09:12:12+00:00 5050aa901e3dd7fd83423ccbe0e81ab8d921a3e5 The non-default ctors tried to call m_data.set(), where m_data uninitialized. Says GCC 12: In member function ‘QSpecialIntegerAccessor<S, pos, width, T>& QSpecialIntegerAccessor<S, pos, width, T>::operator=(Type) [with S = QLittleEndianStorageType<unsigned int>; int pos = 0; int width = 5; T = unsigned int]’, inlined from ‘void QSpecialIntegerBitfieldUnion<S, Accessors>::set(typename A::Type) [with A = QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 0, 5, unsigned int>; S = QLittleEndianStorageType<unsigned int>; Accessors = {QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 0, 5, unsigned int>, QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 5, 27, unsigned int>}]’ at qtbase/src/corelib/global/qendian_p.h:214:21, inlined from ‘QV4::CompiledData::RegExp::RegExp(quint32, quint32)’ at qtdeclarative/src/qml/common/qv4compileddata_p.h:187:31, inlined from ‘int QV4::Compiler::JSUnitGenerator::registerRegExp(QQmlJS::AST::RegExpLiteral*)’ at qtdeclarative/src/qml/compiler/qv4compiler.cpp:198:34: qtbase/src/corelib/global/qendian_p.h:179:40: error: ‘<unnamed>.QV4::CompiledData::RegExp::m_data.QSpecialIntegerBitfieldUnion<QLittleEndianStorageType<unsigned int>, QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 0, 5, unsigned int>, QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 5, 27, unsigned int> >::storage.QSpecialIntegerStorage<QLittleEndianStorageType<unsigned int> >::val’ is used uninitialized [-Werror=uninitialized] 179 | UnsignedType i = S::fromSpecial(storage->val); | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~ qtdeclarative/src/qml/compiler/qv4compiler.cpp: In member function ‘int QV4::Compiler::JSUnitGenerator::registerRegExp(QQmlJS::AST::RegExpLiteral*)’: qtdeclarative/src/qml/compiler/qv4compiler.cpp:198:90: note: ‘<anonymous>’ declared here 198 | regexps.append(CompiledData::RegExp(flags, registerString(regexp->pattern.toString()))); | ^ Fix by calling the default ctor (which initialized m_data) before calling m_data.set(). Task-number: QTBUG-103924 Change-Id: I44ff404e5509e24601893e539639f213defdc80d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 405f1f7d05a27f659fa47afb5574a159301caff6) Reviewed-by: Marc Mutz <marc.mutz@qt.io> 
The non-default ctors tried to call m_data.set(), where m_data
uninitialized.

Says GCC 12:

  In member function ‘QSpecialIntegerAccessor<S, pos, width, T>& QSpecialIntegerAccessor<S, pos, width, T>::operator=(Type) [with S = QLittleEndianStorageType<unsigned int>; int pos = 0; int width = 5; T = unsigned int]’,
    inlined from ‘void QSpecialIntegerBitfieldUnion<S, Accessors>::set(typename A::Type) [with A = QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 0, 5, unsigned int>; S = QLittleEndianStorageType<unsigned int>; Accessors = {QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 0, 5, unsigned int>, QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 5, 27, unsigned int>}]’ at qtbase/src/corelib/global/qendian_p.h:214:21,
    inlined from ‘QV4::CompiledData::RegExp::RegExp(quint32, quint32)’ at qtdeclarative/src/qml/common/qv4compileddata_p.h:187:31,
    inlined from ‘int QV4::Compiler::JSUnitGenerator::registerRegExp(QQmlJS::AST::RegExpLiteral*)’ at qtdeclarative/src/qml/compiler/qv4compiler.cpp:198:34:
  qtbase/src/corelib/global/qendian_p.h:179:40: error: ‘<unnamed>.QV4::CompiledData::RegExp::m_data.QSpecialIntegerBitfieldUnion<QLittleEndianStorageType<unsigned int>, QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 0, 5, unsigned int>, QSpecialIntegerAccessor<QLittleEndianStorageType<unsigned int>, 5, 27, unsigned int> >::storage.QSpecialIntegerStorage<QLittleEndianStorageType<unsigned int> >::val’ is used uninitialized [-Werror=uninitialized]
    179 |         UnsignedType i = S::fromSpecial(storage->val);
        |                          ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
  qtdeclarative/src/qml/compiler/qv4compiler.cpp: In member function ‘int QV4::Compiler::JSUnitGenerator::registerRegExp(QQmlJS::AST::RegExpLiteral*)’:
  qtdeclarative/src/qml/compiler/qv4compiler.cpp:198:90: note: ‘<anonymous>’ declared here
    198 |     regexps.append(CompiledData::RegExp(flags, registerString(regexp->pattern.toString())));
        |                                                                                          ^

Fix by calling the default ctor (which initialized m_data) before
calling m_data.set().

Task-number: QTBUG-103924
Change-Id: I44ff404e5509e24601893e539639f213defdc80d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 405f1f7d05a27f659fa47afb5574a159301caff6)
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
Fix flaky tst_QQuickFileDialogImpl::goUp test 2022-06-01T08:30:01+00:00 Mitch Curtis mitch.curtis@qt.io 2022-04-12T02:36:08+00:00 ec1dc0ed933a8270ec59ff69c41987862398ea2d Don't listen to fileDialogListView currentIndexChanged signal while setting its currentIndex, because the file associated with the delegate is not correct at that stage. Change-Id: Iffc9315c03b6670bc3a7609f3613a4570e4f9632 Fixes: QTBUG-101488 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit dc86f974f0ce5ac57ddeceee3b020661b932f6b1) Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io> 
Don't listen to fileDialogListView currentIndexChanged signal while
setting its currentIndex, because the file associated with the delegate
is not correct at that stage.

Change-Id: Iffc9315c03b6670bc3a7609f3613a4570e4f9632
Fixes: QTBUG-101488
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit dc86f974f0ce5ac57ddeceee3b020661b932f6b1)
Reviewed-by: Pasi Petäjäjärvi <pasi.petajajarvi@qt.io>
Update dependencies on '6.3' in qt/qtdeclarative 2022-05-31T05:23:38+00:00 Qt Submodule Update Bot qt_submodule_update_bot@qt-project.org 2022-05-31T05:23:33+00:00 82313391aad3473b29b2bd79de419d0f1ac2a563 Change-Id: I9ee0033ed1c2fbc2c984d1ea91e61a7984bd70d9 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org> 
Change-Id: I9ee0033ed1c2fbc2c984d1ea91e61a7984bd70d9
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
Fix \relates for Q_IMPORT_QML_PLUGIN 2022-05-30T17:41:08+00:00 Fabian Kosmale fabian.kosmale@qt.io 2022-05-27T13:35:58+00:00 77b4884c0d64f221acb312604f0647e8c409c79e Refer to the class instead of trying to refer to the header. The latter does not associate it with the actual page and creates a proxy page instead. As a drive-by, mention that the macro only exists from 6.2 onwards. Change-Id: I531ee92257e6631a5b7830d881b1ef42a7ea61b1 Reviewed-by: Andrei Golubev <andrei.golubev@qt.io> (cherry picked from commit feff2898fe6b457ed9f999c110bb89dea042285b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Refer to the class instead of trying to refer to the header. The latter
does not associate it with the actual page and creates a proxy page
instead.
As a drive-by, mention that the macro only exists from 6.2 onwards.

Change-Id: I531ee92257e6631a5b7830d881b1ef42a7ea61b1
Reviewed-by: Andrei Golubev <andrei.golubev@qt.io>
(cherry picked from commit feff2898fe6b457ed9f999c110bb89dea042285b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QQuickSelectionRectangle: ensure we start the selection where the drag started 2022-05-30T13:43:12+00:00 Richard Moe Gustavsen richard.gustavsen@qt.io 2022-05-25T13:29:36+00:00 baad186daf64d059f0e67d93c55f3aa380c8763a We should start the selection in TableView at the position where the user started the drag, and not where the centroid at the time when the dragging gets active (which is an offset equal to the mousePressAndHoldInterval property in QStyleHints). Change-Id: Ibe330d31c1e2c8022006a56b7119b1dcb3e0e5b9 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 6d2d4914f884fc1a88382ba5cb6eeeeab272874e) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
We should start the selection in TableView at the position where the
user started the drag, and not where the centroid at the time when the
dragging gets active (which is an offset equal to the
mousePressAndHoldInterval property in QStyleHints).

Change-Id: Ibe330d31c1e2c8022006a56b7119b1dcb3e0e5b9
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 6d2d4914f884fc1a88382ba5cb6eeeeab272874e)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Doc: clarify when SpinBox's valueModified signal is emitted 2022-05-30T08:45:28+00:00 Mitch Curtis mitch.curtis@qt.io 2022-05-26T13:42:38+00:00 69e9c7e3b1ad9c601e7f3f1a1f80d5578bcfbfc9 Task-number: QTBUG-103205 Change-Id: I0450c0218c5a3e14d373c0a39c29749c8bf958d5 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> (cherry picked from commit b1cdd12ac51412550b11089911f582d48f8cad82) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Task-number: QTBUG-103205
Change-Id: I0450c0218c5a3e14d373c0a39c29749c8bf958d5
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit b1cdd12ac51412550b11089911f582d48f8cad82)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Popup: don't close when releasing a drag outside of the popup 2022-05-27T10:31:36+00:00 Soheil Armin soheil.armin@qt.io 2022-05-03T14:50:09+00:00 aa67903259496a5644b9cbb4ee5a84f877795d94 If a release mouse/touch event happens outside of the popup (or its parent), and the close policy is CloseOnReleaseOutside(Parent), the popup will be closed regardless of the where the mousepress event happened. The user expect to close the popup if and only if the press is also follows the same policy (outside of the popup or its parent depending on the flag). New test cases added to verify it as well. Fixes: QTBUG-67512 Change-Id: I034bfb6b39dd5d6370b97b4833ffb91751c13ed2 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> (cherry picked from commit 89b8beecedb2d05ff987a188342bcce9676f3736) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
If a release mouse/touch event happens outside of the popup (or its
parent), and the close policy is CloseOnReleaseOutside(Parent), the
popup will be closed regardless of the where the mousepress event
happened. The user expect to close the popup if and only if the press is
also follows the same policy (outside of the popup or its parent
depending on the flag).

New test cases added to verify it as well.

Fixes: QTBUG-67512
Change-Id: I034bfb6b39dd5d6370b97b4833ffb91751c13ed2
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 89b8beecedb2d05ff987a188342bcce9676f3736)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>