qt/qtdeclarative.git, branch v6.4.1 Qt Declarative (Quick 2) Update dependencies on '6.4.1' in qt/qtdeclarative 2022-11-08T16:09:55+00:00 Qt Submodule Update Bot qt_submodule_update_bot@qt-project.org 2022-11-08T16:09:50+00:00 a514640b2a38391fceaaac3ca01b390ad3d62f31 Change-Id: I11c3ce8b747daba8805de8d9d0de689ae5084d5a Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org> 
Change-Id: I11c3ce8b747daba8805de8d9d0de689ae5084d5a
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
Update dependencies on '6.4.1' in qt/qtdeclarative 2022-11-08T07:21:28+00:00 Qt Submodule Update Bot qt_submodule_update_bot@qt-project.org 2022-11-08T05:08:40+00:00 c7ef4901c2315f049c6dd54fcc372eff5d1e11ea Change-Id: I605772e77d7ceff2630ca7abe028c788208f2c7f Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org> 
Change-Id: I605772e77d7ceff2630ca7abe028c788208f2c7f
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
Update dependencies on '6.4.1' in qt/qtdeclarative 2022-11-03T04:54:18+00:00 Qt Submodule Update Bot qt_submodule_update_bot@qt-project.org 2022-11-03T04:54:13+00:00 3fc4e37881c628ded95ee7e90cdc8bd8282804cb Change-Id: Ia4ebd80f6f44f1bc5ac1f2b436713b3b24df4c74 Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org> 
Change-Id: Ia4ebd80f6f44f1bc5ac1f2b436713b3b24df4c74
Reviewed-by: Qt Submodule Update Bot <qt_submodule_update_bot@qt-project.org>
DA: don't ignore subtreeHoverEnabled 2022-11-01T17:47:47+00:00 Richard Moe Gustavsen richard.gustavsen@qt.io 2022-10-27T13:54:39+00:00 46e4039bb2c2dd09c6f027a174a45d887b81320b The current hover delivery logic in the DA was currently only taking subtreeHoverEnabled into account for disabled items. This meant that subtreeHoverEnabled was in practice undermined by the DA, and resulted in far too many items in the scene being visited. Moreover, according to tst_HoverHandler::hoverHandlerOnDisabledItem(), and QTBUG-30801, we should always deliver hover events to disabled items. This patch will therefore change the test, so that we always check if subtreeHoverEnabled is set before we recurse into the child. Whether or not the item is enabled or disabled is not relevant, and therefore removed. This will ensure that we e.g don't visit all the delegate items in a TableView for each pointer move, just because TableView itself subscribes to hover (unless the delegate is also subscribing to hover). Note: This patch is only an optimization, and shouldn't affect which items and handlers we end up actually delivering hover events to. It will only stop the DA from recursing into too many items. Amends 831efa14e91cfa358e57a32197578d41c2ae1b24 Change-Id: I6ddf963c3ac99ef54da08f64dc5660bc35a295e0 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit e3a8d8136706c9c50d76a39b72ab90cced34cca7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
The current hover delivery logic in the DA was currently
only taking subtreeHoverEnabled into account for disabled
items. This meant that subtreeHoverEnabled was in practice
undermined by the DA, and resulted in far too many items in
the scene being visited.

Moreover, according to
tst_HoverHandler::hoverHandlerOnDisabledItem(), and
QTBUG-30801, we should always deliver hover events to
disabled items.

This patch will therefore change the test, so that we
always check if subtreeHoverEnabled is set before we
recurse into the child. Whether or not the item is enabled
or disabled is not relevant, and therefore removed.

This will ensure that we e.g don't visit all the delegate
items in a TableView for each pointer move, just because
TableView itself subscribes to hover (unless the
delegate is also subscribing to hover).

Note: This patch is only an optimization, and shouldn't
affect which items and handlers we end up actually
delivering hover events to. It will only stop the DA
from recursing into too many items.

Amends 831efa14e91cfa358e57a32197578d41c2ae1b24

Change-Id: I6ddf963c3ac99ef54da08f64dc5660bc35a295e0
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit e3a8d8136706c9c50d76a39b72ab90cced34cca7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Doc: add notes for customization of the attached ToolTip control 2022-11-01T17:47:47+00:00 Mitch Curtis mitch.curtis@qt.io 2022-10-31T02:50:56+00:00 2b0b1549f072d0b693f2ad97a55e480efb8db86c To customize the attached ToolTip, it must be provided as part of the user's style. Task-number: QTBUG-107684 Change-Id: I8fd2c4c64ad7aad4b940031fb3638df211288903 Reviewed-by: Paul Wicking <paul.wicking@qt.io> (cherry picked from commit e59c31c0afd128533bbe3edd93b516f0a693c221) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
To customize the attached ToolTip, it must be provided as part of the
user's style.

Task-number: QTBUG-107684
Change-Id: I8fd2c4c64ad7aad4b940031fb3638df211288903
Reviewed-by: Paul Wicking <paul.wicking@qt.io>
(cherry picked from commit e59c31c0afd128533bbe3edd93b516f0a693c221)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QQmlComponent: Don't crash on unknown properties 2022-11-01T14:37:53+00:00 Ulf Hermann ulf.hermann@qt.io 2022-10-06T09:32:02+00:00 a67c6aef5d0ae94563dd87d9658c594d145b6e7b Fixes: QTBUG-107254 Change-Id: Ic3b3ceff50583eb22224a56fc594863d28eee9fd Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: Semih Yavuz <semih.yavuz@qt.io> (cherry picked from commit 54afc9b12cea4be2b3d9eae91b22383460469534) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Fixes: QTBUG-107254
Change-Id: Ic3b3ceff50583eb22224a56fc594863d28eee9fd
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
(cherry picked from commit 54afc9b12cea4be2b3d9eae91b22383460469534)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
tst_qqmlchangeset: fix target name typo and de-duplicate tests 2022-11-01T14:37:53+00:00 Mitch Curtis mitch.curtis@qt.io 2022-05-19T06:27:10+00:00 5734a0557bca4f594d6f80f78a914ea8e0aa2224 There was a typo in the auto test's target name, but fixing it also requires renaming the benchmark which has the same name. Change-Id: I8e7b6de472ed84df0917584592f28d7015618331 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 955705d91c77980d95a877bb0ade4428639f9170) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
There was a typo in the auto test's target name, but fixing it also
requires renaming the benchmark which has the same name.

Change-Id: I8e7b6de472ed84df0917584592f28d7015618331
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 955705d91c77980d95a877bb0ade4428639f9170)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Check only for enabled HoverHandlers 2022-11-01T11:47:57+00:00 Shawn Rutledge shawn.rutledge@qt.io 2022-10-31T13:51:19+00:00 02af6d91606efa3b2115c2d31adb4f29b2e60869 QQuickItemPrivate::hasHoverHandlers() was used only in QQuickItemPrivate::setHasHoverInChild(). In that context it's ok to ignore disabled HoverHandler instances: the point is we don't need to deliver hover events to an item subtree if nobody is listening. Change-Id: Ie44b6e259db862161a28ab5b7d1e910dc6ca4640 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit 570a0fbc57a24116d47da056743961af06e50f86) 
QQuickItemPrivate::hasHoverHandlers() was used only in
QQuickItemPrivate::setHasHoverInChild(). In that context it's ok to
ignore disabled HoverHandler instances: the point is we don't need to
deliver hover events to an item subtree if nobody is listening.

Change-Id: Ie44b6e259db862161a28ab5b7d1e910dc6ca4640
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit 570a0fbc57a24116d47da056743961af06e50f86)
QQuickHoverHandler: listen for parent changes, and update hasHoverInChild 2022-11-01T09:18:09+00:00 Richard Moe Gustavsen richard.gustavsen@qt.io 2022-10-26T12:03:30+00:00 eca92bea571cf691423b627d4d6270f7c2807bd9 A QQuickHoverHandler is normally created by the QML engine, but can sometimes also be created directly from C++. And for the latter case, QQuickHoverHandler::componentComplete() will not be called. This causes a problem, since it takes care of subscribing for hover events on the parent item. To support creating hover handlers from c++, we therefore need to also subscribe to hover events from the constructor. Moreover, since the parentItem can change at runtime, we also need a virtual function that informs it when the parent item changes, so that we can remove hover subscription from the old parent, and subscribe for it on the new parent. Change-Id: I52f3cd16d6bbfbbe2e4c3c019efdc7f06c5f2c31 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 7db67e59d45b47e45a2723808f23e8cdadf5065c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
A QQuickHoverHandler is normally created by the QML engine, but
can sometimes also be created directly from C++. And for
the latter case, QQuickHoverHandler::componentComplete() will
not be called. This causes a problem, since it takes care of
subscribing for hover events on the parent item.

To support creating hover handlers from c++, we therefore need
to also subscribe to hover events from the constructor.
Moreover, since the parentItem can change at runtime, we also
need a virtual function that informs it when the parent item
changes, so that we can remove hover subscription from the old
parent, and subscribe for it on the new parent.

Change-Id: I52f3cd16d6bbfbbe2e4c3c019efdc7f06c5f2c31
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 7db67e59d45b47e45a2723808f23e8cdadf5065c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Qml: add test for nested group properties fix 2022-10-31T19:34:01+00:00 Sami Shalayel sami.shalayel@qt.io 2022-10-25T13:52:35+00:00 e27b91e4cc277698c62191ce3c349afc988a2a2b Amends fed5b07980d9ae5a392a00563f70ee34fc261dbc by adding another test that also stopped crashing with fed5b07980d9ae5a392a00563f70ee34fc261dbc, to avoid any regressions of this crash in the future. Task-number: QTBUG-107795 Change-Id: I2789be2d6c089d27687ff8f64ed8a3a819ffa5a7 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 728270a0cb8f652ffe4bf0da623583674e6f9357) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Amends fed5b07980d9ae5a392a00563f70ee34fc261dbc by adding another test
that also stopped crashing with fed5b07980d9ae5a392a00563f70ee34fc261dbc,
to avoid any regressions of this crash in the future.

Task-number: QTBUG-107795
Change-Id: I2789be2d6c089d27687ff8f64ed8a3a819ffa5a7
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 728270a0cb8f652ffe4bf0da623583674e6f9357)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>