Our own modules should have PROJECT_VERSION and depend and import other modules with "auto" so as to forward the same version. This ensures consistency when users import our modules. Use DEPENDENCIES rather than DEFAULT_IMPORTS for expressing dependencies. DEFAULT_IMPORTS is used to select the default from a number of optional imports. When used incorrectly it confuses tooling. Change-Id: Idaa96be247d57f19bca3e2e88243008e20581ff2 Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
We want to make them available to IDEs so that we don't have to search the file system. Exclude quickcontrols and quicktemplates for now. In these projects the qdoc files are managed separately. Change-Id: I4505216a891addbe0e07ae809126e69ab65b62ca Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Since QVector is just an alias, let's finally do what we could have done for Qt 6.0. Pick-to: 6.11 Change-Id: Ia9dbc8ecf4f099339cf7639acb22c14b24fa680b Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
The image loader (QuickSharedImageLoader) uses shared memory (QSharedMemory) but it shouldn't trigger security issue from the framework itself. QUIP: 23 Task-number: QTBUG-136184 Pick-to: 6.10 6.8 Change-Id: Ie0c5f63e3c7d4c8557dab8c12af412fd6dad1464 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
This causes user projects to automatically find the private Qt module packages and expose the Private targets and their headers, without the user project explicitly opting into this, and without showing them a warning. Pick-to: 6.10 Task-number: QTBUG-138712 Change-Id: Ia50bb6d128fe018c71d976f91abdab75790b6142 Reviewed-by: Alexey Edelev <alexey.edelev@qt.io>
The behavior that argument was enabling is the default one now. Pick-to: 6.8 Task-number: QTBUG-90492 Change-Id: I11711d4c794f0b22169abb595b8ffad2eeb1300d Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
Task-number: QTBUG-117983 Change-Id: I584116bfd4d47deca914910b712c2ea3295f3e7f Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Task-number: QTBUG-117983 Change-Id: I81cd5377b9587468c896ed300a52510e3126065e Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
All these TUs relied on transitive includes of qpointer.h, maybe to a large extent via qevent.h, though, given that qevent.h is more or less the only public QtBase header that includes qpointer.h, something else seems to be at play here. Said qevent.h actually needs QPointer in-name-only, so a forward declaration would suffice. Prepare for qevent.h dropping the include. The algorithm I used was: If the TU mentions 'passiveGrabbers', the name of the QEvent function that returns QPointers, and the TU doesn't have qpointer.h included explicitly, include it. That may produce False Positives, but better safe than sorry. Otherwise, in src/, add an include to all source and header files which mention QPointer. Exception: if foo.h of a foo.cpp already includes it, don't include again. Task-number: QTBUG-117670 Change-Id: I9b98cda524a0e6a61be7805edda708916bb2bc2b Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
We need to be able to do a leak check in tst_qquickpixmapcache. So we also need to use the singleton pattern rather than Q_GLOBAL_STATIC. Since it gets more exposed this way, make the badly-encapsulated parts of API available only to friends. It's always been bothersome that various other places in the code are including qquickpixmapcache_p.h to get QQuickPixmap, and qquickpixmapcache_p.h also does not include any class called QQuickPixmapCache as you'd expect; while arguably, QQuickPixmapStore is the cache. Often in comments I've needed to refer to "the code in qquickpixmapcache.cpp" because it's a very private, inbred family of related classes that don't match the header name. So now we split the headers: qquickpixmapcache_p.h is for the cache, which is now called QQuickPixmapCache; and qquickpixmap_p.h is the header most often needed in other places. Most classes in qquickpixmap_p.h are exported, but QQuickPixmapCache itself is not (except for autotests). It cannot be defined in the header that gets included in Particles for example: then it wouldn't link, because the implementation is not (and shouldn't be) exported, and that's not what Particles needs anyway. Task-number: QTBUG-81266 Task-number: QTBUG-114953 Change-Id: Ifd7f253b8bbaa130eb52d5546f342754f99f47bb Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>