qt/qtdeclarative.git/src/plugins/qmltooling/qmldbg_tcp/qtcpserverconnection.cpp, branch dev Qt Declarative (Quick 2) QmlTooling: Add security headers 2025-10-31T18:55:36+00:00 Ulf Hermann ulf.hermann@qt.io 2025-10-30T15:15:11+00:00 05f1bad85561dc77d7e08599b8119920ad62d6a1 The whole debugging framework (services and clients) should only be used in trusted environments. Therefore it's "significant" despite using network connections and parsing data. Mark the code the enables the debug framework in qqmldebug.{h|cpp} as crtical in turn. Fixes: QTBUG-136187 Pick-to: 6.10 6.8 Change-Id: Ie0a4ad555e088f564a233629e4d99e84b1327486 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> 
The whole debugging framework (services and clients) should only be
used in trusted environments. Therefore it's "significant" despite
using network connections and parsing data.

Mark the code the enables the debug framework in qqmldebug.{h|cpp} as
crtical in turn.

Fixes: QTBUG-136187
Pick-to: 6.10 6.8
Change-Id: Ie0a4ad555e088f564a233629e4d99e84b1327486
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
QTcpServerConnection: move QTcpServerConnectionFactory definition into .cpp 2022-05-10T18:08:34+00:00 Marc Mutz marc.mutz@qt.io 2022-05-09T16:26:42+00:00 58edc1bec9eb8591dbb8dc16de56f239fade8efd The QTcpServerConnection definition is already there, too, so we reduce the number of moc runs by one, and avoid an unhappy includemocs script happy, which was unable to associate the header moc file with the cpp file (because of differing basenames). Pick-to: 6.3 Task-number: QTBUG-102948 Change-Id: If291834c29e5838a7be35b24d40aa7a578d64394 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> 
The QTcpServerConnection definition is already there, too, so we
reduce the number of moc runs by one, and avoid an unhappy includemocs
script happy, which was unable to associate the header moc file with
the cpp file (because of differing basenames).

Pick-to: 6.3
Task-number: QTBUG-102948
Change-Id: If291834c29e5838a7be35b24d40aa7a578d64394
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
use the override keyword consistently and correctly (clang-tidy) 2018-02-27T08:27:38+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-26T16:34:27+00:00 e17c89f4ce74e5699ed50dc2187a39d8990316c4 Change-Id: If9e28d143f8cba3df3c757476b4f2265e2eb8b2a Reviewed-by: Johan Helsing <johan.helsing@qt.io> 
Change-Id: If9e28d143f8cba3df3c757476b4f2265e2eb8b2a
Reviewed-by: Johan Helsing <johan.helsing@qt.io>
init variables where they are declared when possible (clang-tidy) 2018-02-26T13:08:30+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-21T10:52:59+00:00 06e962f263a86c4b66e1c6195b3d2615695fea1e clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f Reviewed-by: Johan Helsing <johan.helsing@qt.io> 
clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init'
 -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix

Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f
Reviewed-by: Johan Helsing <johan.helsing@qt.io>
use nullptr consistently (clang-tidy) 2018-02-26T07:13:18+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-21T09:41:54+00:00 499ec43937e926e4f2fa57a9baa455fcb3862262 From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
From now on we prefer nullptr instead of 0 to clarify cases where
we are assigning or testing a pointer rather than a numeric zero.

Also, replaced cases where 0 was passed as Qt::KeyboardModifiers
with Qt::NoModifier (clang-tidy replaced them with nullptr, which
waas wrong, so it was just as well to make the tests more readable
rather than to revert those lines).

Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Dissolve src/plugins/qmltooling/shared 2017-11-05T12:25:10+00:00 Ulf Hermann ulf.hermann@qt.io 2017-10-06T13:59:39+00:00 10888a5c758037668e06733e4ba1a90aef870ddf QQmlDebugPacket is moved to PacketProtocol, and the other headers to src/qml/debugger. This makes it easier to develop debug plugins in external repositories. Change-Id: I1ab099a304dad793ec13aaef414071cab6d7d408 Reviewed-by: Lars Knoll <lars.knoll@qt.io> 
QQmlDebugPacket is moved to PacketProtocol, and the other headers to
src/qml/debugger. This makes it easier to develop debug plugins in
external repositories.

Change-Id: I1ab099a304dad793ec13aaef414071cab6d7d408
Reviewed-by: Lars Knoll <lars.knoll@qt.io>
sources: Add missing override and remove redundant virtual 2017-02-23T14:26:49+00:00 Alexander Volkov a.volkov@rusbitech.ru 2016-12-07T22:53:14+00:00 febb1f721f720bb9f32bb60c711f709faadb366a Change-Id: I48e26b1491024d41ebf75d40f0d1a7e9a1b20f22 Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru> Reviewed-by: Marc Mutz <marc.mutz@kdab.com> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Change-Id: I48e26b1491024d41ebf75d40f0d1a7e9a1b20f22
Reviewed-by: Anton Kudryavtsev <antkudr@mail.ru>
Reviewed-by: Marc Mutz <marc.mutz@kdab.com>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Tooling: Convert connects to Qt5 style 2016-07-28T09:17:49+00:00 Ulf Hermann ulf.hermann@qt.io 2016-07-20T13:35:50+00:00 bd48f0e5edb1d5ce10529360fb9d14e7b7135022 Change-Id: I6746b777f73d047f5cf610bfca9b320ac1e13676 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
Change-Id: I6746b777f73d047f5cf610bfca9b320ac1e13676
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Updated license headers 2016-01-19T14:53:18+00:00 Jani Heikkinen jani.heikkinen@theqtcompany.com 2016-01-19T09:38:36+00:00 45bd04ba73bd3e71c070e5724535ba87f6771323 From Qt 5.7 -> LGPL v2.1 isn't an option anymore, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new LGPL header instead of LGPL21 one (in those files which will be under LGPL v3) Change-Id: Ic36f1a0a1436fe6ac6eeca8c2375a79857e9cb12 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com> 
From Qt 5.7 -> LGPL v2.1 isn't an option anymore, see
http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/

Updated license headers to use new LGPL header instead of LGPL21 one
(in those files which will be under LGPL v3)

Change-Id: Ic36f1a0a1436fe6ac6eeca8c2375a79857e9cb12
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>