qt/qtdeclarative.git/src/qml/animations/qcontinuinganimationgroupjob.cpp, branch dev Qt Declarative (Quick 2) CRA review: mark files in qml/animation folder 2026-02-06T08:48:59+00:00 Fabian Kosmale fabian.kosmale@qt.io 2026-02-03T14:43:47+00:00 1b3036eaf65acf437146592ac258220e53bb6df0 Nothings stands out, everything gets default significance. Pick-to: 6.11 6.10 6.8 Task-number: QTBUG-136194 Fixes: QTBUG-143930 Change-Id: If6db33dce368881c38ca2b10082c4609dd9cd6c7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Nothings stands out, everything gets default significance.

Pick-to: 6.11 6.10 6.8
Task-number: QTBUG-136194
Fixes: QTBUG-143930
Change-Id: If6db33dce368881c38ca2b10082c4609dd9cd6c7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Quick Animations: Fix crash 2022-05-04T11:46:02+00:00 Fabian Kosmale fabian.kosmale@qt.io 2022-03-29T08:44:04+00:00 0238af0bd48b831d72126f2228d5913eccf67bae SwipeDelegate causes the running animation job to be deleted when calling swipe.close in swipe.completed. Employ the RETURN_IF_DELETED check in more places to avoid crashes. Fixes: QTBUG-100560 Task-number: QTBUG-103223 Pick-to: 6.3 6.2 5.15 Change-Id: I276eeaa9aed1bdb36449b322a24641fa02c4d5e4 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
SwipeDelegate causes the running animation job to be deleted when
calling swipe.close in swipe.completed. Employ the RETURN_IF_DELETED
check in more places to avoid crashes.

Fixes: QTBUG-100560
Task-number: QTBUG-103223
Pick-to: 6.3 6.2 5.15
Change-Id: I276eeaa9aed1bdb36449b322a24641fa02c4d5e4
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Use a QDoubleEndedList for the children of animation group jobs 2021-02-05T14:20:02+00:00 Ulf Hermann ulf.hermann@qt.io 2021-02-03T13:24:14+00:00 4938984f9a779192264757a06e6ca555fc8f5e91 This way it's fundamentally impossible to add the same animation job to two different group jobs. The pointers are not exposed anymore and no one can re-order the jobs. Task-number: QTBUG-90401 Change-Id: Iebff4b64960c853915dd32714acd144fc5cdc00d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This way it's fundamentally impossible to add the same animation job to
two different group jobs. The pointers are not exposed anymore and no
one can re-order the jobs.

Task-number: QTBUG-90401
Change-Id: Iebff4b64960c853915dd32714acd144fc5cdc00d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Fix Qt6 build in preparation of qt5 submodule update 2019-07-08T03:56:02+00:00 Alexandru Croitor alexandru.croitor@qt.io 2019-06-26T14:46:23+00:00 1c5c5f7aadc2dcc73a21eeb818e95c4e1b7de70f Fixes the QTextStream usages. Change-Id: I0c009a82fb644a9f3c3d42ec410d18b680977f23 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
Fixes the QTextStream usages.

Change-Id: I0c009a82fb644a9f3c3d42ec410d18b680977f23
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
init variables where they are declared when possible (clang-tidy) 2018-02-26T13:08:30+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-21T10:52:59+00:00 06e962f263a86c4b66e1c6195b3d2615695fea1e clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init' -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f Reviewed-by: Johan Helsing <johan.helsing@qt.io> 
clang-tidy -p compile_commands.json $file -checks='-*,modernize-use-default-member-init,readability-redundant-member-init'
 -config='{CheckOptions: [{key: modernize-use-default-member-init.UseAssignment, value: "1"}]}' -header-filter='qtdeclarative' -fix

Change-Id: I705f3235ff129ba68b0d8dad54a083e29fcead5f
Reviewed-by: Johan Helsing <johan.helsing@qt.io>
Updated license headers 2016-01-19T14:53:18+00:00 Jani Heikkinen jani.heikkinen@theqtcompany.com 2016-01-19T09:38:36+00:00 45bd04ba73bd3e71c070e5724535ba87f6771323 From Qt 5.7 -> LGPL v2.1 isn't an option anymore, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new LGPL header instead of LGPL21 one (in those files which will be under LGPL v3) Change-Id: Ic36f1a0a1436fe6ac6eeca8c2375a79857e9cb12 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com> 
From Qt 5.7 -> LGPL v2.1 isn't an option anymore, see
http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/

Updated license headers to use new LGPL header instead of LGPL21 one
(in those files which will be under LGPL v3)

Change-Id: Ic36f1a0a1436fe6ac6eeca8c2375a79857e9cb12
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
QtQml: Fix const correctness in old style casts 2015-07-09T00:12:37+00:00 Thiago Macieira thiago.macieira@intel.com 2015-03-07T22:35:47+00:00 f35be0bc5afe940bb95695a319176e45fec1f594 Found with GCC's -Wcast-qual. Change-Id: Ia0aac2f09e9245339951ffff13c958364a2e9859 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com> 
Found with GCC's -Wcast-qual.

Change-Id: Ia0aac2f09e9245339951ffff13c958364a2e9859
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>
Update copyright headers 2015-02-12T10:28:11+00:00 Jani Heikkinen jani.heikkinen@theqtcompany.com 2015-01-28T11:55:39+00:00 c5796292adf7cb7f2ce6f95fb83a9da89ecaa730 Qt copyrights are now in The Qt Company, so we could update the source code headers accordingly. In the same go we should also fix the links to point to qt.io. Change-Id: I61120571787870c0ed17066afb31779b1e6e30e9 Reviewed-by: Iikka Eklund <iikka.eklund@theqtcompany.com> 
Qt copyrights are now in The Qt Company, so we could update the source
code headers accordingly. In the same go we should also fix the links to
point to qt.io.

Change-Id: I61120571787870c0ed17066afb31779b1e6e30e9
Reviewed-by: Iikka Eklund <iikka.eklund@theqtcompany.com>
Update license headers and add new licenses 2014-08-25T09:28:46+00:00 Jani Heikkinen jani.heikkinen@digia.com 2014-08-22T06:13:59+00:00 e7ceacda70857f68a4c406c898bcd9b517ac1b43 - Renamed LICENSE.LGPL to LICENSE.LGPLv21 - Added LICENSE.LGPLv3 & LICENSE.GPLv2 - Removed LICENSE.GPL Change-Id: I84a565e2e0caa3b76bf291a7d188a57a4b00e1b0 Reviewed-by: Jani Heikkinen <jani.heikkinen@digia.com> 
- Renamed LICENSE.LGPL to LICENSE.LGPLv21
- Added LICENSE.LGPLv3 & LICENSE.GPLv2
- Removed LICENSE.GPL

Change-Id: I84a565e2e0caa3b76bf291a7d188a57a4b00e1b0
Reviewed-by: Jani Heikkinen <jani.heikkinen@digia.com>