qt/qtdeclarative.git/src/qml/animations/qsequentialanimationgroupjob.cpp, branch dev Qt Declarative (Quick 2) CRA review: mark files in qml/animation folder 2026-02-06T08:48:59+00:00 Fabian Kosmale fabian.kosmale@qt.io 2026-02-03T14:43:47+00:00 1b3036eaf65acf437146592ac258220e53bb6df0 Nothings stands out, everything gets default significance. Pick-to: 6.11 6.10 6.8 Task-number: QTBUG-136194 Fixes: QTBUG-143930 Change-Id: If6db33dce368881c38ca2b10082c4609dd9cd6c7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Nothings stands out, everything gets default significance.

Pick-to: 6.11 6.10 6.8
Task-number: QTBUG-136194
Fixes: QTBUG-143930
Change-Id: If6db33dce368881c38ca2b10082c4609dd9cd6c7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Use a QDoubleEndedList for the children of animation group jobs 2021-02-05T14:20:02+00:00 Ulf Hermann ulf.hermann@qt.io 2021-02-03T13:24:14+00:00 4938984f9a779192264757a06e6ca555fc8f5e91 This way it's fundamentally impossible to add the same animation job to two different group jobs. The pointers are not exposed anymore and no one can re-order the jobs. Task-number: QTBUG-90401 Change-Id: Iebff4b64960c853915dd32714acd144fc5cdc00d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This way it's fundamentally impossible to add the same animation job to
two different group jobs. The pointers are not exposed anymore and no
one can re-order the jobs.

Task-number: QTBUG-90401
Change-Id: Iebff4b64960c853915dd32714acd144fc5cdc00d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
QSequentialAnimationGroupJob: Protect against self-deletion 2021-02-05T14:19:56+00:00 Ulf Hermann ulf.hermann@qt.io 2021-02-05T12:18:25+00:00 680f28b08f65ad38c8d5498b5738231b2a2779a3 setCurrentAnimation() can indirectly delete the animation group job itself by invoking the animation controller. Use the RETURN_IF_DELETED mechanism to avoid the resulting dangling pointers. Task-number: QTBUG-90401 Pick-to: 6.1 6.0 5.15 5.12 Change-Id: Ibd0ad21e8d3af4760604c3ff37dc46101d5f49ad Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
setCurrentAnimation() can indirectly delete the animation group job
itself by invoking the animation controller. Use the RETURN_IF_DELETED
mechanism to avoid the resulting dangling pointers.

Task-number: QTBUG-90401
Pick-to: 6.1 6.0 5.15 5.12
Change-Id: Ibd0ad21e8d3af4760604c3ff37dc46101d5f49ad
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Fix Qt6 build in preparation of qt5 submodule update 2019-07-08T03:56:02+00:00 Alexandru Croitor alexandru.croitor@qt.io 2019-06-26T14:46:23+00:00 1c5c5f7aadc2dcc73a21eeb818e95c4e1b7de70f Fixes the QTextStream usages. Change-Id: I0c009a82fb644a9f3c3d42ec410d18b680977f23 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
Fixes the QTextStream usages.

Change-Id: I0c009a82fb644a9f3c3d42ec410d18b680977f23
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Merge remote-tracking branch 'origin/5.12' into 5.13 2019-03-13T09:10:09+00:00 Qt Forward Merge Bot qt_forward_merge_bot@qt-project.org 2019-03-13T00:01:04+00:00 76be4abbbcfb2fbb14ce532413e0895198e7f0f1 Conflicts: src/qml/compiler/qv4codegen.cpp src/qml/animations/qsequentialanimationgroupjob.cpp Change-Id: I8b76e509fd7c8599d4cef25181d790ee28edab54 
 Conflicts:
	src/qml/compiler/qv4codegen.cpp
        src/qml/animations/qsequentialanimationgroupjob.cpp

Change-Id: I8b76e509fd7c8599d4cef25181d790ee28edab54
Animation: Avoid dangling pointers 2018-12-13T17:45:58+00:00 Ulf Hermann ulf.hermann@qt.io 2018-12-12T17:34:53+00:00 9929c250a3829aec82955da91413bc7673dc159d When we clear a QSequentialAnimationGroupJob, we also need to clear its m_currentAnimation, as that always points to some animation job in its list. Change-Id: I1baae5121b00b5f65e84a7b5363704b6832ed386 Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
When we clear a QSequentialAnimationGroupJob, we also need to clear its
m_currentAnimation, as that always points to some animation job in its
list.

Change-Id: I1baae5121b00b5f65e84a7b5363704b6832ed386
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
use nullptr consistently (clang-tidy) 2018-02-26T07:13:18+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-21T09:41:54+00:00 499ec43937e926e4f2fa57a9baa455fcb3862262 From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
From now on we prefer nullptr instead of 0 to clarify cases where
we are assigning or testing a pointer rather than a numeric zero.

Also, replaced cases where 0 was passed as Qt::KeyboardModifiers
with Qt::NoModifier (clang-tidy replaced them with nullptr, which
waas wrong, so it was just as well to make the tests more readable
rather than to revert those lines).

Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>
Updated license headers 2016-01-19T14:53:18+00:00 Jani Heikkinen jani.heikkinen@theqtcompany.com 2016-01-19T09:38:36+00:00 45bd04ba73bd3e71c070e5724535ba87f6771323 From Qt 5.7 -> LGPL v2.1 isn't an option anymore, see http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/ Updated license headers to use new LGPL header instead of LGPL21 one (in those files which will be under LGPL v3) Change-Id: Ic36f1a0a1436fe6ac6eeca8c2375a79857e9cb12 Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com> 
From Qt 5.7 -> LGPL v2.1 isn't an option anymore, see
http://blog.qt.io/blog/2016/01/13/new-agreement-with-the-kde-free-qt-foundation/

Updated license headers to use new LGPL header instead of LGPL21 one
(in those files which will be under LGPL v3)

Change-Id: Ic36f1a0a1436fe6ac6eeca8c2375a79857e9cb12
Reviewed-by: Lars Knoll <lars.knoll@theqtcompany.com>
QtQml: Fix const correctness in old style casts 2015-07-09T00:12:37+00:00 Thiago Macieira thiago.macieira@intel.com 2015-03-07T22:35:47+00:00 f35be0bc5afe940bb95695a319176e45fec1f594 Found with GCC's -Wcast-qual. Change-Id: Ia0aac2f09e9245339951ffff13c958364a2e9859 Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com> 
Found with GCC's -Wcast-qual.

Change-Id: Ia0aac2f09e9245339951ffff13c958364a2e9859
Reviewed-by: Simon Hausmann <simon.hausmann@theqtcompany.com>