qt/qtdeclarative.git/src/qml/compiler/qv4codegen.cpp, branch 6.5

Merge tag 'v6.5.10-lts' into tqtc/lts-6.5-opensource

2026-08-20T12:41:16+00:00

Qt 6.5.10-lts release

Conflicts solved:
	dependencies.yaml

Change-Id: I30aa1cd656455861044ba1c3c8075f52d20dc2e8

qv4codegen: Track the correct location for assign instructions

2025-04-28T10:46:37+00:00

This fixes a qmllint warning about unqualified access in the wrong place
in the following unconventional but valid case:

Warning: .../Main.qml:5:9: Unqualified access [unqualified]
        console.log(a = 1)
        ^^^^^^^

Warning: .../Main.qml:5:21: Unqualified access [unqualified]
        console.log(a = 1)
                    ^

Change-Id: I8eaa43f520c394b094917fe37dc6115ec2f7af74
Reviewed-by: Ulf Hermann 
(cherry picked from commit 4beea6bc83f315ec57fd07ea0c21767dc63127d6)
Reviewed-by: Fabian Kosmale 
(cherry picked from commit 39e1b2bc1c5432f2498c9c56250244e612f9ce14)

Revert "Update commercial SPDX-License-Identifier"

2025-01-03T17:25:16+00:00

This reverts commit da5933f22c00270ac9083a089686e5c54e0057da.

Revert of commercial SPDX license identifiers is required for the
Qt 6.5.x opensource releases, Qt 6.5.4 onwards.

Change-Id: Ic056fb761f242af0ec4c883ecb35d50804c1c67c
Reviewed-by: Ulf Hermann

Update commercial SPDX-License-Identifier

2023-10-23T09:34:14+00:00

Updated the commercial SPDX-License-Identifier to
the files in tqtc-qtdeclarative. Examples, tests, or
documentation files were not updated.

Task-number: QTQAINFRA-5900
Change-Id: I74e2ac15b270b503edc80369b126913dd2ec33e1
Reviewed-by: Ulf Hermann

Fix CMake Unity (Jumbo) builds on Windows

2023-02-15T15:33:35+00:00

Rename some variables to prevent clashes with the "interface"
on Windows.

Task-number: QTBUG-109394
Change-Id: I54cd35c2d06b30c21cddd8650282687ec8ccf5ee
Reviewed-by: Ulf Hermann 
(cherry picked from commit e81bd76e68ea818d7ea330bf7ae8f9a5fd4476ff)
Reviewed-by: Qt Cherry-pick Bot

QML: Do not crash on CallWithSpread

2022-11-22T11:32:16+00:00

We need to check for subscripts also when creating CallWithSpread and
TailCall instructions. Furthermore, the == operator of Reference needs
to take into account whether the subscript has been loaded or not.

Amends commit 872e91612fd83de6dd1193014b5e2a0f5e8c30af.

Fixes: QTBUG-108441
Change-Id: I2d1a7a11f9cdcb4320a87df979d9ca4457620d3f
Reviewed-by: Sami Shalayel 
Reviewed-by: Semih Yavuz 
Reviewed-by: Fabian Kosmale

QML: Require TDZ checks variables declared in case blocks

2022-11-15T07:32:27+00:00

... and check the tdz only once on function calls.

Task-number: QTBUG-108362
Change-Id: I534e2604fb68b3b9145b7b7dd003e988e9df17d0
Reviewed-by: Qt CI Bot 
Reviewed-by: Fabian Kosmale

QML: Fix the most blatant TDZ violations

2022-11-14T09:19:08+00:00

When reading a let or const register before its declaration we can be
sure this is invalid.

Task-number: QTBUG-108362
Fixes: QTBUG-77428
Change-Id: I7e8f8b46079860f00c051c1a91f773dc8cdd5595
Reviewed-by: Sami Shalayel 
Reviewed-by: Fabian Kosmale

Replace CallElement with separate instructions

2022-11-07T14:49:10+00:00

We need to do the subscript lookup before generating the arguments since
the arguments may change the array.

Fixes: QTBUG-106708
Change-Id: Ia3a0dd34c6ed8d39e86ad20911a632d691826322
Reviewed-by: Qt CI Bot 
Reviewed-by: Fabian Kosmale

Port to new Q_UNREACHABLE_RETURN()

2022-10-20T21:59:33+00:00

This is a semantic patch using ClangTidyTransformator to convert
sequences of Q_UNREACHABLE() + return into Q_UNREACHABLE_RETURN(),
newly added to qtbase.

    const std::string unr = "unr", val = "val", ret = "ret";
    auto makeUnreachableReturn = cat("Q_UNREACHABLE_RETURN(",
                                    ifBound(val, cat(node(val)), cat("")),
                                    ")");
    auto ignoringSwitchCases = [](auto stmt) {
        return anyOf(stmt, switchCase(subStmt(stmt)));
    };

    makeRule(stmt(ignoringSwitchCases(stmt(isExpandedFromMacro("Q_UNREACHABLE")).bind(unr)),
                  nextStmt(returnStmt(optionally(hasReturnValue(expr().bind(val)))).bind(ret))),
             {changeTo(node(unr), cat(makeUnreachableReturn,
                                      ";")), // TODO: why is the ; lost w/o this?
              changeTo(node(ret), cat(""))},
             cat("use ", makeUnreachableReturn));

a.k.a qt-use-unreachable-return.

subStmt() and nextStmt() are non-standard matchers.

There was one false positive, suppressed it with NOLINTNEXTLINE.

It's not really a false positiive, it's just that Clang sees the world
in one way and if conditonal compilation (#if) differs for other
compilers, Clang doesn't know better. This is an artifact of matching
two consecutive statements.

Change-Id: I3855b2dc8523db1ea860f72ad9818738162495c6
Reviewed-by: Qt CI Bot 
Reviewed-by: Fabian Kosmale