qt/qtdeclarative.git/src/qml/debugger/qqmlabstractprofileradapter_p.h, branch dev Qt Declarative (Quick 2) CRA: review src/qml/debugger 2026-02-10T09:16:16+00:00 Sami Shalayel sami.shalayel@qt.io 2026-02-06T09:20:00+00:00 68a60b13ab4799246587d2df501d6665de66348d Both qqmldebugtranslationprotocol_p.h and qqmldebugserverconnection_p.h seem to do "network protocol"-related things, so mark them as critical. All other files get default significance: they do no parsing, no code execution, no cryptography and no network protocols implementation. Pick-to: 6.11 6.10 6.8 Fixes: QTBUG-143931 Change-Id: Ic85437d83eaed150f7c5f2aaa88e2ec072c12dfc Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
Both qqmldebugtranslationprotocol_p.h and qqmldebugserverconnection_p.h
seem to do "network protocol"-related things, so mark them as critical.

All other files get default significance: they do no parsing, no code
execution, no cryptography and no network protocols
implementation.

Pick-to: 6.11 6.10 6.8
Fixes: QTBUG-143931
Change-Id: Ic85437d83eaed150f7c5f2aaa88e2ec072c12dfc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Qml Profiling: Handle the case of profiling without any features 2025-11-27T10:56:14+00:00 Ulf Hermann ulf.hermann@qt.io 2025-11-25T17:07:50+00:00 1591e9d41db2f200813a7df06b5721c2f198ca34 We cannot encode the "running" state of a profiling adapter into the features it's recording. It may be started with no actual features enabled and then we still need to stop it eventually. In order for the QmlProfiler test to work without the DebugMessages feature we still need to create the DebugMessages client, but ignore its output. Otherwise the logic that checks "unrelated" clients gets confused. Change-Id: I52a3c2bc55ea36454ab9c8c7f25fe833c7f14a43 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> 
We cannot encode the "running" state of a profiling adapter into the
features it's recording. It may be started with no actual features
enabled and then we still need to stop it eventually.

In order for the QmlProfiler test to work without the DebugMessages
feature we still need to create the DebugMessages client, but ignore its
output. Otherwise the logic that checks "unrelated" clients gets
confused.

Change-Id: I52a3c2bc55ea36454ab9c8c7f25fe833c7f14a43
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
qqmldebugserverfactory: add qFatal() on QApplication leak 2025-11-17T11:50:52+00:00 Sami Shalayel sami.shalayel@qt.io 2025-10-22T14:29:55+00:00 02c5a202408f1a57970d8f21537a371652e7cf82 It seems that the QML debugger framework cleanup does not happen correctly when QApplication is leaked. Instead of running into the asserts of QQmlDebugServerImpl::removeService and ~QObject (during destruction of QQuickProfilerAdapter), warn the user with qFatal() about the possible leak of QApplication. Task-number: QTBUG-139131 Change-Id: If0497b3d4de4a1dec1bf968760d9fa79eb24683e Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
It seems that the QML debugger framework cleanup does not happen
correctly when QApplication is leaked. Instead of running into the asserts
of QQmlDebugServerImpl::removeService and ~QObject (during destruction
of QQuickProfilerAdapter), warn the user with qFatal() about the
possible leak of QApplication.

Task-number: QTBUG-139131
Change-Id: If0497b3d4de4a1dec1bf968760d9fa79eb24683e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Remove the use of Q_QML_PRIVATE_EXPORT 2024-01-11T22:03:19+00:00 Alexey Edelev alexey.edelev@qt.io 2023-11-23T07:51:37+00:00 5c5a2c24847c636857153078e4716fcb242f394d Task-number: QTBUG-117983 Change-Id: I5790f01d614cd70c7fcc9bd817ec6ace3f3e3730 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
Task-number: QTBUG-117983
Change-Id: I5790f01d614cd70c7fcc9bd817ec6ace3f3e3730
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Remove Qt key words from header files 2022-07-19T06:39:02+00:00 Yuhang Zhao 2546789017@qq.com 2022-07-15T05:48:58+00:00 0923817ddadd35e43bc09449436e282f834d566f So that users can use QT_NO_KEYWORDS when linking against QtDeclarative, even if they are using private headers. Docs, examples and tools are not touched because it's not necessary. Pick-to: 6.4 Change-Id: Idc30797074aaa72576429ebdaaf915d7f5acf84e Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
So that users can use QT_NO_KEYWORDS when linking against QtDeclarative,
even if they are using private headers.

Docs, examples and tools are not touched because it's not necessary.

Pick-to: 6.4
Change-Id: Idc30797074aaa72576429ebdaaf915d7f5acf84e
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Merge remote-tracking branch 'origin/5.11' into dev 2018-03-03T00:00:13+00:00 Qt Forward Merge Bot qt_forward_merge_bot@qt-project.org 2018-03-03T00:00:13+00:00 bf0603fd03ade413036c7dba1ffe0e7ac9364fc9 Change-Id: I308b964d86ca01916f6af7d6e3f71557e3624eca 
Change-Id: I308b964d86ca01916f6af7d6e3f71557e3624eca
use the override keyword consistently and correctly (clang-tidy) 2018-02-27T08:27:38+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-26T16:34:27+00:00 e17c89f4ce74e5699ed50dc2187a39d8990316c4 Change-Id: If9e28d143f8cba3df3c757476b4f2265e2eb8b2a Reviewed-by: Johan Helsing <johan.helsing@qt.io> 
Change-Id: If9e28d143f8cba3df3c757476b4f2265e2eb8b2a
Reviewed-by: Johan Helsing <johan.helsing@qt.io>
Merge remote-tracking branch 'origin/5.11' into dev 2018-02-27T07:43:10+00:00 Liang Qi liang.qi@qt.io 2018-02-27T07:43:10+00:00 bb7a5d0cb6e62fa411e8b66759bf6b798c3f68d9 Conflicts: src/qml/jsruntime/qv4engine.cpp src/qml/jsruntime/qv4internalclass.cpp src/qml/parser/qqmljslexer.cpp src/qml/qml/v8/qv8engine.cpp src/qml/util/qqmladaptormodel_p.h src/quick/items/qquickanimatedsprite.cpp tests/auto/quick/qquickanimatedsprite/tst_qquickanimatedsprite.cpp Change-Id: I16702b7a0da29c2a332afee47728d6a6ebf4fb3f 
 Conflicts:
	src/qml/jsruntime/qv4engine.cpp
	src/qml/jsruntime/qv4internalclass.cpp
	src/qml/parser/qqmljslexer.cpp
	src/qml/qml/v8/qv8engine.cpp
	src/qml/util/qqmladaptormodel_p.h
	src/quick/items/qquickanimatedsprite.cpp
	tests/auto/quick/qquickanimatedsprite/tst_qquickanimatedsprite.cpp

Change-Id: I16702b7a0da29c2a332afee47728d6a6ebf4fb3f
use nullptr consistently (clang-tidy) 2018-02-26T07:13:18+00:00 Shawn Rutledge shawn.rutledge@qt.io 2018-02-21T09:41:54+00:00 499ec43937e926e4f2fa57a9baa455fcb3862262 From now on we prefer nullptr instead of 0 to clarify cases where we are assigning or testing a pointer rather than a numeric zero. Also, replaced cases where 0 was passed as Qt::KeyboardModifiers with Qt::NoModifier (clang-tidy replaced them with nullptr, which waas wrong, so it was just as well to make the tests more readable rather than to revert those lines). Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d Reviewed-by: Simon Hausmann <simon.hausmann@qt.io> 
From now on we prefer nullptr instead of 0 to clarify cases where
we are assigning or testing a pointer rather than a numeric zero.

Also, replaced cases where 0 was passed as Qt::KeyboardModifiers
with Qt::NoModifier (clang-tidy replaced them with nullptr, which
waas wrong, so it was just as well to make the tests more readable
rather than to revert those lines).

Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d
Reviewed-by: Simon Hausmann <simon.hausmann@qt.io>