qt/qtdeclarative.git/src/qml/jsruntime/qv4string.cpp, branch v5.13.2

Inline StringOrSymbol::toPropertyKey()

2018-09-14T10:07:31+00:00

Save some instructions when converting a Stirng to a property
key.

Change-Id: Ide05ba8a54b504f5e606bdcdab53a2a0afeb9436
Reviewed-by: Simon Hausmann 
Reviewed-by: Erik Verbruggen

Prefix vtable methods with virtual

2018-07-03T08:08:35+00:00

Turns out that the overloading of vtable methods and regular
ones is problematic in some cases. So let's rather make it explicit
which methods are part of the vtable, and which aren't.

Change-Id: Ifee32a26104d30f3c82bca8b5a9cdea2d4f4f526
Reviewed-by: Simon Hausmann

Unify the managed and object vtables

2018-07-03T08:08:31+00:00

Allow for nullptr entries in the vtable. To nevertheless
get some decent error checking if one of the methods is
reimplemented, use a base class for Managed that contains
a full set of the vtable entries all being nullptr's.

Change-Id: Ibc53973b539f87331e8e465a6c44436a30acbefd
Reviewed-by: Simon Hausmann

Rename IdentifierTable methods

2018-07-02T19:29:47+00:00

identifier -> asPropertyKey

Change-Id: I4e6f33bdad12e901303ec6101dd2b8d6b0e99ac4
Reviewed-by: Simon Hausmann

Clean up the property key API in StringOrSymbol

2018-07-02T19:29:43+00:00

Get rid of makeIdentifier(), as toPropertyKey() will take
care of it.

Rename identifier() to propertyKey() and check that the
key is valid.

Remove String/StringOrSymbol::asArrayIndex(), we don't need it
anymore.

Change-Id: I3c490fabc1475c9ea288b49b1638b6fa1bc237b7
Reviewed-by: Simon Hausmann

Replace Identifier by PropertyKey

2018-07-02T19:29:40+00:00

Change all uses of Identifier to use the new PropertyKey class
and get rid of Identifier.

Change-Id: Ib7e83b06a3c923235e145b6e083fe980dc240452
Reviewed-by: Simon Hausmann

Cleanups in the Identifier API

2018-07-02T19:29:32+00:00

Rename from/asHeapObject to from/asStringOrSymbol and fix
the signature.
Add a isStringOrSymbol() method and redefine isValid() to also
include array indices.

Change-Id: Ic8272bfbe84d15421e2ebe86ddda7fdaa8db4f3e
Reviewed-by: Simon Hausmann

Implement a virtual interface for getOwnProperty

2018-06-25T07:36:22+00:00

This is required to support Proxy properly, and at the
same time fixes a couple of test failures.

The new interface also replaces the old query and
queryIndexed virtual interfaces, as those where doing
a subset of what getOwnProperty does.

Change-Id: I750e366b475ce971d6d9edf35fa17b7a2b07f771
Reviewed-by: Simon Hausmann

Implement Symbol.for and Symbol.keyFor

2018-05-02T14:18:41+00:00

Change-Id: I5fde731b3a1a6d7c15154881ed82549b2800d104
Reviewed-by: Simon Hausmann

Partial Symbol support

2018-05-02T14:18:36+00:00

Added basic infrastructure to create symbols and convert them
back to strings. In addition, storing and retrieving of symbol
based properties in Objects works.

Change-Id: I185f7aa46e7afa19db5a801102142892e03b7bf1
Reviewed-by: Simon Hausmann