qt/qtdeclarative.git/src/qmlcompiler/qqmljsshadowcheck.cpp, branch 6.5

Merge tag 'v6.5.10-lts' into tqtc/lts-6.5-opensource

2026-08-20T12:41:16+00:00

Qt 6.5.10-lts release

Conflicts solved:
	dependencies.yaml

Change-Id: I30aa1cd656455861044ba1c3c8075f52d20dc2e8

QmlCompiler: Discern between different kinds of side effects

2025-07-01T07:52:07+00:00

A mere jump does not cause all value types and lists to be invalidated.
Only calls to other functions or writes to other properties do that.

Fixes: QTBUG-137540
Change-Id: I069c6873455c51bbea59cf876d2bc7ecd188f81b
Reviewed-by: Olivier De Cannière 
(cherry picked from commit 6b14ba5c2fbc2810bb62a87008e338cca571acf6)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit bb98127e33046af10d7a4437239fdf03de5f2ea8)
(cherry picked from commit ca8b14febb685df22a259f46a8ff60db597da946)
Reviewed-by: Fabian Kosmale 
(cherry picked from commit 564d2eb26c6c938dcd3ab94209cd0b96abdabe80)

Revert "Update commercial SPDX-License-Identifier"

2025-06-02T06:01:16+00:00

This reverts commit 6517e8df24d2381e951b9ec3e0cda2ae33edac37.

Commercial SPDX license identifiers need to be removed from
the opensource release.

Change-Id: I60f8c76ace400db6182e012c8aae050d13d262e9
Reviewed-by: Jani Heikkinen

Update commercial SPDX-License-Identifier

2023-12-13T16:58:36+00:00

Some files in tqtc-qtdeclarative were missing the commercial
SPDX-License-Identifier. Build files, examples, tests, or
documentation are not updated.

Task-number: QTQAINFRA-5900
Change-Id: I2cad9a7a271b0b3f3af3074259614b890b266a91
Reviewed-by: Ulf Hermann 
(cherry picked from commit 132fe2df41fc5e69fec39440b35137d5f0d63f6e)
Reviewed-by: Qt Cherry-pick Bot

QmlCompiler: Extend shadow-checking

2023-11-06T14:51:36+00:00

Method return values as well as whatever we hide behind "unknown" can
contain shadowable properties. We need to check it.

Pick-to: 6.2
Task-number: QTBUG-117800
Change-Id: I518bc11fd0c9c69340bf621198eeaf4c95d17dae
Reviewed-by: Fabian Kosmale 
Reviewed-by: Olivier De Cannière 
(cherry picked from commit 048c8f226ae09b79264e5dfc51f5d8fe7a8332a9)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 590a47bc0cf557c36503df8ec493d826ae6c878d)

QmlCompiler: Fix error message on shadow checking

2023-11-06T14:51:36+00:00

The base type does not have to be the accumulator. The accumulator
doesn't even have to exist, in which case this would crash.

Pick-to: 6.2
Change-Id: I839d0a514fc1b628a829ced96dc3245e4c3eec22
Reviewed-by: Olivier De Cannière 
Reviewed-by: Fabian Kosmale 
(cherry picked from commit aa63c03b914e073df67fc35977062a3c5dcb1c60)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit 6031f2e988a6d304c1b531308b4c08e3c7552e7e)

QmlCompiler: Disallow reading from values affected by side effects

2023-05-05T11:51:51+00:00

Instead of accepting the inconsistency between interpreter and compiled
code here, we can just detect whether a value can be affected by side
effects and refrain from reading it then. Since you can always
explicitly reload a value that may have been changed, the resulting
compile warnings are easily worked around in user code. Refactoring user
code this way also makes it much clearer what is actually going on.

Task-number: QTBUG-109221
Change-Id: Ica832e39838ef732b0d181364630737fd7709b74
Reviewed-by: Fabian Kosmale 
(cherry picked from commit 4634b6bf54e5ba15aa2e8efc12feb156e3d9c309)

QmlCompiler: Fix various kinds of enum lookup

2022-12-02T12:35:42+00:00

* If we got an object type exposed as namespace, we still need to add
  the "*" to get its augmentedInternalName(). Otherwise we cannot get
  its metaobject, needed to look up enums.
* Enums cannot be shadowed. The shadow check will produce garbage if we
  try to check because an enum lookup also does not use the accumulator,
  which then contains some artifact from a previous operation.
* If we find a property lookup on a plain QMetaObject* we have to
  immediately return in order to not confuse it with attached
  properties.

Pick-to: 6.4 6.2
Fixes: QTBUG-109048
Change-Id: If9e3b4806e4d773de9cf48f1b3750b684a8c8f69
Reviewed-by: Fabian Kosmale

Port from container::count() and length() to size()

2022-10-07T21:38:48+00:00

This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8:

  auto QtContainerClass = anyOf(
      expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o),
      expr(hasType(namedDecl(hasAnyName()))).bind(o));
  makeRule(cxxMemberCallExpr(on(QtContainerClass),
                             callee(cxxMethodDecl(hasAnyName({"count", "length"),
                                                  parameterCountIs(0))))),
           changeTo(cat(access(o, cat("size"), "()"))),
           cat("use 'size()' instead of 'count()/length()'"))

a.k.a qt-port-to-std-compatible-api with config Scope: 'Container',
with the extended set of container classes recognized.

Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7
Reviewed-by: Fabian Kosmale

Use SPDX license identifiers

2022-06-11T06:05:15+00:00

Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge