qt/qtdeclarative.git/src/qmldom/qqmldomastcreator.cpp, branch wip/nativemenus

qqmldomastcreator: move widely used check into own method

2024-05-23T11:28:15+00:00

Move widely used checks into inline method to avoid code
duplication and possible typos.

Introduce stackHasScriptVariant() which checks whether the last item of
the scriptStack is indeed a variant and not a list, and
stackHasScriptList() that checks whether the last item is a list.

Change-Id: I54c75040411233fd9dcfe41816fea4e2cde975d1
Reviewed-by: Ulf Hermann 
Reviewed-by: Fabian Kosmale

semantichighlighting: highlight for-declarations

2024-05-07T11:36:09+00:00

Add declarationKindToken location in the pattern element node. This is
required for semantic highlighting to highlight the type correctly
within iteration statements.

Add type identifier region for the declaration kind token in the
for-declaration construct.

Fixes: QTBUG-124677
Task-number: QTBUG-120000
Change-Id: I02520bdc6f1b9dfc5d47078cd7e5e8d2f40bf382
Reviewed-by: Sami Shalayel

qmldom: Add more file locations

2024-05-07T11:34:50+00:00

On token is defined as colon token in the grammer file. If the flag
hasOnToken is set, then the colon token is actually on token.

Set file locations for Type *. This is needed for correctly highlighting
type names in the form of list etc.

Also add missing file locations for the if keyword, switch and for
keywords. These regions are required for semantic highlighting.

Task-number: QTBUG-120000
Change-Id: I8f6a8c0b317ff30422ccc8e1774ca3a80472a506
Reviewed-by: Fabian Kosmale 
Reviewed-by: Sami Shalayel

Add file locations for enum keyword and values

2024-04-10T22:06:19+00:00

Create file location regions for enum keyword and identifiers.
These regions are required for getting the source location of the
corresponding dom element which is needed to implement semantic tokens
highlighting feature.

Adapt comments to not attach those keywords as it breaks down the
formatter.

Task-number: QTBUG-123775
Task-number: QTBUG-120000
Change-Id: I25be2cf4f89b96ad513a9724e7a2c88e220de529
Reviewed-by: Olivier De Cannière 
Reviewed-by: Sami Shalayel

Add property type identifier locations

2024-04-10T22:06:15+00:00

It is going to be used in semantic highlighting to get source locations
 of the property types.

Task-number: QTBUG-123775
Task-number: QTBUG-120000
Change-Id: I4d9c765972d10a68a8aa3ec2761ee6088ec5e6c4
Reviewed-by: Olivier De Cannière 
Reviewed-by: Sami Shalayel

Add file locations for Pragma keyword, id and the values

2024-04-10T22:06:11+00:00

Add missing identifier token location in the grammar file. Implement the
missing file location regions for Pragma dom element. Those regions are
the way to get source location of the corresponding dom element in the
Dom API. It is needed in semantic highlighting implementation.

Adding new region breaks a few of the pragma completions tests since it
changes the closest item found and this makes the  assumption that colon
region exist wrong . Fix it by passing the Pragma element instead of the
subelements of it to insidePragmaCompletion function. This guarantees that we
find the ColonTokenRegion in the current item.

Task-number: QTBUG-123775
Task-number: QTBUG-120000
Change-Id: I2759412810ce125d6ee36bb0d70509a859667266
Reviewed-by: Sami Shalayel

Add missing file locations in Function Declarations

2024-04-10T22:06:07+00:00

Create file location regions for function and signal keywords
as well as parameter type identifier and return type identifier.
These regions are required for getting the source location of the
corresponding dom element which is needed to implement semantic tokens
highlighting feature.

Task-number: QTBUG-123775
Task-number: QTBUG-120000
Change-Id: Id37681ec240c4a52e82e75cb70e68f53b5800fcc
Reviewed-by: Olivier De Cannière 
Reviewed-by: Sami Shalayel

Add missing file locations in Import

2024-04-10T22:06:03+00:00

FileLocationRegions are useful to get source location information for a
particular dom item. In semantic highlighting, we need the source
location of the token to encode it properly. This commit adds the file
location information for Import dom elements' fields using the relavant
regions. Also introduce new region so-called VersionRegion which keeps
the source location of versioning tokens.

Task-number: QTBUG-123775
Task-number: QTBUG-120000
Change-Id: Ifca472676049eb0039dfd0170f0738f9a6764cfe
Reviewed-by: Qt CI Bot 
Reviewed-by: Sami Shalayel

dom: avoid asserts during dom construction

2024-04-05T15:45:42+00:00

Add missing safeguards to avoid crashing when constructing the Dom, also
add some tests.

Pick-to: 6.7
Fixes: QTBUG-123871
Change-Id: Ie5da7c3b7bbf61d49d755ec6c338e2011532e89b
Reviewed-by: Fabian Kosmale

dom: dot separated identifiers for all bindings

2024-04-05T15:45:42+00:00

Amends a44f21f19462cc79f82080404515c4322b7728ee that forgot to set the
bindingIdentifiers for object and array bindings (it only did script
bindings).

For some reasons, this makes
tst_qmlls_modules::documentFormatting(verbatimString.qml) crash. Fix
that crash by explicitly disabling scriptexpressions on the
(scriptexpression-)unsupported AST::TemplateLiteral.

Add a const to fieldMemberExpressionForQualifiedId()'s argument to be
able to distinguish between the "input" and "output" arguments of
setBindingIdentifiers(): identifiers is supposed to be read, and
bindingPtr is supposed to be modified.

Fixes: QTBUG-123619
Change-Id: I02e164ea22416fc13202a119896ad21cc82e5d41
Reviewed-by: Ulf Hermann