qt/qtdeclarative.git/src/qmldom, branch 6.4.2 Qt Declarative (Quick 2) Port from qAsConst() to std::as_const() 2022-11-18T22:52:04+00:00 Marc Mutz marc.mutz@qt.io 2022-11-11T15:26:04+00:00 4979e677ebc2c85e09bc67939081f70cf78484d2 We've been requiring C++17 since Qt 6.0, and our qAsConst use finally starts to bother us (QTBUG-99313), so time to port away from it now. Since qAsConst has exactly the same semantics as std::as_const (down to rvalue treatment, constexpr'ness and noexcept'ness), there's really nothing more to it than a global search-and-replace. This is a 6.4 re-run of the script we ran in dev, in order to avoid conflicts between the branches when cherry-picking. Change-Id: I5eca3df3179dfb2b2682c75a479ba9a4259cc703 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> 
We've been requiring C++17 since Qt 6.0, and our qAsConst use finally
starts to bother us (QTBUG-99313), so time to port away from it
now.

Since qAsConst has exactly the same semantics as std::as_const (down
to rvalue treatment, constexpr'ness and noexcept'ness), there's really
nothing more to it than a global search-and-replace.

This is a 6.4 re-run of the script we ran in dev, in order to avoid
conflicts between the branches when cherry-picking.

Change-Id: I5eca3df3179dfb2b2682c75a479ba9a4259cc703
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Port from container::count() and length() to size() - V5 2022-11-18T22:52:04+00:00 Marc Mutz marc.mutz@qt.io 2022-11-11T14:53:00+00:00 7a501ec6c82c8f8d5997b5d30e667d7820faed1c This is a the same semantic patch (qt-port-to-std-compatible-api V5 with config Scope: 'Container') as in dev. I've re-ran it in 6.4 to avoid cherry-pick conflicts. Change-Id: I9621dee5ed328b47e78919a34c307105e4311903 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
This is a the same semantic patch (qt-port-to-std-compatible-api V5
with config Scope: 'Container') as in dev. I've re-ran it in 6.4 to
avoid cherry-pick conflicts.

Change-Id: I9621dee5ed328b47e78919a34c307105e4311903
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
qml: fix TypeArgumentList 2022-11-02T08:51:08+00:00 Fawzi Mohamed fawzi.mohamed@qt.io 2022-10-17T12:24:35+00:00 b2ec1c8ae1b07c517ece9ad8123ee31237f8c6ca All type annotations in qml did drop any typeArgument due to a bug in TypeArgumentList: instead of keeping a circular list that is inverted while building, and finally transformed in the inverse in the finish() method, it kept a singly linked list and the finish method would return a nullptr. Fix the formatting and indenting of type annotations now that they work. Task-number: QTBUG-107171 Change-Id: I9deff83d328c5c0784a4104e406036a435278945 Reviewed-by: Semih Yavuz <semih.yavuz@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> (cherry picked from commit 0f08e3e673ece32fc9ada041115a0df631b447f3) 
All type annotations in qml did drop any typeArgument due to a bug in
TypeArgumentList: instead of keeping a circular list that is inverted
while building, and finally transformed in the inverse in the finish()
method, it kept a singly linked list and the finish method would
return a nullptr.

Fix the formatting and indenting of type annotations now that they
work.

Task-number: QTBUG-107171
Change-Id: I9deff83d328c5c0784a4104e406036a435278945
Reviewed-by: Semih Yavuz <semih.yavuz@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
(cherry picked from commit 0f08e3e673ece32fc9ada041115a0df631b447f3)
QmlDom: Add missing 'We mean it.' warning 2022-09-27T15:28:53+00:00 Moody Liu mooodyhunter@outlook.com 2022-06-16T21:53:01+00:00 3c576eda2d3f6dd83ef5001a0402e1e561b7b703 Change-Id: I6d0c736a8f7915fc21223ccbdce7fac137548435 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 30d7d9f4866c0933712cd507c2a65f39fa18c9f9) Reviewed-by: Moody Liu <mooodyhunter@outlook.com> 
Change-Id: I6d0c736a8f7915fc21223ccbdce7fac137548435
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 30d7d9f4866c0933712cd507c2a65f39fa18c9f9)
Reviewed-by: Moody Liu <mooodyhunter@outlook.com>
qmlls: fix import as resolution 2022-08-30T09:11:14+00:00 Fawzi Mohamed fawzi.mohamed@qt.io 2022-08-11T12:42:03+00:00 071255fd130abc40798eeda4b4657ee6a111261b Import as resolution (i.e. finding a type that was imported with an import as) was broken in two ways: the shortcut looking for types did look only to types imported without as, and the normal lookup for symbols declared the ImportScope as visited (to avoid loops) too early in one case and would skip it. This was visible in qmlls completions of Controls. Change-Id: Ifc1e777973ddc251bd0685290e8d28bfb025f269 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 8e6dcc04fc1073b043eba6792472c2d7cd3d5993) Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Import as resolution (i.e. finding a type that was imported with an import as)
was broken in two ways: the shortcut looking for types did look only to types
imported without as, and the normal lookup for symbols declared the ImportScope
as visited (to avoid loops) too early in one case and would skip it.
This was visible in qmlls completions of Controls.

Change-Id: Ifc1e777973ddc251bd0685290e8d28bfb025f269
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 8e6dcc04fc1073b043eba6792472c2d7cd3d5993)
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
qmlformat: Preserve variable declaration scope type 2022-08-11T11:04:24+00:00 Fabian Kosmale fabian.kosmale@qt.io 2022-08-05T08:37:24+00:00 7c5570ca8c010b2f8fecd2073dd039e665b83804 If the user used for(let x;...) we need to preserve the let and must not change it to var. Fixes: QTBUG-105361 Change-Id: I49fc3797505b569cc9b8a9138dd57ec7e70d3eb9 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 84dd339e2eb3385eb143f9d5ab282a135635052d) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
If the user used for(let x;...) we need to preserve the let and must not
change it to var.

Fixes: QTBUG-105361
Change-Id: I49fc3797505b569cc9b8a9138dd57ec7e70d3eb9
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 84dd339e2eb3385eb143f9d5ab282a135635052d)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qmldom: correctly use delete to free objects created with new 2022-07-07T18:12:30+00:00 Fawzi Mohamed fawzi.mohamed@qt.io 2022-06-10T14:18:31+00:00 e6b9b30143cd8343f5b81561758317fafae97dea Fixes: QTBUG-104084 Change-Id: I7bb3b76f68b6cf98a4bc484a31905852cf1dba09 Reviewed-by: Marc Mutz <marc.mutz@qt.io> (cherry picked from commit c017f2692cd594461b61e5043176a0f9319b91d0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Fixes: QTBUG-104084
Change-Id: I7bb3b76f68b6cf98a4bc484a31905852cf1dba09
Reviewed-by: Marc Mutz <marc.mutz@qt.io>
(cherry picked from commit c017f2692cd594461b61e5043176a0f9319b91d0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QmlDom: Protect the DomUniverse queue against concurrent access 2022-07-06T09:54:53+00:00 Ulf Hermann ulf.hermann@qt.io 2022-06-29T09:12:41+00:00 8bee7a2e7554df243195b975983a19b0d786ea1c The loadFile() can be called concurrently from different threads. Fixes: QTBUG-104625 Change-Id: Ia4457f16ab264bbba83208161feb139d3999c60b Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit d3c77e13398ba3b288152f2cd3a2934b366ad973) 
The loadFile() can be called concurrently from different threads.

Fixes: QTBUG-104625
Change-Id: Ia4457f16ab264bbba83208161feb139d3999c60b
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit d3c77e13398ba3b288152f2cd3a2934b366ad973)
Fix spelling errors in asserts 2022-06-27T10:55:13+00:00 Kai Köhne kai.koehne@qt.io 2022-06-20T16:19:41+00:00 edbd1f12cd1cc8668b29d35a733415f39f463334 Task-number: QTBUG-97092 Change-Id: Ib140fb82185488695a2a4ec7a297a48018acc599 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 4db70c1e5455a3a21dfd1e3b75ac1116778a0454) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Task-number: QTBUG-97092
Change-Id: Ib140fb82185488695a2a4ec7a297a48018acc599
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 4db70c1e5455a3a21dfd1e3b75ac1116778a0454)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Use SPDX license identifiers 2022-06-14T15:44:31+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 99f501c2fca1c8cc33b48ff694c9243b92d0742c Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 0dc4fd240a2897c5c443a0ef6d84c416843e4938) Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 0dc4fd240a2897c5c443a0ef6d84c416843e4938)
Reviewed-by: Jörg Bornemann <joerg.bornemann@qt.io>