qt/qtdeclarative.git/src/qmldom, branch 6.5.2 Qt Declarative (Quick 2) Exclude `qmldomlib` from Unity Build 2023-04-17T19:00:15+00:00 Amir Masoud Abdol amir.abdol@qt.io 2023-04-17T11:41:57+00:00 15f09a0414cc9bc7ff14931d300bc32471d0fb11 Task-number: QTBUG-109394 Change-Id: Ic6e8ff63120a207cc2b40fc55f15753e378f466f Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io> (cherry picked from commit c41f1c32289d36a6da9bd04a7cef4d7466183bc7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Task-number: QTBUG-109394
Change-Id: Ic6e8ff63120a207cc2b40fc55f15753e378f466f
Reviewed-by: Alexandru Croitor <alexandru.croitor@qt.io>
(cherry picked from commit c41f1c32289d36a6da9bd04a7cef4d7466183bc7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qmlformat: change comment handling behavior 2023-04-12T16:29:40+00:00 Semih Yavuz semih.yavuz@qt.io 2023-04-02T21:44:50+00:00 0e200eef89909a0c89621839793f816148c54884 Cumulative commit for adding zero-length comments in qmljsengine and also handling of empty lines after comments. qmljsengine only adds comments if the relavant comment length is larger than 0. Allow adding zero length comments since empty comments might be useful and required in some situations. Unlike the other formatting tools (clang-format, rustfmt) qmlformat didnt respect the emptylines after comments and stick the comments to the associated element. Change this behavior such that a newline/ blankline is added(but no more than one). A few tests in qmldom/reformatter needed to be edited due to this new behavior. Fixes: QTBUG-111231 Change-Id: I2fcdda0bfe569b7a1d19c4058e1604cb0d73291d Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> (cherry picked from commit b5274d073bf015b764c12ce4121d3be6d2378cc9) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Cumulative commit for adding zero-length comments in qmljsengine and
also handling of empty lines after comments.

qmljsengine only adds comments if the relavant comment length is larger
than 0. Allow adding zero length comments since empty comments might be
useful and required in some situations.

Unlike the  other formatting tools (clang-format, rustfmt) qmlformat
didnt respect the emptylines after comments and stick the comments to
the associated element. Change this behavior such that a newline/
blankline is added(but no more than one).

A few tests in qmldom/reformatter needed to be edited due to this new
behavior.

Fixes: QTBUG-111231
Change-Id: I2fcdda0bfe569b7a1d19c4058e1604cb0d73291d
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
(cherry picked from commit b5274d073bf015b764c12ce4121d3be6d2378cc9)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qmlformat: Fix handling of object destructuring in functions 2023-03-03T05:13:38+00:00 Fabian Kosmale fabian.kosmale@qt.io 2023-03-02T12:46:54+00:00 0ee5c6e1aa858b5df4a68dc5aa31b9a3f967f8ef We weren't considering the bindingTarget of PatternElements, which broke functions using object destructuring in the parameter list. Fixes: QTBUG-111511 Change-Id: Ie22fed2160538bf0c5733b5aced0fdac64621346 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 310428e292243770fb3bd3b48e9f136b56d68b42) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
We weren't considering the bindingTarget of PatternElements, which broke
functions using object destructuring in the parameter list.

Fixes: QTBUG-111511
Change-Id: Ie22fed2160538bf0c5733b5aced0fdac64621346
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 310428e292243770fb3bd3b48e9f136b56d68b42)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QtQml: Disambiguate static variables and methods 2023-02-09T15:52:57+00:00 Friedemann Kleint Friedemann.Kleint@qt.io 2023-02-08T08:36:00+00:00 6332eabe2a3539b42637a5106656b3e0e772cfd1 They cause clashes in CMake Unity (Jumbo) builds. Task-number: QTBUG-109394 Change-Id: I0408c01d3e6f0f4dc74904e12a3036a855cc3225 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 69708da26e72eb34c52277760f15abf0cf0974af) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
They cause clashes in CMake Unity (Jumbo) builds.

Task-number: QTBUG-109394
Change-Id: I0408c01d3e6f0f4dc74904e12a3036a855cc3225
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 69708da26e72eb34c52277760f15abf0cf0974af)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qmlformat: Add ECMAScript class reformatter 2023-01-26T19:28:52+00:00 Semih Yavuz semih.yavuz@qt.io 2023-01-25T13:11:18+00:00 121dc8d30ffded5a539903e919d951240e98fa3e qmlformat currently discards ES classes, and only reformats the element list inside that class. Implement a class declaration visitor which reformats ES classes in qml file. Fixes: QTBUG-110321 Change-Id: I9fa2561902dbcfde5e8fb041bc5dedcc56bb66cc Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit d962fe4abbf185abb1bc7464a00a93bc0e9d288b) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
qmlformat currently discards ES classes, and only reformats the element
list inside that class. Implement a class declaration visitor which
reformats ES classes in qml file.

Fixes: QTBUG-110321
Change-Id: I9fa2561902dbcfde5e8fb041bc5dedcc56bb66cc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit d962fe4abbf185abb1bc7464a00a93bc0e9d288b)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
qmlformat: fix omitting some comments while reformatting 2023-01-23T18:28:51+00:00 Semih Yavuz semih.yavuz@qt.io 2023-01-18T14:36:23+00:00 e9227b20edbd5994bc582b03662b7576117aae79 We rewrite comments associated to a node on the preVisit call (if they were marked as preComment), or postVisit( if comments were marked as postComments) of the reformatter. If the comment associated with a patternProperty kind of node, neither of these functions are called. Add missing call to previsit/postVist in the pattern property node visit. Fixes: QTBUG-109074 Change-Id: If57968b3f5dbd83aa23dc2cd2bca3608ee841d49 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 444d4f1f3f27a81996d9cbcc0642040b68728260) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
We rewrite comments associated to a node on the preVisit call
(if they were marked as preComment), or postVisit( if comments were
marked as postComments) of the reformatter. If the comment
associated with a patternProperty kind of node, neither of these
functions are called. Add missing call to previsit/postVist
in the pattern property node visit.

Fixes: QTBUG-109074
Change-Id: If57968b3f5dbd83aa23dc2cd2bca3608ee841d49
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 444d4f1f3f27a81996d9cbcc0642040b68728260)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
De-inline DomItem::subReferencesItem() 2022-12-27T19:17:38+00:00 Marc Mutz marc.mutz@qt.io 2022-12-26T21:35:45+00:00 2738638948d5ff388115db2bcea65aed6178e821 It calls fromQList<Path>(), which is compiled 55x at almost 0.5s each time round, contributing ~24s to a 'ninja qtdeclarative' build. It is the top-most non-QMetaType/non-std template instantation according to Clang -ftime-trace. Also de-inlined DomItem::subReferenceItem() before realizing that there are tons of other member functions that need to be de-inlined in that class and giving up for this round. Task-number: QTBUG-97601 Change-Id: I23489c68b0a5b5df3c8bd0e4f6c3cb3c1ba5bd4f Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com> (cherry picked from commit cf85487792d4d269527e30e65b720a68ec161246) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
It calls fromQList<Path>(), which is compiled 55x at almost 0.5s each
time round, contributing ~24s to a 'ninja qtdeclarative' build.

It is the top-most non-QMetaType/non-std template instantation
according to Clang -ftime-trace.

Also de-inlined DomItem::subReferenceItem() before realizing that
there are tons of other member functions that need to be de-inlined in
that class and giving up for this round.

Task-number: QTBUG-97601
Change-Id: I23489c68b0a5b5df3c8bd0e4f6c3cb3c1ba5bd4f
Reviewed-by: Giuseppe D'Angelo <giuseppe.dangelo@kdab.com>
(cherry picked from commit cf85487792d4d269527e30e65b720a68ec161246)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QmlCompiler: Fix recognition of builtin list types 2022-12-16T11:09:24+00:00 Ulf Hermann ulf.hermann@qt.io 2022-12-02T12:56:20+00:00 925d60291b4e970f51c0fcfc47da72e376e89a44 Previously all list types used as arguments or return types for methods had to be looked up via the imports. However, builtin types are not part of the imports at run time. Therefore, recognize list types already early on, when generating the IR. This is the same way we do it for property types and it allows us to easily identify lists of builtins. Fixes: QTBUG-109147 Change-Id: I91fa9c8fc99c1e0155cc5db5faddd928ca7fabbc Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit c4fc1167188cde9e89d44a8e5e02c5b1e04c61a7) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Previously all list types used as arguments or return types for methods
had to be looked up via the imports. However, builtin types are not part
of the imports at run time. Therefore, recognize list types already
early on, when generating the IR. This is the same way we do it for
property types and it allows us to easily identify lists of builtins.

Fixes: QTBUG-109147
Change-Id: I91fa9c8fc99c1e0155cc5db5faddd928ca7fabbc
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit c4fc1167188cde9e89d44a8e5e02c5b1e04c61a7)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Route Qt::TimeSpec usage via QTimeZone 2022-12-11T13:13:09+00:00 Edward Welbourne edward.welbourne@qt.io 2022-08-19T15:03:26+00:00 f01de8f397d855c1aa8d80e5f9c858897a9b11b1 QTimeZone now packages Qt::TimeSpec details, unifying QDateTime APIs. Task-number: QTBUG-108199 Change-Id: I4a6bfaa213ec6db2fb357d20c7cd59e8c58ad103 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
QTimeZone now packages Qt::TimeSpec details, unifying QDateTime APIs.

Task-number: QTBUG-108199
Change-Id: I4a6bfaa213ec6db2fb357d20c7cd59e8c58ad103
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Impose alphabetic order on long lists of core includes 2022-12-07T12:50:01+00:00 Edward Welbourne edward.welbourne@qt.io 2022-11-29T13:51:38+00:00 7d1579a5a2a6aaa0fb02e875288a04ba2c795e74 It was getting hard to keep track of what's there and where to add the ones I need to add. Change-Id: I849af9fae993202808b49622d3315b47aa283902 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
It was getting hard to keep track of what's there and where to add the
ones I need to add.

Change-Id: I849af9fae993202808b49622d3315b47aa283902
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>