<feed xmlns='http://www.w3.org/2005/Atom'>
<title>qt/qtdeclarative.git/src/qmlls/qqmllintsuggestions.cpp, branch wip/figmastyle</title>
<subtitle>Qt Declarative (Quick 2)
</subtitle>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/'/>
<entry>
<title>qmlls: find and use resource files from .qt/rcc</title>
<updated>2024-09-10T10:01:28+00:00</updated>
<author>
<name>Sami Shalayel</name>
<email>sami.shalayel@qt.io</email>
</author>
<published>2024-08-09T12:16:24+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=b1ff6073a7247c921e20cd98b2e3297e7368681b'/>
<id>b1ff6073a7247c921e20cd98b2e3297e7368681b</id>
<content type='text'>
Search for resource files in .qt/rcc instead of only looking in
the .rcc folder, and update the resource file mapper in
setLoadPaths to actually use the resource files.

Amends d0fcb75aab1b5a91260fb378d761257e1f2e4787 to:
 a) work on more sophisticated project structures with
    "prefer"-directives
 b) use resource files for all qmlls modules (previously only the
    linting module was using resource files)

Also move the methods to find .qrc files into qqmljsutils_p.h and add a
new test file.

This patch fixes the spurious warning about SettingsData being not found
and the missing completion suggestion for the SettingsData type in
qml/popups/AdminDialog.qml on Ekke's project attached at QTBUG-126504.
The build folder structure was mimicked in sophisticatedBuildFolder for
the test.

Also change DomEnvironment::semanticAnalysis() to return a value instead
of a reference, and rename SemanticAnalysis::setLoadPaths to
SemanticAnalysis::updateLoadPaths because it will set the loadpaths on
all copies of semanticAnalysis instead of just setting it on the current
one.

Pick-to: 6.8 6.7
Task-number: QTBUG-127661
Task-number: QTBUG-126680
Change-Id: I47299711ced6cb952c4d3c1893495cb17a8eec7f
Reviewed-by: Ulf Hermann &lt;ulf.hermann@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Search for resource files in .qt/rcc instead of only looking in
the .rcc folder, and update the resource file mapper in
setLoadPaths to actually use the resource files.

Amends d0fcb75aab1b5a91260fb378d761257e1f2e4787 to:
 a) work on more sophisticated project structures with
    "prefer"-directives
 b) use resource files for all qmlls modules (previously only the
    linting module was using resource files)

Also move the methods to find .qrc files into qqmljsutils_p.h and add a
new test file.

This patch fixes the spurious warning about SettingsData being not found
and the missing completion suggestion for the SettingsData type in
qml/popups/AdminDialog.qml on Ekke's project attached at QTBUG-126504.
The build folder structure was mimicked in sophisticatedBuildFolder for
the test.

Also change DomEnvironment::semanticAnalysis() to return a value instead
of a reference, and rename SemanticAnalysis::setLoadPaths to
SemanticAnalysis::updateLoadPaths because it will set the loadpaths on
all copies of semanticAnalysis instead of just setting it on the current
one.

Pick-to: 6.8 6.7
Task-number: QTBUG-127661
Task-number: QTBUG-126680
Change-Id: I47299711ced6cb952c4d3c1893495cb17a8eec7f
Reviewed-by: Ulf Hermann &lt;ulf.hermann@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qmlls: add warning categories to linting messages</title>
<updated>2024-08-08T09:23:52+00:00</updated>
<author>
<name>Sami Shalayel</name>
<email>sami.shalayel@qt.io</email>
</author>
<published>2024-08-02T07:14:28+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=72b70678b480fa1a494fd1632eab1cf9ab262597'/>
<id>72b70678b480fa1a494fd1632eab1cf9ab262597</id>
<content type='text'>
Make qmlls print out its linting message in the same way as qmllint, by
appending the warning category name in brackets.

Fixes: QTBUG-127687
Pick-to: 6.7 6.8
Change-Id: Ib3f001a4a0f0a591e09b158045c6a35a8d919ccf
Reviewed-by: Semih Yavuz &lt;semih.yavuz@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Make qmlls print out its linting message in the same way as qmllint, by
appending the warning category name in brackets.

Fixes: QTBUG-127687
Pick-to: 6.7 6.8
Change-Id: Ib3f001a4a0f0a591e09b158045c6a35a8d919ccf
Reviewed-by: Semih Yavuz &lt;semih.yavuz@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qmlls: mention configuration files when build folder was not found</title>
<updated>2024-08-01T15:01:37+00:00</updated>
<author>
<name>Sami Shalayel</name>
<email>sami.shalayel@qt.io</email>
</author>
<published>2024-07-31T09:48:46+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=611a472dd8ae047b03e3f3b649b81b86257f055d'/>
<id>611a472dd8ae047b03e3f3b649b81b86257f055d</id>
<content type='text'>
Extend the current warning to also mention configuration files, and
rephrase the warning into two sentences.

Pick-to: 6.8
Change-Id: Ifc75025014a05383be817c56e7da59089e9ff6cc
Reviewed-by: Semih Yavuz &lt;semih.yavuz@qt.io&gt;
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Extend the current warning to also mention configuration files, and
rephrase the warning into two sentences.

Pick-to: 6.8
Change-Id: Ifc75025014a05383be817c56e7da59089e9ff6cc
Reviewed-by: Semih Yavuz &lt;semih.yavuz@qt.io&gt;
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qmlls: follow .qmllint.ini warning configurations</title>
<updated>2024-08-01T11:23:43+00:00</updated>
<author>
<name>Sami Shalayel</name>
<email>sami.shalayel@qt.io</email>
</author>
<published>2024-07-30T14:57:54+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=8cae0aeff4e72f74046420f96a40eb6e09519ea9'/>
<id>8cae0aeff4e72f74046420f96a40eb6e09519ea9</id>
<content type='text'>
Move the methods used to set the linting category level from
qmllint/main.cpp to qqmljsloggingutils{.cpp,_p.h} so that qmlls can
reuse them to follow .qmllint.ini warning configuration files.

Also add early returns to the code of updateLogLevels.

Pick-to: 6.8 6.7
Fixes: QTBUG-127602
Change-Id: I12919226c340a2c7a16aac6cd319ca2483611530
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Move the methods used to set the linting category level from
qmllint/main.cpp to qqmljsloggingutils{.cpp,_p.h} so that qmlls can
reuse them to follow .qmllint.ini warning configuration files.

Also add early returns to the code of updateLogLevels.

Pick-to: 6.8 6.7
Fixes: QTBUG-127602
Change-Id: I12919226c340a2c7a16aac6cd319ca2483611530
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Make the lintLog category static</title>
<updated>2024-07-02T15:52:02+00:00</updated>
<author>
<name>Volker Hilsheimer</name>
<email>volker.hilsheimer@qt.io</email>
</author>
<published>2024-07-02T14:51:57+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=8cce5171c0829fff3a3c451e2aa7e527dabef585'/>
<id>8cce5171c0829fff3a3c451e2aa7e527dabef585</id>
<content type='text'>
Change-Id: I94e8156cc59808222c255c2c5a33c0a7cc2f73d2
Reviewed-by: Sami Shalayel &lt;sami.shalayel@qt.io&gt;
Reviewed-by: Wladimir Leuschner &lt;wladimir.leuschner@qt.io&gt;
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Change-Id: I94e8156cc59808222c255c2c5a33c0a7cc2f73d2
Reviewed-by: Sami Shalayel &lt;sami.shalayel@qt.io&gt;
Reviewed-by: Wladimir Leuschner &lt;wladimir.leuschner@qt.io&gt;
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>QtQml: Fix misuse of logging categories</title>
<updated>2024-06-14T11:21:06+00:00</updated>
<author>
<name>Ulf Hermann</name>
<email>ulf.hermann@qt.io</email>
</author>
<published>2024-06-05T08:18:17+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=d8d3342daeacc7e63d61916ee94e12b766f18521'/>
<id>d8d3342daeacc7e63d61916ee94e12b766f18521</id>
<content type='text'>
If we manually define the logging category function, we should really
avoid the macro for declaring it. When exporting a logging category, we
need to use the special export macro since we shouldn't rely on the
internals of the declaration macro for placing the export. The same
holds for static logging categories.

Furthermore, consistently call the functions for lcQml and lcJs.

We also need to fix the namespaces in qmlls now since the logging
categories are decidedly not in either of the used namespaces, and the
namespaces are all inside any Qt namespace.

Task-number: QTBUG-67692
Change-Id: I00fdcb80379e47dd7e928260e9c1dec91f22ad4b
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
If we manually define the logging category function, we should really
avoid the macro for declaring it. When exporting a logging category, we
need to use the special export macro since we shouldn't rely on the
internals of the declaration macro for placing the export. The same
holds for static logging categories.

Furthermore, consistently call the functions for lcQml and lcJs.

We also need to fix the namespaces in qmlls now since the logging
categories are decidedly not in either of the used namespaces, and the
namespaces are all inside any Qt namespace.

Task-number: QTBUG-67692
Change-Id: I00fdcb80379e47dd7e928260e9c1dec91f22ad4b
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qmlls: adapt the qtlanguageserver changes in WorkspaceEdit</title>
<updated>2024-04-29T07:21:21+00:00</updated>
<author>
<name>Sami Shalayel</name>
<email>sami.shalayel@qt.io</email>
</author>
<published>2024-04-05T09:04:22+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=1635ca51f018bbb8d1ea5069a7f2ed8503be8cb9'/>
<id>1635ca51f018bbb8d1ea5069a7f2ed8503be8cb9</id>
<content type='text'>
Adapt to the changes in WorkspaceEdit that makes the handling of the
documentChanges variant easier in the tests.

Task-number: QTBUG-114993
Change-Id: Ic092d8faccbe3fb32e81e8b08d5ecef22bad908a
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adapt to the changes in WorkspaceEdit that makes the handling of the
documentChanges variant easier in the tests.

Task-number: QTBUG-114993
Change-Id: Ic092d8faccbe3fb32e81e8b08d5ecef22bad908a
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qmlls: add -I and -E option</title>
<updated>2024-04-18T09:39:16+00:00</updated>
<author>
<name>Sami Shalayel</name>
<email>sami.shalayel@qt.io</email>
</author>
<published>2024-04-10T12:30:32+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=1bef3c4d0db67bd9dcfc7289b6322649af980c22'/>
<id>1bef3c4d0db67bd9dcfc7289b6322649af980c22</id>
<content type='text'>
Add a -I option that specifies additional import paths used to find QML
modules.
Add a -E option that searches QML modules in the import paths specified
by the environment variables QML_IMPORT_PATH.

Add an import path field to QQmlCodeModel with setters and getters
that may now consist of more than just
`QLibraryInfo::path(QLibraryInfo::QmlImportsPath)`.

Extract some common code used to read, check and inform about directories
used from environment variables or command line options into static
methods. This would allow other tooling, like qmllint, to print the same
warnings when using environment variables, for example.

Add a new test tst_qmlls_cli that allows to test qmlls behavior
when fed with different combinations of -I, -E and -b (for build
directories) options. The test also enables checking that warnings are
correctly emitted and that import paths are correctly used during
linting via qmlls.

Note that the warnings emitted by qmlls when using -b were
enhanced, partially due to the refactoring of the static helpers to read
directory names from environment and command line options. Also note
that qmlls was informing twice about possibly using .qmlls.ini files
before this commit, so also remove the redundant warning.

Task-number: QTBUG-114969
Change-Id: I102ca8b50299f277746c5bba6832551a76898fc0
Reviewed-by: Ulf Hermann &lt;ulf.hermann@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Add a -I option that specifies additional import paths used to find QML
modules.
Add a -E option that searches QML modules in the import paths specified
by the environment variables QML_IMPORT_PATH.

Add an import path field to QQmlCodeModel with setters and getters
that may now consist of more than just
`QLibraryInfo::path(QLibraryInfo::QmlImportsPath)`.

Extract some common code used to read, check and inform about directories
used from environment variables or command line options into static
methods. This would allow other tooling, like qmllint, to print the same
warnings when using environment variables, for example.

Add a new test tst_qmlls_cli that allows to test qmlls behavior
when fed with different combinations of -I, -E and -b (for build
directories) options. The test also enables checking that warnings are
correctly emitted and that import paths are correctly used during
linting via qmlls.

Note that the warnings emitted by qmlls when using -b were
enhanced, partially due to the refactoring of the static helpers to read
directory names from environment and command line options. Also note
that qmlls was informing twice about possibly using .qmlls.ini files
before this commit, so also remove the redundant warning.

Task-number: QTBUG-114969
Change-Id: I102ca8b50299f277746c5bba6832551a76898fc0
Reviewed-by: Ulf Hermann &lt;ulf.hermann@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>qmllint: Explicitly include qxpfuncional.h where we use it</title>
<updated>2024-02-23T19:44:43+00:00</updated>
<author>
<name>Ulf Hermann</name>
<email>ulf.hermann@qt.io</email>
</author>
<published>2024-02-23T10:25:50+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=db5eefc33cec9197e46a8affbca540f45125f8c3'/>
<id>db5eefc33cec9197e46a8affbca540f45125f8c3</id>
<content type='text'>
Task-number: QTBUG-122653
Change-Id: I102e00543d4579206f11e86cd987f53dab5988c7
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Task-number: QTBUG-122653
Change-Id: I102e00543d4579206f11e86cd987f53dab5988c7
Reviewed-by: Fabian Kosmale &lt;fabian.kosmale@qt.io&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>QmlDom: Don't pass ErrorMessage by value</title>
<updated>2023-09-15T13:32:40+00:00</updated>
<author>
<name>Ulf Hermann</name>
<email>ulf.hermann@qt.io</email>
</author>
<published>2023-09-14T10:30:33+00:00</published>
<link rel='alternate' type='text/html' href='https://code.qt.io/cgit/qt/qtdeclarative.git/commit/?id=27dcc63e00a764b1abe49a4fdf7ee452f2f609f9'/>
<id>27dcc63e00a764b1abe49a4fdf7ee452f2f609f9</id>
<content type='text'>
When iterating, pass it by const ref. When "adding" pass it by rvalue
ref. In the few places where that clashes, copy it explicitly.

Coverity-Id: 417092
Change-Id: I93b2d671c38a2f44334929fd7ec9c2f1a18caac8
Reviewed-by: Sami Shalayel &lt;sami.shalayel@qt.io&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
When iterating, pass it by const ref. When "adding" pass it by rvalue
ref. In the few places where that clashes, copy it explicitly.

Coverity-Id: 417092
Change-Id: I93b2d671c38a2f44334929fd7ec9c2f1a18caac8
Reviewed-by: Sami Shalayel &lt;sami.shalayel@qt.io&gt;
</pre>
</div>
</content>
</entry>
</feed>
