qt/qtdeclarative.git/src/quick/items/qquickanimatedsprite.cpp, branch 6.8.2 Qt Declarative (Quick 2) doc: Fix string, real, point and size QML property documentation 2024-12-05T15:13:55+00:00 David Boddie david.boddie@qt.io 2024-12-04T15:15:30+00:00 ef0462d938dc8bfdc3ef298684318ac622eea8c9 Change-Id: I2de731368e403696ecf9d74a0ac68d1982d5ce24 Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io> (cherry picked from commit 2d9c5c46d34b90510f3af31f2dd01ae15226c6e0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Change-Id: I2de731368e403696ecf9d74a0ac68d1982d5ce24
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
(cherry picked from commit 2d9c5c46d34b90510f3af31f2dd01ae15226c6e0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Doc: Replace \instantiates with \nativetype 2024-08-28T09:31:23+00:00 Paul Wicking paul.wicking@qt.io 2024-08-20T07:36:38+00:00 50032ea50b7a910071db616b922b3387ee50af2b Since the implementation of the `\nativetype`-command in QDoc, the `\instantiates`-command is deprecated. Replace the use of the deprecated command in favor of its replacement. Task-number: QTBUG-128216 Change-Id: I23d9f66d3f6db2e5f827d7868497a432bb9b0626 Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io> (cherry picked from commit a464ff5bfa15201de64d05121dc192dbd4655890) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Since the implementation of the `\nativetype`-command in QDoc,
the `\instantiates`-command is deprecated. Replace the use of the
deprecated command in favor of its replacement.

Task-number: QTBUG-128216
Change-Id: I23d9f66d3f6db2e5f827d7868497a432bb9b0626
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
(cherry picked from commit a464ff5bfa15201de64d05121dc192dbd4655890)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Fix glitches in big AnimatedSprite animations 2021-12-09T22:16:37+00:00 Eirik Aavitsland eirik.aavitsland@qt.io 2021-12-03T17:11:38+00:00 55d3b35c59b173ac6d559b1b74c405af1aa793ff AnimatedSprite creates an atlas texture where the frames are placed next to each other in a row - or multiple rows, if the frames are many and/or big enough. When interpolation is enabled, the code must calculate not only the coordinates for the current (A) frame, but also for the next one. However, the code for caluclating next (B) frame was broken. It seemed to be half way designed to operate on normalized (qreal 0.0-1.0) coordinates, while the function in reality operates on physical, integer texture coordinates. The result was that every time the B frame should be in a different row than the A frame, the B coordinates came out wrong. Hence, at that point the rendering would interpolate the A frame towards a wrong or invalid frame, causing visual glitches. Fix the computations to use the actual texture (sheet) size instead of normalized coordinates, and integers instead of qreals. Fixes: QTBUG-94765 Pick-to: 6.2 5.15 Change-Id: I5a484c196abc3189f6dce0921cad3a25ada0e584 Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> 
AnimatedSprite creates an atlas texture where the frames are placed
next to each other in a row - or multiple rows, if the frames are many
and/or big enough.

When interpolation is enabled, the code must calculate not only the
coordinates for the current (A) frame, but also for the next
one. However, the code for caluclating next (B) frame was broken. It
seemed to be half way designed to operate on normalized (qreal
0.0-1.0) coordinates, while the function in reality operates on
physical, integer texture coordinates. The result was that every time
the B frame should be in a different row than the A frame, the B
coordinates came out wrong. Hence, at that point the rendering would
interpolate the A frame towards a wrong or invalid frame, causing
visual glitches.

Fix the computations to use the actual texture (sheet) size instead of
normalized coordinates, and integers instead of qreals.

Fixes: QTBUG-94765
Pick-to: 6.2 5.15
Change-Id: I5a484c196abc3189f6dce0921cad3a25ada0e584
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Port from devicePixelRatioF() to devicePixelRatio() 2020-09-28T11:01:43+00:00 Morten Johan Sørvig morten.sorvig@qt.io 2020-08-06T19:40:01+00:00 9e2f4e112776149be550dbea6003a192cd931538 This ports all of QtDeclarative. Change-Id: Ie6eb4d96b4d49fbed1e8be514d03e331549cd712 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> 
This ports all of QtDeclarative.

Change-Id: Ie6eb4d96b4d49fbed1e8be514d03e331549cd712
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
Resume AnimatedSprite playback when visibility changes 2020-04-24T08:24:58+00:00 Laszlo Agocs laszlo.agocs@qt.io 2020-04-23T15:05:26+00:00 af521a8df6caec41f626a4b3319601c20adff711 Amends f5e2783 that was made in 5.6 to avoid updating the AnimatedSprite when not visible. The problem is, if the sprite was running, the expectation is that becoming visible again resumes the playback. It can be argued what the correct behavior is: do we expect the playback to resume from the point when the sprite went invisible, or should it take the time spent as invisible into account? This patch only corrects the immediate problem and provides the former, i.e. playback will resume from the point it had when becoming invisible. The AnimatedSprite scene in the imageelements example is improved to be able to test this. It can also exercise all the start/pause/resume/advance functions now. Fixes: QTBUG-63942 Pick-to: 5.15 Change-Id: Ieb6d046168a2132659848a36ee0b694c580159b1 Reviewed-by: Andy Nichols <andy.nichols@qt.io> 
Amends f5e2783 that was made in 5.6 to avoid updating the AnimatedSprite
when not visible. The problem is, if the sprite was running, the
expectation is that becoming visible again resumes the playback.

It can be argued what the correct behavior is: do we expect the playback
to resume from the point when the sprite went invisible, or should it
take the time spent as invisible into account? This patch only corrects
the immediate problem and provides the former, i.e. playback will resume
from the point it had when becoming invisible.

The AnimatedSprite scene in the imageelements example is improved to be
able to test this. It can also exercise all the start/pause/resume/advance
functions now.

Fixes: QTBUG-63942
Pick-to: 5.15
Change-Id: Ieb6d046168a2132659848a36ee0b694c580159b1
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Replace QFlagPointer with QTaggedPointer 2020-04-03T10:35:23+00:00 Simon Hausmann simon.hausmann@qt.io 2020-03-04T13:54:54+00:00 448b2a5d838d082c66ab649cc7b71c31761bf409 The latter has the advantage of allowing the use of a real type for the tag, instead of the generic flag/flag2 boolean accessors. Change-Id: Icc9e854ce4af3eb5808a4bed45aa22f377e223da Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
The latter has the advantage of allowing the use of a real type for the
tag, instead of the generic flag/flag2 boolean accessors.

Change-Id: Icc9e854ce4af3eb5808a4bed45aa22f377e223da
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Allow AnimatedSprite to finish on the last frame 2019-11-13T18:03:53+00:00 Michael Brasser mbrasser@ford.com 2019-10-29T14:45:54+00:00 2c6966c775fec86e3c4265cd3a5b204e7e5e183a [ChangeLog][AnimatedSprite] Add finishBehavior to allow a sprite to finish on the last frame. Task-number: QTBUG-59090 Change-Id: Id45e879cdc4905f43e2ac3cb2529181390d47aab Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
[ChangeLog][AnimatedSprite] Add finishBehavior to allow a sprite to
finish on the last frame.

Task-number: QTBUG-59090
Change-Id: Id45e879cdc4905f43e2ac3cb2529181390d47aab
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Cleanup and document AnimatedSprite::start()/stop() 2019-11-01T15:26:42+00:00 Michael Brasser mbrasser@ford.com 2019-10-30T19:13:57+00:00 bd62eff7ca551dc76cf1ec2e7eef14664f6228a5 Change-Id: I3acbff54ca7b2131b84ab739f99ac982ebda65ea Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
Change-Id: I3acbff54ca7b2131b84ab739f99ac982ebda65ea
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Small performance improvements suggested by clang-tidy 2019-10-07T07:09:49+00:00 Albert Astals Cid albert.astals.cid@kdab.com 2019-10-04T12:13:36+00:00 ce94b847c87e2606c5f189d2ad3715c1d025b9cf mostly add const &, a few std::move and in particular case, remove const so the std::move being done over the variable actually has effect Change-Id: Id611cd31bc012f219d7a17d4626b1c2a5fbddd66 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
mostly add const &, a few std::move and in particular case, remove const
so the std::move being done over the variable actually has effect

Change-Id: Id611cd31bc012f219d7a17d4626b1c2a5fbddd66
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>