qt/qtdeclarative.git/src/quick/items/qquickpositioners_p_p.h, branch dev

Set explicit default security level of all files with default security

2025-09-17T13:31:14+00:00

The files (folders) already processed are listed in each issue in epic
QTBUG-134547

These files were processed half a year ago. In order to make it clear
that all of these files are already processed, mark them with an
explicit default security header.

For the record, this was generated with this script:

find -E . -regex ".*\.(cpp|h|hpp|mm|qml|js)$" | xargs python3 ~/bin/add-cra-header.py

in the folders listed in each subtask of QTBUG-134547

(add-cra-header.py only exist at my desktop, but it simply adds the
default security header if it doesn't already have any existing security
header)

QUIP: 23
Fixes: QTBUG-134547
Pick-to: 6.10 6.9 6.8
Change-Id: Ieb8c78ea6561fdbdd27c7b13185ece853eedf80f
Reviewed-by: Oliver Eftevaag

QQuickPositioner: re-engineer PositionedItem

2025-01-23T19:54:03+00:00

The class violated the rule of 5, had insufficient encapsulation, and
triggered undefined behavior.

It was designed to be stored in a QPODVector, but when using
transitions, it owns a pointer (transitionableItem). However the class
didn't disengage copies (!), and was actively being copied around in
code (thankfully, holding a null pointer, otherwise this would
double-delete).

Since QPODVector doesn't run destructors when deleting elements
("POD", but PositionedItem isn't POD, and thus not running the
destructor is language UB), another couple of methods were needed when
removing elements from the vector, to make sure to delete the pointer.

Make PositionedItem hold a unique_ptr instead, for clear ownership
semantics. Since QPODVector won't work any more, store it in a
std::vector. There is no longer need of external code to manage
ownership, so remove it.

The rest of the changes are mostly mechanical: turn index-based
iterations into range-based for loops, and calls to index-based
QPODVector::find to iterator-based std::find. To ease the search,
add an overload of operator== that takes a QQuickItem (with similar
semantics to the existing operator==).

Change-Id: I5eed1a9aada4db2417a586f2113c6892c058fbb0
Reviewed-by: Shawn Rutledge

Alert when we are notifying semi-dead change listeners

2024-12-01T17:41:22+00:00

Add virtual methods "baseDeleted" and "debugName" to
QQuickItemChangeListener that let us report whether the object that
implements QQuickItemChangeListener is already being destroyed. Add a
"safe" version of QQuickItemChangeListener that overrides that virtual
method using CRTP: if the derived class that it is instantiated with has
a member "inDestructor" (e.g. a QQuickItemPrivate) or "wasDeleted" (e.g.
a QObjectPrivate), then return the value of that variable. If the
derived type is a QObject or QQuickItem, access the member via
QQmlData::wasDeleted.

Ignore calls on listeners that are the same object as the caller.

Use that new type in those classes where it isn't immediately obvious
that they clean up after themselves: classes that don't implement a
destructor are a red flag.

In addition, add a list to safe listener version to add/remove each
item it's listening on.

Issue runtime warnings in developer-builds when listeners are called
for which baseDestroyed() returns true, and when listeners are
destroyed while they still have items on their list.

Task-number: QTBUG-98790
Change-Id: I15ed66a36556caa0e6acf5b768dec2ae92b01d64
Reviewed-by: Fabian Kosmale 
Reviewed-by: Mitch Curtis

Fix build with -no-feature-quick-viewtransitions

2023-03-07T09:24:50+00:00

Pick-to: 6.5
Change-Id: I609a843bddbd0776452d289b144dab803503a483
Reviewed-by: Volker Hilsheimer

Use SPDX license identifiers

2022-06-11T06:05:15+00:00

Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge

Replace Q_DECL_OVERRIDE with override

2017-09-25T08:27:35+00:00

Change-Id: I176f91a8c51e81a2df3fe91733118261491223ee
Reviewed-by: Lars Knoll

Revert "Positioners: allow distinguishing between implicit/explicit child size"

2017-04-05T09:25:22+00:00

This reverts commit 2556bfdab42dc0aefb34bb7cf304063c7db0ff00.

This is no longer necessary, as there are now no users of this
functionality in other modules.

Change-Id: If92bbdb3e5e95b4103610d68d22e929cf30c4e5e
Reviewed-by: J-P Nurmi 
Reviewed-by: Robin Burchell

Positioners: allow distinguishing between implicit/explicit child size

2017-02-23T13:45:52+00:00

In Qt Quick Controls 2, we plan on using positioners to layout an icon
next to text in a button, for example.

Consider the following example:

    AbstractButton {
       id: button
       text: "Button"
       contentItem: Row {
           Text {
               text: button.text
               width: parent.width
           }
       }
       background: Rectangle {
           radius: 5
           color: "lightsteelblue"
           opacity: button.pressed ? 1.0 : 0.8
       }
    }

In Qt Quick Controls 2, implicit size propagates "up" from the
delegates/building blocks to the control, whereas explicit size
propagates "down" from the control to the delegates/building blocks.
Providing a reasonable implicit size is important to make controls
behave well in layouts, etc., and the internal building blocks must
follow the size of the control to retain sensible looks when a control
is resized.

In the example above, contentItem needs to have a "natural" (implicit)
size representing the ideal fit of the content, but it needs to respect
the explicitly provided size from the control too.

With the current behavior, as the explicit width of the Row is 0, the
Text item (via the width binding) sets explicit width to 0, and Row
uses that explicit width rather than the implicit width, thus, Row here
will have an implicit width of 0, which is not what the control wants.

This patch:

- Allows subclasses of positioners to set
  QQuickBasePositionerPrivate::useImplicitSize to true in order to tell
  positioners to use implicit size rather than explicit size. This is
  not exposed as public API, as this behavior is typically not
  something desirable in the positioners themselves. For example,
  Row { Rectangle { width: 100; height: 100 } } would have an implicit
  size of 0, as Rectangle has no implicit size.
- Adds QQuickImplicitRow and QQuickImplicitGrid, which are private
  subclasses of their respective positioners that simply set
  useImplicitSize to true in their constructors.
- Exports the wrappers privately so that they can be registered by
  other modules as QML types.

Change-Id: Ie68aabd7fbf6c76375badf6e338f2f238f3fc392
Reviewed-by: J-P Nurmi 
Reviewed-by: Robin Burchell

Positioners: remove unused header includes

2017-02-23T13:45:30+00:00

Change-Id: I1d2a57d5a5392986460e2427b4ee2a1b2b17dbaa
Reviewed-by: J-P Nurmi 
Reviewed-by: Robin Burchell

Make itemviews and positioners configurable

2016-10-10T14:12:11+00:00

Change-Id: Ia26cbbdb2b2a0ed74398bfad7689db7289ad8c6a
Reviewed-by: Oswald Buddenhagen 
Reviewed-by: Simon Hausmann