qt/qtdeclarative.git/src/quick/items/qquicktextedit.cpp, branch wip/scenegraphng

Merge remote-tracking branch 'origin/5.12' into 5.13

2019-05-15T23:00:46+00:00

Change-Id: Ia93dc734ce25b3134b0f905f473a0c30777ceaf1

TextEdit: use I-beam cursor by default, pointing cursor for links

2019-05-15T11:25:45+00:00

But do not interfere with any custom cursor that user code sets:
remember and restore it when the mouse is no longer hovering a link.

Task-number: QTBUG-14769
Fixes: QTBUG-50482
Change-Id: Ia4633c22d0ad42d07203d4dc3e330b90a5f94a7c
Reviewed-by: Mitch Curtis

TextEdit: Fix persistentSelection for readonly controls

2019-02-15T14:03:07+00:00

TextEdit items with readOnly:true do not clear the selection on losing
focus which is expected with persistentSelection:false.

The reason is that a readonly TextEdit does never show a blinking cursor
and thus the selection clearing within setCursorVisible never happens.

This change adapts the implementation from TextInput.

Fixes: QTBUG-50587
Change-Id: Ie66baaa0ccbc006359473862d8e9dbecd46a59f6
Reviewed-by: Shawn Rutledge 
Reviewed-by: Mitch Curtis

Fix Keys.onShortcutOverride for TextEdit

2018-12-13T17:53:19+00:00

It was not possible to override a shortcut with Keys.onShortcutOverride
for TextEdit. This was because the ShortcutOverride event sent to the
TextEdit was not passed on to the default event() implementation (of the
base class) in the case that the QQuickTextEdit did not handle the
ShortcutOverride event.

Fixes: QTBUG-68711
Change-Id: I981738d8f92c77eadb8dd98b4245290d430525d3
Reviewed-by: Jan Arve Sæther 
Reviewed-by: Liang Qi 
Reviewed-by: Frederik Gladhorn

Fix vertical alignment of images in a text document

2018-11-22T08:26:01+00:00

The vertical alignment was not calculated correctly in all cases,
this should fix it by retrieving the height and baseline for the
current text line and doing the calculation correctly in all cases.

Change-Id: I5bb650ede46dc03d51bf0f64b77dc4ca77d30fd2
Fixes: QTBUG-59310
Reviewed-by: Eskil Abrahamsen Blomfeldt 
Reviewed-by: Igor Bugaev

Fix updating of text nodes in QQuickTextEdit

2018-11-22T08:25:43+00:00

The update algorithm wasn't working correctly if there were
two disconnected dirty regions in the textNodeMap. This could
happend by e.g. programatically removing text at the beginning
and appending at the end.

Change-Id: I3de2c8efedb03c004c4c304d130360cbdb4485b7
Fixes: QTBUG-68863
Reviewed-by: Eskil Abrahamsen Blomfeldt

Doc: Add missing dots (qtdeclarative)

2018-06-19T12:44:48+00:00

Task-number: QTBUG-68933
Change-Id: Ibb5aa227e82825085e7214e17dcffcb17fd44157
Reviewed-by: Topi Reiniö

use nullptr consistently (clang-tidy)

2018-02-26T07:13:18+00:00

From now on we prefer nullptr instead of 0 to clarify cases where
we are assigning or testing a pointer rather than a numeric zero.

Also, replaced cases where 0 was passed as Qt::KeyboardModifiers
with Qt::NoModifier (clang-tidy replaced them with nullptr, which
waas wrong, so it was just as well to make the tests more readable
rather than to revert those lines).

Change-Id: I4735d35e4d9f42db5216862ce091429eadc6e65d
Reviewed-by: Simon Hausmann

Fix misleading doc for kerning

2018-02-08T11:44:02+00:00

It currently sounds as if activating kerning would speed up drawing
while the opposite is true.

Change-Id: I7ba8caa82931617213c70570b6b81f82d5b61e52
Reviewed-by: Simon Hausmann 
Reviewed-by: Leena Miettinen 
Reviewed-by: Eskil Abrahamsen Blomfeldt

QQuickTextEdit: Simplify node handling

2018-02-02T08:49:45+00:00

We don't need to manually manage pointers to nodes as QList can do
that for us.

Change-Id: I0185db2d5909178b3e36c8d1b7921bdbb1858ca6
Reviewed-by: Anton Kudryavtsev 
Reviewed-by: Shawn Rutledge