qt/qtdeclarative.git/src/quick/items, branch 6.8.2 Qt Declarative (Quick 2) doc: Fix font, url and point QML property documentation 2025-01-10T09:08:08+00:00 David Boddie david.boddie@qt.io 2024-12-04T15:40:50+00:00 ae4d8a931dc6322df0019e78ee04f6342c481219 Change-Id: I9d2124ad8b56d94208d23fda19adeb37e6362213 Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io> (cherry picked from commit 1545bba700377244ac5aa756680da62e5664499a) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 53d134d584957b6caac75b1e899f5304b7ec943a) 
Change-Id: I9d2124ad8b56d94208d23fda19adeb37e6362213
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
(cherry picked from commit 1545bba700377244ac5aa756680da62e5664499a)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 53d134d584957b6caac75b1e899f5304b7ec943a)
SelectionRectangle: Deactivate when the last cell is unselected 2025-01-10T05:34:56+00:00 MohammadHossein Qanbari mohammad.qanbari@qt.io 2024-12-18T13:40:52+00:00 3dc191a4084af482bfceddd8f32a1f1bd9848a18 This commit introduces changes to ensure that the SelectionRectangle is properly deactivated when the last selected cell in QQuickTableView is unselected. Key changes include: - Added a virtual method `hasSelection()` to QQuickSelectable interface - Implemented `hasSelection()` for QQuickTableViewPrivate, which checks if any items are selected - Updated QQuickSelectionRectangle to utilize the new `hasSelection()` method to determine its active state The test case checks that after deselecting the last selected cell, both the SelectionRectangle and its handles are properly deactivated. Change-Id: I97214bb0d91dda8a902a4725918b60209b853acf Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit 398af1e359d180360fdd0a87f1681111c12eaefb) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 37417486355435eebfae0f8d85e3a115dba9dd42) 
This commit introduces changes to ensure that the SelectionRectangle is
properly deactivated when the last selected cell in QQuickTableView is
unselected.

Key changes include:
- Added a virtual method `hasSelection()` to QQuickSelectable interface
- Implemented `hasSelection()` for QQuickTableViewPrivate, which checks
if any items are selected
- Updated QQuickSelectionRectangle to utilize the new `hasSelection()`
method to determine its active state

The test case checks that after deselecting the last selected cell, both
the SelectionRectangle and its handles are properly deactivated.

Change-Id: I97214bb0d91dda8a902a4725918b60209b853acf
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit 398af1e359d180360fdd0a87f1681111c12eaefb)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 37417486355435eebfae0f8d85e3a115dba9dd42)
Text: calculate implicitWidth even when width hasn't been set 2025-01-07T19:52:46+00:00 Morteza Jamshidi morteza.jamshidi@qt.io 2024-12-30T14:46:31+00:00 b4b4fc74c6cf39e658d81f7ed8c29e4d8b6d37b8 The item's width may be controlled by a layout, which needs implicitWidth to decide what the actual width should be. Alternatively, if Text width has not been set, it should be the same as implicitWidth, rather than being as narrow as possible and word-wrapping excessively. Fixes: QTBUG-129143 Change-Id: Iabc619e07b16a903104ab9724e48104adbca4829 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> Reviewed-by: Lars Schmertmann <lars.schmertmann@governikus.de> (cherry picked from commit 52b5aaaabbbdef3da9fd9ffc2cf3fb947196ab24) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 1826242257fa8021a11dadd6cda653bad5e9e170) 
The item's width may be controlled by a layout, which needs
implicitWidth to decide what the actual width should be.
Alternatively, if Text width has not been set, it should be the same as
implicitWidth, rather than being as narrow as possible and word-wrapping
excessively.

Fixes: QTBUG-129143
Change-Id: Iabc619e07b16a903104ab9724e48104adbca4829
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Reviewed-by: Lars Schmertmann <lars.schmertmann@governikus.de>
(cherry picked from commit 52b5aaaabbbdef3da9fd9ffc2cf3fb947196ab24)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 1826242257fa8021a11dadd6cda653bad5e9e170)
TableView: fix -no-feature-quick-draganddrop build 2025-01-07T18:33:49+00:00 Shawn Rutledge shawn.rutledge@qt.io 2024-12-24T11:08:07+00:00 ab9920db073d3b57348952cf30473ff3d6b766db Now it builds if Qt is configured without DnD. Fixes: QTBUG-132355 Change-Id: I76c7660e32c19dcb96a72a116eb6475ffb56183b Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit f48d6b4159bc391d77588d92d1bb06b468231241) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit d3ab7bc162566a74efa1d44adf8922d94bf6dbb5) 
Now it builds if Qt is configured without DnD.

Fixes: QTBUG-132355
Change-Id: I76c7660e32c19dcb96a72a116eb6475ffb56183b
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit f48d6b4159bc391d77588d92d1bb06b468231241)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit d3ab7bc162566a74efa1d44adf8922d94bf6dbb5)
Sync QQuickWindowQmlImpl::visible with QWindow 2025-01-06T17:01:56+00:00 Shantanu Tushar shantanu.tushar@kdab.com 2024-09-25T08:09:21+00:00 ec474962106ea95197e02ee68983603750eeb60c QQuickWindowQmlImpl introduces its own `visible' Q_PROPERTY so that it can do its own things (such as applyWindowVisibility()). However, things get out of sync if the user of the window uses show() instead of setting visible=true. An example of such a case is included as a new unit test for QQuickWindow. Change-Id: I0b5b2635919f61a50999fc3ba15a87de8f7074e9 Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io> (cherry picked from commit 8182cc1042fc6e46c771e008cf19ee3fcb6328ae) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 27bc4d0978033261362acf419678e25d7dad535d) Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
QQuickWindowQmlImpl introduces its own `visible' Q_PROPERTY so that it
can do its own things (such as applyWindowVisibility()). However, things
get out of sync if the user of the window uses show() instead of setting
visible=true.

An example of such a case is included as a new unit test for
QQuickWindow.

Change-Id: I0b5b2635919f61a50999fc3ba15a87de8f7074e9
Reviewed-by: Tor Arne Vestbø <tor.arne.vestbo@qt.io>
(cherry picked from commit 8182cc1042fc6e46c771e008cf19ee3fcb6328ae)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 27bc4d0978033261362acf419678e25d7dad535d)
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
QQuickListViewPrivate::fixup: fix potential use-after-free 2024-12-15T13:27:07+00:00 Vladimir Belyavsky belyavskyv@gmail.com 2024-11-14T16:05:18+00:00 be4b07a9e61031725a428e403410a8f508bbf434 When using the StrictlyEnforceRange highlight range mode, call updateHighlight() _before_ calling snapItemAt(), because if we do that later, the item returned by snapItemAt() might be destroyed as soon as updateHighlight() calls applyPendingChanges() internally. Fixes: QTBUG-129231 Pick-to: 6.5 Change-Id: I5d1dbac4730238302187d16476dd0c4aea614e13 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> (cherry picked from commit 0273207f7ad3a2909e7d0b5a59caea3606035cc6) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit eb4e404aa810b4593a766bcf61decc52fb82d138) 
When using the StrictlyEnforceRange highlight range mode, call updateHighlight() _before_ calling snapItemAt(), because if we do that
later, the item returned by snapItemAt() might be destroyed as soon as
updateHighlight() calls applyPendingChanges() internally.

Fixes: QTBUG-129231
Pick-to: 6.5
Change-Id: I5d1dbac4730238302187d16476dd0c4aea614e13
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
(cherry picked from commit 0273207f7ad3a2909e7d0b5a59caea3606035cc6)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit eb4e404aa810b4593a766bcf61decc52fb82d138)
QQuickTableView: Fix crash when selecting uninitialized TableView 2024-12-13T03:10:05+00:00 MohammadHossein Qanbari mohammad.qanbari@qt.io 2024-12-02T16:28:07+00:00 a76da824b8fc6a6382b07a7c2380a339aa109453 This patch addresses an issue where TableView would crash when attempting to select cells without an initialized delegate. The problem occurred because the selection rectangle calculation did not account for empty columns or rows. The fix includes the following changes: - Validate selection rectangle to ensure non-zero width or height. - Check loaded rows/columns before change current index on key event. A new test case is added to verify that selection works correctly when the TableView delegate is not initialized. Some tests are just added to verify no crashes happen. Change-Id: I5060976c721d3625d016f7dc88d94b7277e2d0cb Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> (cherry picked from commit 481d2e54cc41960264878fcafdff13d702729712) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 83894c162a370c85038d5e3fdd41499bb7d0e386) 
This patch addresses an issue where TableView would crash when
attempting to select cells without an initialized delegate. The problem
occurred because the selection rectangle calculation did not account for
empty columns or rows.

The fix includes the following changes:
- Validate selection rectangle to ensure non-zero width or height.
- Check loaded rows/columns before change current index on key event.

A new test case is added to verify that selection works correctly when
the TableView delegate is not initialized. Some tests are just added
to verify no crashes happen.

Change-Id: I5060976c721d3625d016f7dc88d94b7277e2d0cb
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 481d2e54cc41960264878fcafdff13d702729712)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 83894c162a370c85038d5e3fdd41499bb7d0e386)
doc: Fix string, vector2d and matrix4x4 QML property documentation 2024-12-05T15:14:01+00:00 David Boddie david.boddie@qt.io 2024-12-04T15:18:20+00:00 288372b23212901975185ee39149ddfc0ecdd929 Change-Id: I30dc4f1573e5bfbf11bc0c69060fd5b77f1681e2 Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io> (cherry picked from commit 7f1025780738c75e959f6416ed889a88e6d42dc5) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Change-Id: I30dc4f1573e5bfbf11bc0c69060fd5b77f1681e2
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
(cherry picked from commit 7f1025780738c75e959f6416ed889a88e6d42dc5)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
doc: Fix string, real, point and size QML property documentation 2024-12-05T15:13:55+00:00 David Boddie david.boddie@qt.io 2024-12-04T15:15:30+00:00 ef0462d938dc8bfdc3ef298684318ac622eea8c9 Change-Id: I2de731368e403696ecf9d74a0ac68d1982d5ce24 Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io> (cherry picked from commit 2d9c5c46d34b90510f3af31f2dd01ae15226c6e0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Change-Id: I2de731368e403696ecf9d74a0ac68d1982d5ce24
Reviewed-by: Andreas Eliasson <andreas.eliasson@qt.io>
(cherry picked from commit 2d9c5c46d34b90510f3af31f2dd01ae15226c6e0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
TableView: ensure we position the syncView in the right direction 2024-12-03T16:40:22+00:00 Richard Moe Gustavsen richard.gustavsen@qt.io 2024-12-02T08:43:01+00:00 0011dad7f1f4f0945ae17876146619719b723e4d If a TableView has a syncView, a call to positionViewAtCell() will instead be forwarded to the syncview, according to the syncDirection. But as it stood, this was flipped, so that we ended up forwarding a horizontal positioning call to a vertically synced syncView, and vice versa. This patch will correct this, so that the forwarded positioning call matches the syncDirection. Pick-to: 6.5 Fixes: QTBUG-131776 Change-Id: Ibeaf5ce3d1d18c1ef0a0184c38336860fdee67be Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io> (cherry picked from commit bede04154deab7e8d7e992a76b272e37ecb41205) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
If a TableView has a syncView, a call to positionViewAtCell()
will instead be forwarded to the syncview, according to the
syncDirection. But as it stood, this was flipped, so that we
ended up forwarding a horizontal positioning call to a
vertically synced syncView, and vice versa.

This patch will correct this, so that the forwarded
positioning call matches the syncDirection.

Pick-to: 6.5
Fixes: QTBUG-131776
Change-Id: Ibeaf5ce3d1d18c1ef0a0184c38336860fdee67be
Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io>
(cherry picked from commit bede04154deab7e8d7e992a76b272e37ecb41205)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>