qt/qtdeclarative.git/src/quickcontrolstestutils, branch wip/nativemenus Qt Declarative (Quick 2) Correct license for Qt Test library files 2024-04-05T10:05:59+00:00 Lucie Gérard lucie.gerard@qt.io 2024-02-22T15:28:45+00:00 4ba4600606ab849a5fa997950dd031ba111b9911 They are licensed as test files. According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I5bc3e4d40c4d46a5499c9cd19480c5cdf36489f2 Reviewed-by: Kai Köhne <kai.koehne@qt.io> 
They are licensed as test files.
According to QUIP-18 [1], all test files should be
LicenseRef-Qt-Commercial OR GPL-3.0-only

[1]: https://contribute.qt-project.org/quips/18

Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I5bc3e4d40c4d46a5499c9cd19480c5cdf36489f2
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Use NO_GENERATE_CPP_EXPORTS explicitly 2024-03-20T11:40:43+00:00 Alexey Edelev alexey.edelev@qt.io 2023-11-28T13:24:37+00:00 276c13441fae123c2adbed86604f658d4c9ccc2d Use NO_GENERATE_CPP_EXPORTS explicitly for modules that don't need the autogenerated exports header file. Task-number: QTBUG-90492 Change-Id: I6b2b9949f4592de399517dc5e8c7bd96dc7120d6 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
Use NO_GENERATE_CPP_EXPORTS explicitly for modules that don't need
the autogenerated exports header file.

Task-number: QTBUG-90492
Change-Id: I6b2b9949f4592de399517dc5e8c7bd96dc7120d6
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Fix build without features.qml-object-model 2023-10-13T12:56:40+00:00 Tasuku Suzuki tasuku.suzuki@signal-slot.co.jp 2023-09-02T13:58:19+00:00 d13a566bb67d624ec1efc323ae477bea98a634e7 Introduce a new feature quicktemplates2-container for Container type quicktemplates2-container depends on qml-object-model Change-Id: Ic26f4b8bf390a04644b22e8067669a79b9d85e17 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
Introduce a new feature quicktemplates2-container for Container type
quicktemplates2-container depends on qml-object-model

Change-Id: Ic26f4b8bf390a04644b22e8067669a79b9d85e17
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Fix build with -no-feature-listview and itemviews 2023-04-13T03:07:51+00:00 Tasuku Suzuki tasuku.suzuki@signal-slot.co.jp 2023-04-13T01:51:13+00:00 922c89cf955f5703fca015f25e681cbcc783d580 tested with each/all of below -no-feature-gridview -no-feature-listview -no-feature-pathview -no-feature-tableview -no-feature-treeview Pick-to: 6.5 Change-Id: I90cc7bc45bb9065000bc0fc7eeb8e80f02acb0d0 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> 
tested with each/all of below
-no-feature-gridview
-no-feature-listview
-no-feature-pathview
-no-feature-tableview
-no-feature-treeview

Pick-to: 6.5
Change-Id: I90cc7bc45bb9065000bc0fc7eeb8e80f02acb0d0
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Add StyleInfo singleton to Qt.test.controls helper module 2023-02-16T14:56:16+00:00 Mitch Curtis mitch.curtis@qt.io 2023-01-23T05:16:49+00:00 bf9a08559e5ac6945e53d0bbde8345ce38343adf This allows accessing the current style in QML auto tests, which we need to conditionally skip certain tests after the Material 3 TextField/TextArea changes. Task-number: QTBUG-97993 Pick-to: 6.5 Change-Id: Ife4ca79deb96f17e879353a901e421b03b29ff25 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> 
This allows accessing the current style in QML auto tests, which we
need to conditionally skip certain tests after the Material 3
TextField/TextArea changes.

Task-number: QTBUG-97993
Pick-to: 6.5
Change-Id: Ife4ca79deb96f17e879353a901e421b03b29ff25
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
qtest_quickcontrols_p.h: don't mark functions file-static 2023-01-20T19:39:11+00:00 Marc Mutz marc.mutz@qt.io 2023-01-20T06:12:50+00:00 e34142e6cda177b601d8e5daba00a2ab84828db1 It's a header, and at least tst_styleimports.cpp doesn't use all of the functions, so throws a -Wunused-function warning on Clang 15 for runTests(): qtest_quickcontrols_p.h:36:12: warning: unused function 'runTests' [-Wunused-function] static int runTests(QObject *testObject, int argc, char *argv[]) ^ Fix by marking the functions as inline instead. Amends e310dadef779b28845b41fb091634cd001cda9de. Pick-to: 6.5 6.4 6.2 Change-Id: Id6cee7bdc2fe93a5e034d7ed445dc5f2c5d35360 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
It's a header, and at least tst_styleimports.cpp doesn't use all of
the functions, so throws a -Wunused-function warning on Clang 15 for
runTests():

  qtest_quickcontrols_p.h:36:12: warning: unused function 'runTests' [-Wunused-function]
    static int runTests(QObject *testObject, int argc, char *argv[])
               ^

Fix by marking the functions as inline instead.

Amends e310dadef779b28845b41fb091634cd001cda9de.

Pick-to: 6.5 6.4 6.2
Change-Id: Id6cee7bdc2fe93a5e034d7ed445dc5f2c5d35360
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Port from container::count() and length() to size() 2022-10-07T21:38:48+00:00 Marc Mutz marc.mutz@qt.io 2022-10-05T05:29:16+00:00 958cd3ee1094a068b6d0ff27c73a4b3caff088ad This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8:

  auto QtContainerClass = anyOf(
      expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o),
      expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o));
  makeRule(cxxMemberCallExpr(on(QtContainerClass),
                             callee(cxxMethodDecl(hasAnyName({"count", "length"),
                                                  parameterCountIs(0))))),
           changeTo(cat(access(o, cat("size"), "()"))),
           cat("use 'size()' instead of 'count()/length()'"))

a.k.a qt-port-to-std-compatible-api with config Scope: 'Container',
with the extended set of container classes recognized.

Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Fix warning from ignoring return of [nodiscard] method 2022-09-17T20:32:10+00:00 Volker Hilsheimer volker.hilsheimer@qt.io 2022-09-03T09:50:14+00:00 7bcfc16ca2790b387b734f1f37eb43198f05994a Compiler warns: ignoring return value of function declared with 'nodiscard' attribute [-Wunused-result] Pick-to: 6.4 Change-Id: If10d41fad7dc77b36eecc8725de178b0908f32de Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
Compiler warns:

ignoring return value of function declared with 'nodiscard' attribute
[-Wunused-result]

Pick-to: 6.4
Change-Id: If10d41fad7dc77b36eecc8725de178b0908f32de
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Drop unnecessary creation contexts from Quick Controls 2022-09-09T02:32:07+00:00 Ulf Hermann ulf.hermann@qt.io 2022-08-30T08:02:40+00:00 fc683799fee933757abdd3953048f136e750690b Bound components can only be instantiated in the context they're declared in. Adding a context in between before instantiating a component makes it impossible to bind the component. We want to use bound components so that we can safely use IDs of other objects from the same context inside the objects created from the component. Pick-to: 6.4 Fixes: QTBUG-106042 Change-Id: I7a0e1ea3e079ccd0f5fe156f07f8bc62149c6c0a Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
Bound components can only be instantiated in the context they're
declared in. Adding a context in between before instantiating a
component makes it impossible to bind the component. We want to use
bound components so that we can safely use IDs of other objects from
the same context inside the objects created from the component.

Pick-to: 6.4
Fixes: QTBUG-106042
Change-Id: I7a0e1ea3e079ccd0f5fe156f07f8bc62149c6c0a
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Fix flaky tst_QQuickFileDialogImpl::goUpIntoLargeFolder test 2022-09-08T14:46:55+00:00 Mitch Curtis mitch.curtis@qt.io 2022-09-07T09:43:41+00:00 f406385dfb9e88b3661f8524281b8f9d9e1351a7 Ensure that all expected delegates have loaded before trying to verify that the correct file is selected. This requires a modification to verifyFileDialogDelegates to account for the large amount of files that goUpIntoLargeFolder deals with, as QTest's failure message is limited to 1024 characters. Fixes: QTBUG-101488 Pick-to: 6.2 6.3 6.4 Change-Id: I65cf6ffc4724309083899dac2acc1f04a11a1220 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> 
Ensure that all expected delegates have loaded before trying
to verify that the correct file is selected.

This requires a modification to verifyFileDialogDelegates to
account for the large amount of files that
goUpIntoLargeFolder deals with, as QTest's failure message
is limited to 1024 characters.

Fixes: QTBUG-101488
Pick-to: 6.2 6.3 6.4
Change-Id: I65cf6ffc4724309083899dac2acc1f04a11a1220
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>