qt/qtdeclarative.git/src/quicktemplates/qquickmonthmodel.cpp, branch 6.9.2 Qt Declarative (Quick 2) MonthGrid: address post-merge review feedback on timezone patch 2025-07-23T20:27:50+00:00 Mitch Curtis mitch.curtis@qt.io 2025-07-01T02:38:54+00:00 ab3781ee0a1f4c6fe239e6b216e93a37657caad0 Amends 57325020f65665d91e63dc300d674a8e8dc411f1. - Add a comment explaining why we store QQuickMonthGridPrivate::pressedDate as QDateTime now. - Store QDateTimes as local time to simplify things. - Make firstDateToDisplay const while we're here. Task-number: QTBUG-72208 Pick-to: 6.8 Change-Id: I9fbee12608855f30d229b4e3a4e78da5561feb44 Reviewed-by: Edward Welbourne <edward.welbourne@qt.io> (cherry picked from commit 2e1337d87a60b8d1a30f5296bf3f614ec0bca383) (cherry picked from commit 60f0e4f5f85365a1a342c28e981ee681c94ed7e8) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Amends 57325020f65665d91e63dc300d674a8e8dc411f1.

- Add a comment explaining why we store
QQuickMonthGridPrivate::pressedDate as QDateTime now.
- Store QDateTimes as local time to simplify things.
- Make firstDateToDisplay const while we're here.

Task-number: QTBUG-72208
Pick-to: 6.8
Change-Id: I9fbee12608855f30d229b4e3a4e78da5561feb44
Reviewed-by: Edward Welbourne <edward.welbourne@qt.io>
(cherry picked from commit 2e1337d87a60b8d1a30f5296bf3f614ec0bca383)
(cherry picked from commit 60f0e4f5f85365a1a342c28e981ee681c94ed7e8)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
MonthGrid: fix dates being incorrect for certain timezones 2025-07-09T09:29:00+00:00 Mitch Curtis mitch.curtis@qt.io 2025-06-19T05:56:17+00:00 7664d1d5aed4fc8018c9119efcf6d0fe94f8e434 When a QDate is passed to QML, it becomes to a JavaScript Date. As Dates are stored in local time, the QDates we were passing to QML had the potential to be one day off in certain timezones. For example: 00:00 UTC converted to UTC-8 is 20:00 the day before. Fix this by storing and providing dates as QDateTime so that we can give it a time of day that can't possibly result in a different day when converted to local time. It's fine to change the C++ API since it's private, and nothing will change for the type that users see, since they always get a Date. Add a SystemEnvironment singleton to QQuickControlsTestUtils (Qt.test.controls) to allow reading and writing environment variables from QML. Fixes: QTBUG-72208 Pick-to: 6.8 Change-Id: Idb4ab26568d8f1eddd5ab4cebe691e38173d02a9 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> (cherry picked from commit 57325020f65665d91e63dc300d674a8e8dc411f1) (cherry picked from commit 2e37850dabf89fae009821cfc98918ba3345a315) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
When a QDate is passed to QML, it becomes to a JavaScript Date.
As Dates are stored in local time, the QDates we were passing to
QML had the potential to be one day off in certain timezones.
For example: 00:00 UTC converted to UTC-8 is 20:00 the day before.

Fix this by storing and providing dates as QDateTime so that we can
give it a time of day that can't possibly result in a different day
when converted to local time. It's fine to change the C++ API since
it's private, and nothing will change for the type that users see,
since they always get a Date.

Add a SystemEnvironment singleton to QQuickControlsTestUtils
(Qt.test.controls) to allow reading and writing environment
variables from QML.

Fixes: QTBUG-72208
Pick-to: 6.8
Change-Id: Idb4ab26568d8f1eddd5ab4cebe691e38173d02a9
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
(cherry picked from commit 57325020f65665d91e63dc300d674a8e8dc411f1)
(cherry picked from commit 2e37850dabf89fae009821cfc98918ba3345a315)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Pass QDate by value, not const reference 2023-07-28T08:28:58+00:00 Edward Welbourne edward.welbourne@qt.io 2023-07-26T11:49:36+00:00 5782728bb438fb513046682d3f75330ebd34c8f3 It's simply a wrapper round a qint64, no pimpl, nothing clever. Change-Id: I513b1bca19511e41a36af504005950839f0b2a66 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
It's simply a wrapper round a qint64, no pimpl, nothing clever.

Change-Id: I513b1bca19511e41a36af504005950839f0b2a66
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Remove "2" from Qt Quick Controls directories 2022-12-01T02:26:20+00:00 Mitch Curtis mitch.curtis@qt.io 2022-11-18T07:15:16+00:00 4bd87b903b355b53e3105ba1ae7c154c4e55cdaf Qt Quick Controls 2 was named that way because it was a follow-up to Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer supported, we don't need to have "2" in the name. Work on this was already started for the documentation in 1abdfe5d5a052f2298b7bf657513dfa7e0c66a56. By doing this renaming a few weeks before feature freeze, it won't affect the release but still results in as little time possible spent manually fixing conflicts in cherry-picks from non-LTS releases as a result of the renaming. This patch does the following: - Renames directories. - Adapts CMakeLists.txt and other files to account for the new paths. A follow-up patch will handle documentation. It does not touch library names or other user-facing stuff, as that will have to be done in Qt 7. Task-number: QTBUG-95413 Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
Qt Quick Controls 2 was named that way because it was a follow-up to
Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer
supported, we don't need to have "2" in the name. Work on this was
already started for the documentation in
1abdfe5d5a052f2298b7bf657513dfa7e0c66a56.

By doing this renaming a few weeks before feature freeze, it won't
affect the release but still results in as little time possible spent
manually fixing conflicts in cherry-picks from non-LTS releases as a
result of the renaming.

This patch does the following:

- Renames directories.
- Adapts CMakeLists.txt and other files to account for the new paths.

A follow-up patch will handle documentation.

It does not touch library names or other user-facing stuff, as that
will have to be done in Qt 7.

Task-number: QTBUG-95413
Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>