qt/qtdeclarative.git/src/quicktemplates/qquickpopup.cpp, branch 6.8.0 Qt Declarative (Quick 2) doc: fix some incorrect information about QQuickPopup::popupType 2024-09-25T08:38:32+00:00 Oliver Eftevaag oliver.eftevaag@qt.io 2024-09-24T13:09:51+00:00 b9d07f13f71f491591457b781ad22ab5c9973ae8 Since we ran out of time, we're not going to make out styles bind on popupType for 6.8. Remove the claim that we are. Also mention that we might make that decision later on. Change-Id: Iad0b8dedff0b66e75adb5b80e6bbd5d087ae5d66 Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> (cherry picked from commit a24914067d5495c7baebdb7bfacbe53cbab91421) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 556f6cc7ba73d51f9a6a7e13224bbe84e054521a) 
Since we ran out of time, we're not going to make out styles bind on
popupType for 6.8.

Remove the claim that we are.

Also mention that we might make that decision later on.

Change-Id: Iad0b8dedff0b66e75adb5b80e6bbd5d087ae5d66
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
(cherry picked from commit a24914067d5495c7baebdb7bfacbe53cbab91421)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 556f6cc7ba73d51f9a6a7e13224bbe84e054521a)
Set visibility of popupItem to false when a popup window is not visible 2024-09-06T01:38:36+00:00 Ed Cooke ed.cooke@qt.io 2024-08-22T11:19:54+00:00 78686bde037d98a25fbc4c7c941d0cb209432e11 When transitioning out of a popup with popupType set to Popup Window, the popupItem's visibility needs to be set to false so that listeners are notified of the change. Fixes: QTBUG-126815 Change-Id: I2545e530fa22d14478ab90f0fc3da61ef79dc171 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> (cherry picked from commit 1f9d7d2daa6541aab2e830e16523253232625145) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
When transitioning out of a popup with popupType set to Popup Window,
the popupItem's visibility needs to be set to false so that listeners
are notified of the change.

Fixes: QTBUG-126815
Change-Id: I2545e530fa22d14478ab90f0fc3da61ef79dc171
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit 1f9d7d2daa6541aab2e830e16523253232625145)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Make tst_QQuickMenu::mouse work with PopupType Item and Window 2024-09-03T19:20:23+00:00 Oliver Eftevaag oliver.eftevaag@qt.io 2024-08-20T13:50:06+00:00 99283e79cf0130b4abb4b7f6a57423934090046f The test verifies that you can interact with menus, by using the mouse. Adapt the test to be data driven, with both popup types, to ensure that we can interact with popups using `popupType: Popup.Item` and `popupType: Popup.Window.` Task-number: QTBUG-126553 Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6 Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> (cherry picked from commit b050d636d17a9b893d11b4924c7879f57f171cdf) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
The test verifies that you can interact with menus, by using the mouse.

Adapt the test to be data driven, with both popup types, to ensure that
we can interact with popups using `popupType: Popup.Item` and `popupType:
Popup.Window.`

Task-number: QTBUG-126553
Change-Id: I7e369bfb47af0d9dbe3aebe6211a70628ff1eba6
Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io>
(cherry picked from commit b050d636d17a9b893d11b4924c7879f57f171cdf)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
QQuickPopupWindow is never deconstructed 2024-09-03T04:35:15+00:00 Ed Cooke ed.cooke@qt.io 2024-07-15T10:39:46+00:00 fff1fac93d5725f83531e59586aab061c0ad3dbe QQuickPopupWindow is never deconstructed, resulting in dangling connections during the destruction of QQuickPopup. This can lead to a crash, most notably when the parent window's geometry changes during the destruction of QQuickPopup. Task-number: QTBUG-126553 Change-Id: Idad35d9924323f7980c3fa644890f0ba95773744 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> (cherry picked from commit 5af51625ad2aabb645708fe15b9a548dfd17177c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
QQuickPopupWindow is never deconstructed, resulting in dangling
connections during the destruction of QQuickPopup. This can lead to a
crash, most notably when the parent window's geometry changes during the
destruction of QQuickPopup.

Task-number: QTBUG-126553
Change-Id: Idad35d9924323f7980c3fa644890f0ba95773744
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit 5af51625ad2aabb645708fe15b9a548dfd17177c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Doc: Replace \instantiates with \nativetype 2024-08-28T09:31:23+00:00 Paul Wicking paul.wicking@qt.io 2024-08-20T07:36:38+00:00 50032ea50b7a910071db616b922b3387ee50af2b Since the implementation of the `\nativetype`-command in QDoc, the `\instantiates`-command is deprecated. Replace the use of the deprecated command in favor of its replacement. Task-number: QTBUG-128216 Change-Id: I23d9f66d3f6db2e5f827d7868497a432bb9b0626 Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io> (cherry picked from commit a464ff5bfa15201de64d05121dc192dbd4655890) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Since the implementation of the `\nativetype`-command in QDoc,
the `\instantiates`-command is deprecated. Replace the use of the
deprecated command in favor of its replacement.

Task-number: QTBUG-128216
Change-Id: I23d9f66d3f6db2e5f827d7868497a432bb9b0626
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
(cherry picked from commit a464ff5bfa15201de64d05121dc192dbd4655890)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Doc: Fix linking issues 2024-07-29T12:25:34+00:00 Topi Reinio topi.reinio@qt.io 2024-07-26T10:54:22+00:00 42a351244efffc5f69521dd1b62cec2a3f305550 Fixes the following warnings: (qdoc) warning: Can't link to 'qquickattachedpropertypropagator.html' (qdoc) warning: Can't link to 'Type Of Parameter In Signal Cannot Be Used' (qdoc) warning: Can't link to 'QQmlEngine Class#QML_ELEMENT' (qdoc) warning: Can't link to 'qml-qtqml-component.html' (qdoc) warning: Can't link to 'import paths' (qdoc) warning: Can't link to 'qml-var.html' (qdoc) warning: Can't link to 'Qt Quick Shapes' (qdoc) warning: Can't link to 'Qt Svg' (qdoc) warning: Can't link to 'Native Menus' (qdoc) warning: Can't link to 'Popup Items' (qdoc) warning: Can't link to 'Popup Windows' (qdoc) warning: Can't link to 'Grid QML Type' (qdoc) warning: Can't link to 'layer.smooth' Change-Id: Ia61b0568f481018850027f445446f64122abb5fd Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io> (cherry picked from commit edb1a1206a7c0f4a6f078a9564ad042112953c58) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Fixes the following warnings:

(qdoc) warning: Can't link to 'qquickattachedpropertypropagator.html'
(qdoc) warning: Can't link to 'Type Of Parameter In Signal Cannot Be Used'
(qdoc) warning: Can't link to 'QQmlEngine Class#QML_ELEMENT'
(qdoc) warning: Can't link to 'qml-qtqml-component.html'
(qdoc) warning: Can't link to 'import paths'
(qdoc) warning: Can't link to 'qml-var.html'
(qdoc) warning: Can't link to 'Qt Quick Shapes'
(qdoc) warning: Can't link to 'Qt Svg'
(qdoc) warning: Can't link to 'Native Menus'
(qdoc) warning: Can't link to 'Popup Items'
(qdoc) warning: Can't link to 'Popup Windows'
(qdoc) warning: Can't link to 'Grid QML Type'
(qdoc) warning: Can't link to 'layer.smooth'

Change-Id: Ia61b0568f481018850027f445446f64122abb5fd
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Reviewed-by: Venugopal Shivashankar <Venugopal.Shivashankar@qt.io>
(cherry picked from commit edb1a1206a7c0f4a6f078a9564ad042112953c58)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Fix binding loop that occurs in QtQuickDialogs using popup windows 2024-07-21T13:44:54+00:00 Oliver Eftevaag oliver.eftevaag@qt.io 2024-07-17T16:07:32+00:00 3a9b84c5dab41b61ab98d09e30ba2f3b35812cf6 Here's a vague description of the loop: 1. The implicitWidth binding of QQuickDialog needs to be evaluated. Call setImplictWidth(). 2. QQuickPopupItem::geometryChange() and QQuickPopup::geometryChange() are called, 3. QQuickPopupPositioner::reposition() is called. 4. QQuickPopupPrivate::windowInsets() is called, to be used as positional offsets. This ends up calling QQuickControl::background(). 5. Because of deferred execution, the background wasn't already initialized. Needs to be lazily initialized instead. 6. QQuickPopup::setBackground() and QQuickPopup::implicitBackgroundWidthChanged() are called. 7. Reevaluate implicitWidth binding. 8. Theoretically back to 1. which is why it's a loop. The fix here, is to avoid calling QQuickControl::background() in QQuickPopupPrivate::windowInsets(), but instead access the data directly, if the background is executing. Change-Id: I89f5f92cd9f2dc5f78070a3cf1e21dc6bfdd10f7 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> (cherry picked from commit 28ed272d814e34c77ede4c1c818dee4149ff6292) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Here's a vague description of the loop:
1. The implicitWidth binding of QQuickDialog needs to be evaluated. Call
   setImplictWidth().
2. QQuickPopupItem::geometryChange() and QQuickPopup::geometryChange()
   are called,
3. QQuickPopupPositioner::reposition() is called.
4. QQuickPopupPrivate::windowInsets() is called, to be used as
   positional offsets. This ends up calling QQuickControl::background().
5. Because of deferred execution, the background wasn't already
   initialized. Needs to be lazily initialized instead.
6. QQuickPopup::setBackground() and
   QQuickPopup::implicitBackgroundWidthChanged() are called.
7. Reevaluate implicitWidth binding.
8. Theoretically back to 1. which is why it's a loop.

The fix here, is to avoid calling QQuickControl::background() in
QQuickPopupPrivate::windowInsets(), but instead access the data
directly, if the background is executing.

Change-Id: I89f5f92cd9f2dc5f78070a3cf1e21dc6bfdd10f7
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
(cherry picked from commit 28ed272d814e34c77ede4c1c818dee4149ff6292)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Popup: let the style set the default popup type 2024-07-19T13:42:56+00:00 Richard Moe Gustavsen richard.gustavsen@qt.io 2024-06-27T08:59:28+00:00 12f126bd51286d3e5c0e5283a54f3b70f971847a Rather than hard-coding from c++ which popup type to use, leave it to the style to set the preferred type. This let's us e.g enable native menus for the macOS style, but keep the menu implementations for the other (perhaps 3rd party) styles, even when running on macOS. For example the Material and Imagine styles have menus that matches the other controls. Since the style will decide the popup type, we can no longer support setting the popupType to "undefined". But being able to change the popup type back and forth at runtime (and resetting it) is a very low-priority use case, and can be worked around by other means (the app can store the initial value before changing it), if needed. Change-Id: I95575bd25b313a4141007c6f16c4cda0482c573b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> (cherry picked from commit 744fda367494bc093449f57351b8b74d781c9a50) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Rather than hard-coding from c++ which popup type
to use, leave it to the style to set the preferred
type. This let's us e.g enable native menus for the
macOS style, but keep the menu implementations for
the other (perhaps 3rd party) styles, even when
running on macOS. For example the Material and Imagine
styles have menus that matches the other controls.

Since the style will decide the popup type, we can no
longer support setting the popupType to "undefined".
But being able to change the popup type back and forth
at runtime (and resetting it) is a very low-priority
use case, and can be worked around by other means (the
app can store the initial value before changing it), if
needed.

Change-Id: I95575bd25b313a4141007c6f16c4cda0482c573b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
(cherry picked from commit 744fda367494bc093449f57351b8b74d781c9a50)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Many tests fail when a dimmer is created using PopupWindow popupType 2024-07-17T15:21:45+00:00 Ed Cooke ed.cooke@qt.io 2024-07-15T13:48:03+00:00 1044ec54092e8345fb96e9ad51407e3a614702c8 When the dimmer is created, the item is attempted to be stacked before the top level PopupWindow. This of course is unnecessary and results in a failed test (QQuickItem::stackBefore throws a warning when it is unsuccessful). Fixes: QTBUG-127166 Change-Id: I464718a176a93008bdd6c7545e6a4ae401566d89 Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io> (cherry picked from commit d0c358b1ee64f2a27b69ce575e625a65fd4dcc4c) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
When the dimmer is created, the item is attempted to be stacked before
the top level PopupWindow. This of course is unnecessary and results in
a failed test (QQuickItem::stackBefore throws a warning when it is
unsuccessful).

Fixes: QTBUG-127166
Change-Id: I464718a176a93008bdd6c7545e6a4ae401566d89
Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
(cherry picked from commit d0c358b1ee64f2a27b69ce575e625a65fd4dcc4c)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
Doc: explain polish behavior of closed Popups 2024-07-08T05:15:19+00:00 Mitch Curtis mitch.curtis@qt.io 2024-07-05T08:19:09+00:00 21050410e729d47bb4cfd74101d85293cc3062b4 Task-number: QTBUG-126560 Pick-to: 6.7 6.5 Change-Id: I06da6662e3a52df32c8be63e1c88ed6e1110897a Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> (cherry picked from commit 6d76c8371577a5eb32665c3bc049eb5b0cd232b0) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> 
Task-number: QTBUG-126560
Pick-to: 6.7 6.5
Change-Id: I06da6662e3a52df32c8be63e1c88ed6e1110897a
Reviewed-by: Richard Moe Gustavsen <richard.gustavsen@qt.io>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
(cherry picked from commit 6d76c8371577a5eb32665c3bc049eb5b0cd232b0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>