In the linked bug report, a Loader is deactivated after an Image within it has started loading. A slot was connected to the statusChanged signal of the Image, which calls replace(). This caused an assertion failure because the StackView's QML engine was null. Note that it's not enough to check if the QML context is non-null, because it still is at that point. There isn't an easy way to check for this in one place in QQuickStackView, let alone in user code, so we need a lot of engine checks. Add a C++ test for StackView, as I wasn't able to get it to crash with a QML-only test. For now we only need to test the Basic style, since most styles don't provide anything too interesting or complex for StackView. Fixes: QTBUG-140018 Pick-to: 6.8 6.10 Change-Id: I53ba016bf44c46b7734b0b2daeeb62177f9067db Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
The files (folders) already processed are listed in each issue in epic QTBUG-134547 These files were processed half a year ago. In order to make it clear that all of these files are already processed, mark them with an explicit default security header. For the record, this was generated with this script: find -E . -regex ".*\.(cpp|h|hpp|mm|qml|js)$" | xargs python3 ~/bin/add-cra-header.py in the folders listed in each subtask of QTBUG-134547 (add-cra-header.py only exist at my desktop, but it simply adds the default security header if it doesn't already have any existing security header) QUIP: 23 Fixes: QTBUG-134547 Pick-to: 6.10 6.9 6.8 Change-Id: Ieb8c78ea6561fdbdd27c7b13185ece853eedf80f Reviewed-by: Oliver Eftevaag <oliver.eftevaag@qt.io>
Add virtual methods "baseDeleted" and "debugName" to QQuickItemChangeListener that let us report whether the object that implements QQuickItemChangeListener is already being destroyed. Add a "safe" version of QQuickItemChangeListener that overrides that virtual method using CRTP: if the derived class that it is instantiated with has a member "inDestructor" (e.g. a QQuickItemPrivate) or "wasDeleted" (e.g. a QObjectPrivate), then return the value of that variable. If the derived type is a QObject or QQuickItem, access the member via QQmlData::wasDeleted. Ignore calls on listeners that are the same object as the caller. Use that new type in those classes where it isn't immediately obvious that they clean up after themselves: classes that don't implement a destructor are a red flag. In addition, add a list to safe listener version to add/remove each item it's listening on. Issue runtime warnings in developer-builds when listeners are called for which baseDestroyed() returns true, and when listeners are destroyed while they still have items on their list. Task-number: QTBUG-98790 Change-Id: I15ed66a36556caa0e6acf5b768dec2ae92b01d64 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
This way qmltyperegistrar can recognize it and refrain from warning about it. Task-number: QTBUG-101143 Change-Id: I598140e7e90dbd3e27a78c26eff3d46f0fd3e989 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
[ChangeLog][Controls][StackView] Added strongly-typed replaceCurrentItem functions. These can be compiled to C++ by the QML Compiler. Task-number: QTBUG-112475 Change-Id: I5de7d712cd1839ed3e6f1f7229bd2e5c896fd6bd Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
[ChangeLog][Controls][StackView] Added strongly-typed popToItem popToIndex, and popCurrentItem functions. These can be compiled to C++ by the QML Compiler. Task-number: QTBUG-112475 Change-Id: If7452ec238a2d292a64d266ac27bdb146c713017 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Pick-to: 6.5 Change-Id: I609a843bddbd0776452d289b144dab803503a483 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Qt Quick Controls 2 was named that way because it was a follow-up to Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer supported, we don't need to have "2" in the name. Work on this was already started for the documentation in 1abdfe5d5a052f2298b7bf657513dfa7e0c66a56. By doing this renaming a few weeks before feature freeze, it won't affect the release but still results in as little time possible spent manually fixing conflicts in cherry-picks from non-LTS releases as a result of the renaming. This patch does the following: - Renames directories. - Adapts CMakeLists.txt and other files to account for the new paths. A follow-up patch will handle documentation. It does not touch library names or other user-facing stuff, as that will have to be done in Qt 7. Task-number: QTBUG-95413 Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>