qt/qtdeclarative.git/src/quicktemplates2/qquickpage.cpp, branch wip/material3 Qt Declarative (Quick 2) Remove "2" from Qt Quick Controls directories 2022-12-01T02:26:20+00:00 Mitch Curtis mitch.curtis@qt.io 2022-11-18T07:15:16+00:00 4bd87b903b355b53e3105ba1ae7c154c4e55cdaf Qt Quick Controls 2 was named that way because it was a follow-up to Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer supported, we don't need to have "2" in the name. Work on this was already started for the documentation in 1abdfe5d5a052f2298b7bf657513dfa7e0c66a56. By doing this renaming a few weeks before feature freeze, it won't affect the release but still results in as little time possible spent manually fixing conflicts in cherry-picks from non-LTS releases as a result of the renaming. This patch does the following: - Renames directories. - Adapts CMakeLists.txt and other files to account for the new paths. A follow-up patch will handle documentation. It does not touch library names or other user-facing stuff, as that will have to be done in Qt 7. Task-number: QTBUG-95413 Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
Qt Quick Controls 2 was named that way because it was a follow-up to
Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer
supported, we don't need to have "2" in the name. Work on this was
already started for the documentation in
1abdfe5d5a052f2298b7bf657513dfa7e0c66a56.

By doing this renaming a few weeks before feature freeze, it won't
affect the release but still results in as little time possible spent
manually fixing conflicts in cherry-picks from non-LTS releases as a
result of the renaming.

This patch does the following:

- Renames directories.
- Adapts CMakeLists.txt and other files to account for the new paths.

A follow-up patch will handle documentation.

It does not touch library names or other user-facing stuff, as that
will have to be done in Qt 7.

Task-number: QTBUG-95413
Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
QuickTemplates2: includemocs 2022-04-29T04:40:07+00:00 Marc Mutz marc.mutz@qt.io 2022-04-28T14:29:37+00:00 268b2bedd1f9d99eb788293cd432b14b4bad6bff Including moc files directly into their classes' TU tends to improve codegen and enables extended compiler warnings, e.g. about unused private functions or fields. Pick-to: 6.3 6.2 5.15 Task-number: QTBUG-102948 Change-Id: Iac3f0f54ecd734d8558645094f6373dd9335852b Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io> 
Including moc files directly into their classes' TU tends to improve
codegen and enables extended compiler warnings, e.g. about unused
private functions or fields.

Pick-to: 6.3 6.2 5.15
Task-number: QTBUG-102948
Change-Id: Iac3f0f54ecd734d8558645094f6373dd9335852b
Reviewed-by: Mårten Nordheim <marten.nordheim@qt.io>
Revert "Workaround ChangeListener getting called on semi-deleted objects" 2021-12-02T11:52:37+00:00 Fabian Kosmale fabian.kosmale@qt.io 2021-12-01T08:00:59+00:00 536ed00fcac43afd5b47d46bc77f1ab0dc6dec7f This reverts commit 74d2ed9203ed0e9fc3726d685b501f16a98b1d96. Reason for revert: We have a better fix now (e5e371291ace1ae0a833d2be3aee42d3e8716c7e). Change-Id: I9dd5fa703a475f67a9565a1a9b37489b3ed73db1 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> 
This reverts commit 74d2ed9203ed0e9fc3726d685b501f16a98b1d96.

Reason for revert: We have a better fix now
(e5e371291ace1ae0a833d2be3aee42d3e8716c7e).

Change-Id: I9dd5fa703a475f67a9565a1a9b37489b3ed73db1
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Workaround ChangeListener getting called on semi-deleted objects 2021-11-30T11:28:24+00:00 Fabian Kosmale fabian.kosmale@qt.io 2021-11-30T11:04:16+00:00 74d2ed9203ed0e9fc3726d685b501f16a98b1d96 Without this change, the emit in itemVisibilityChanged would trigger QFATAL : tst_controls::Basic::Dialog::test_layout() ASSERT failure in QQuickDialog: "Called object is not of the correct type (class destructor may have already run)" in tst_basic, as the object was already semi-destroyed. Task-number: QTBUG-98790 Change-Id: I112df9da0c07a1f9c14b8d557c1c1c19405d3180 Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
Without this change, the emit in itemVisibilityChanged would trigger
QFATAL : tst_controls::Basic::Dialog::test_layout()
ASSERT failure in QQuickDialog: "Called object is not of the correct type
(class destructor may have already run)"
in tst_basic, as the object was already semi-destroyed.

Task-number: QTBUG-98790
Change-Id: I112df9da0c07a1f9c14b8d557c1c1c19405d3180
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Use up-to date LGPL license header 2021-11-29T08:21:34+00:00 Kai Köhne kai.koehne@qt.io 2021-11-25T16:22:05+00:00 5d4679289bc5a46df4f767e7eabcee0bcf99169d Remove usages of outdated LGPL3 header that references LICENSES.LGPLv3 instead of LICENSES.LGPL3. Change-Id: If7a90ec18331a68491c5a740f131a5e7b3f37df4 Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> 
Remove usages of outdated LGPL3 header that references LICENSES.LGPLv3
instead of LICENSES.LGPL3.

Change-Id: If7a90ec18331a68491c5a740f131a5e7b3f37df4
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
Doc: make it clear that Page doesn't render its title text 2021-06-16T13:15:18+00:00 Mitch Curtis mitch.curtis@qt.io 2021-06-16T08:08:43+00:00 41766ac6d6e100b69d74c98edde60f0835b7da13 This is demonstrated in the example, but it's better to make it clear. Pick-to: 5.15 6.1 6.2 Change-Id: Ie5efcca2256da6a03d31df9cf045f4a97d1ad1ed Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This is demonstrated in the example, but it's better to make it clear.

Pick-to: 5.15 6.1 6.2
Change-Id: Ie5efcca2256da6a03d31df9cf045f4a97d1ad1ed
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Doc: clarify sizing behavior of Page 2021-05-05T09:59:53+00:00 Mitch Curtis mitch.curtis@qt.io 2021-04-23T07:02:56+00:00 58ae16f9d40b1edbd2369b3571a40d825819c758 Items declared as children must be positioned and sized manually. Pick-to: 6.1 Change-Id: Ie2b2989de07729464ae38b634992d53063ff739d Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Items declared as children must be positioned and sized manually.

Pick-to: 6.1
Change-Id: Ie2b2989de07729464ae38b634992d53063ff739d
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Respect user-set Accessible.name 2019-12-03T12:40:15+00:00 Mitch Curtis mitch.curtis@qt.io 2019-11-05T11:51:02+00:00 463898f0765b83f6c391f6802a0ee06796f9f6d2 Check if the user has set Accessible.name before setting it to the control's text/title/etc. Fixes: QTBUG-66583 Change-Id: I8b2c8ab3f8a8ae8e76c8e6a241260b7f90eca254 Reviewed-by: Liang Qi <liang.qi@qt.io> 
Check if the user has set Accessible.name before setting it to the
control's text/title/etc.

Fixes: QTBUG-66583
Change-Id: I8b2c8ab3f8a8ae8e76c8e6a241260b7f90eca254
Reviewed-by: Liang Qi <liang.qi@qt.io>
Doc: Fix qdoc warnings 2019-11-26T12:51:32+00:00 Venugopal Shivashankar Venugopal.Shivashankar@qt.io 2019-11-14T07:27:10+00:00 8ee511bcd9f1376e9995ab3f30f6415ad60b7c05 The warnings were about: - Undocumented function parameters - Instances of \instantiates that us an internal class - A few link issues Task-number: QTBUG-79827 Change-Id: I60094279c7da6bc446b5c63b7b4924b71cee4672 Reviewed-by: Paul Wicking <paul.wicking@qt.io> 
The warnings were about:
- Undocumented function parameters
- Instances of \instantiates that us an internal class
- A few link issues

Task-number: QTBUG-79827
Change-Id: I60094279c7da6bc446b5c63b7b4924b71cee4672
Reviewed-by: Paul Wicking <paul.wicking@qt.io>