qt/qtdeclarative.git/src/quicktemplates2/qquicktextarea.cpp, branch wip/material3

Remove "2" from Qt Quick Controls directories

2022-12-01T02:26:20+00:00

Qt Quick Controls 2 was named that way because it was a follow-up to
Qt Quick Controls 1.x. Now that Qt Quick Controls 1 is no longer
supported, we don't need to have "2" in the name. Work on this was
already started for the documentation in
1abdfe5d5a052f2298b7bf657513dfa7e0c66a56.

By doing this renaming a few weeks before feature freeze, it won't
affect the release but still results in as little time possible spent
manually fixing conflicts in cherry-picks from non-LTS releases as a
result of the renaming.

This patch does the following:

- Renames directories.
- Adapts CMakeLists.txt and other files to account for the new paths.

A follow-up patch will handle documentation.

It does not touch library names or other user-facing stuff, as that
will have to be done in Qt 7.

Task-number: QTBUG-95413
Change-Id: I170d8db19033ee71e495ff0c5c1a517a41ed7634
Reviewed-by: Mitch Curtis

TextArea: selectByMouse default=true, but not on touchscreens

2022-08-29T18:48:07+00:00

When you drag a finger across a TextArea, it should not select text.
- your finger probably covers several characters, so you can't see where
  you're selecting until afterwards
- if the item is in a Flickable, flicking by touch should be prioritized
- if flicking happens, the text cursor should not move; but to avoid
  losing too much functionality, we allow it to move on release, if
  the TextArea gets the release (i.e. if it still has the exclusive
  grab)
- TextArea's pressed, pressAndHold and released signals continue to
  behave the same with touch as with mouse

As with the TextEdit change in 90d3fac73a10b9363fd34e6757cc730d7a0c086c,
we now distinguish mouse events that are synthesized from non-mouse
devices and avoid mouse-like behaviors as described above, but there is
no behavior change if the event comes from an actual mouse or touchpad.

In QQuickPressHandler::mousePressEvent() we give the original event's
device to the delayed press event, now that we check the device to
distinguish "real" mouse events from those that are synthesized from
touch.

[ChangeLog][Controls][TextArea] The selectByMouse property is now
enabled by default, but no longer enables selecting by dragging your
finger across text on a touchscreen. Platforms that are optimized for
touchscreens normally use special text-selection handles, which interact
with Qt via QInputMethod. You can opt out of the behavior change by
setting the environment variable
QT_QUICK_CONTROLS_TEXT_SELECTION_BEHAVIOR=old.

Pick-to: 6.4
Task-number: QTBUG-10684
Task-number: QTBUG-38934
Task-number: QTBUG-90494
Task-number: QTBUG-101205
Change-Id: Icbe81e547b1cf8d5e3cc3ed922f12c7b411ca658
Reviewed-by: Qt CI Bot 
Reviewed-by: Richard Moe Gustavsen

QQuickTextArea/Field: don't block hover events

2022-07-19T20:22:36+00:00

Controls shouldn't block hover from propagating by default.
This was a regression in Qt 6.2 compared to Qt 5.15, and was
fixed with 0c7b0a43064c8be452f4be74701f1dabce87f24c. But that
patch didn't consider many of the items that overrode hover
event handling from c++, like TextArea and TextField;
they too need to ignore hover events, to not stop propagation -
it's not enough to only do it in the base class.

This patch fixes the regression that some controls
and items were blocking propagation compared to Qt 5.15.

Fixes: QTBUG-104537
Pick-to: 6.4 6.3 6.2
Change-Id: Ie047da6ac7d5be5ea6fd52d5a5446787df6d10f5
Reviewed-by: Shawn Rutledge

Let Controls inherit palettes and fonts from parents

2022-07-08T07:22:05+00:00

The Item's palette property and Control's font property returns the
resolved value; its resolveMask is inherited from parent object, when
the return value is used in the qml. For example:

ApplicationWindow {
    id: window
    palette { window: "blue"; windowText: "blue" }

    Control {
        id: control
    }

    Button {
        onClicked: {
            control.palette.window = "red"
            window.palette.windowText = "red"
            console.log(control.palette.windowText)
        }
    }
}

In Button.onClicked, `control.palette` is the `resolvedPalette`
of Control, it's resolveMask is not 0. Next, the new value is assigned
to the control, then the control's "requestedPalette" will change to the
new value, and it's resolveMask also is not 0. Next,
`window.palette.windowText = "red"` changes the `windowText` palette for
the window; QQuickPaletteColorProvider::inheritPalette() will be called.
Because the resolveMask of `requestedPalette` is equal to the new
palette, the control will not inherit any colors from its parent. So
`console.log(control.palette.windowText)` was printing `qml: #0000ff`,
but the right result is `qml: #ff0000`.

When PaletteProvider is missing the inherited struct, fallbackPalette is
now used as parentPalette.

[ChangeLog][Controls] Controls now inherit palette and font from parents.

Done-With: Volker Hilsheimer 
Done-With: yeshanshan 
Done-With: Shawn Rutledge 
Pick-to: 6.4
Fixes: QTBUG-101480
Change-Id: Ibe400f647512331352bf34dee42f908fb7a8d914
Reviewed-by: Shawn Rutledge 
Reviewed-by: Oliver Eftevaag

Fix TextEdit/TextArea mouse cursor shape handling logic

2022-06-16T10:49:15+00:00

Previously IBeamCursor was wrongly shown in case when TextEdit
was readonly and not selectable by mouse. Now ArrowCursor will be shown
in such case. Additionally removed own mouse cursor shape handling logic
in TextArea, so it will be unified now with derived logic from TextEdit.
This is a change from 23f78b6b76fb9350a472485e34857e1a4842e5d3:
we no longer attempt to restore a cursor that was set via setCursor().

[ChangeLog][QtQuick][TextEdit] TextEdit and TextArea now set their own
mouse cursors more consistently, but without regard for any external
call to setCursor().

Fixes: QTBUG-104089
Pick-to: 6.3 6.4
Change-Id: Iba4e0cb55d555b0f360d7856346ff9e8393b9e1e
Reviewed-by: Shawn Rutledge

Use SPDX license identifiers

2022-06-11T06:05:15+00:00

Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge

TextArea: make clip node wider to accommodate cursor when right-aligned

2022-05-03T18:18:45+00:00

TextArea { horizontalAlignment:TextEdit.AlignRight } draws its cursor
past the right edge of the text itself.  1 px seems to be enough.

Fixes: QTBUG-84280
Pick-to: 6.2 6.3
Change-Id: I7aa58249f97c7f25a7caf3adc01e1a46917508c9
Reviewed-by: Mitch Curtis

QuickTemplates2: includemocs

2022-04-29T04:40:07+00:00

Including moc files directly into their classes' TU tends to improve
codegen and enables extended compiler warnings, e.g. about unused
private functions or fields.

Pick-to: 6.3 6.2 5.15
Task-number: QTBUG-102948
Change-Id: Iac3f0f54ecd734d8558645094f6373dd9335852b
Reviewed-by: Mårten Nordheim

Fix TextArea/TextField not using IBeamCursor when text can be selected

2022-01-24T05:53:56+00:00

Previously, TextArea and TextField would switch to
ArrowCursor when readOnly was true, even if selectByMouse was also true.

Pick-to: 6.2 6.3
Fixes: QTBUG-99604
Change-Id: I3ddeb510f59bd6cf403641bb7ffd0b66668ca3c2
Reviewed-by: Mitch Curtis

Don't crash when pasting text into TextArea

2022-01-07T16:39:11+00:00

If QQuickTextAreaPrivate::ensureCursorVisible() calls
QQuickFlickable::setContentY() while the Flickable does not yet know the
extents of its new content, it caused a crash when
QQuickScrollBarPrivate::visualArea() called qBound(0, 1, -something).
We need to wait until Flickable knows it can scroll that far. It turns
out ensureCursorVisible() is called several times anyway, so it's OK to
skip the calls that would ask the Flickable to scroll out-of-bounds.

Pick-to: 6.3
Task-number: QTBUG-99582
Change-Id: Ifb374a81591df49d3c571f55cb3076a78a808918
Reviewed-by: Mitch Curtis