qt/qtdeclarative.git/src/quicktestutils/qml/qmlutils.cpp, branch wip/nativemenus Qt Declarative (Quick 2) Correct license for test files 2024-04-11T13:15:17+00:00 Lucie Gérard lucie.gerard@qt.io 2024-04-05T11:01:18+00:00 85b7937b70ee7d2fbf02e7bdff12a01cf12e084c According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Task-number: QTBUG-121787 Pick-to: 6.7 Change-Id: Ib1dea3bf095aeb06e33a64db61a8c01219d12345 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io> 
According to QUIP-18 [1], all test files should be
LicenseRef-Qt-Commercial OR GPL-3.0-only

[1]: https://contribute.qt-project.org/quips/18

Task-number: QTBUG-121787
Pick-to: 6.7
Change-Id: Ib1dea3bf095aeb06e33a64db61a8c01219d12345
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Long live incremental garbage collection in QML! 2023-12-20T07:38:26+00:00 Fabian Kosmale fabian.kosmale@qt.io 2023-11-21T18:36:26+00:00 b9d37a328ba09bcb2a7a95b5778cb8c63d0ace26 The design of the garbage collector is described in src/qml/memory/design.md. The gc and gcdone test helpers are adjusted to drive the gc to completion, even when in incremental mode. Parts of tst_qv4mm and tst_qqmlqt need to run with the incremental gc disabled, as they call gc inside QML and assumes that the GC finishes before returning. Initial-patch-by: Rafal Chomentowski <rafal.chomentowski@ge.com> Task-number: QTBUG-119274 Change-Id: I1d94f41bc7a434fad67de0fd46454b6db285f2eb Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
The design of the garbage collector is described in
src/qml/memory/design.md.

The gc and gcdone test helpers are adjusted to drive the gc to
completion, even when in incremental mode.

Parts of tst_qv4mm and tst_qqmlqt need to run with the incremental gc
disabled, as they call gc inside QML and assumes that the GC finishes
before returning.

Initial-patch-by: Rafal Chomentowski <rafal.chomentowski@ge.com>
Task-number: QTBUG-119274
Change-Id: I1d94f41bc7a434fad67de0fd46454b6db285f2eb
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Prepare tests for upcoming incremental gc 2023-11-22T21:40:39+00:00 Fabian Kosmale fabian.kosmale@qt.io 2023-10-19T08:05:28+00:00 7461ae2a946321576f6a495df33e3a17639e246c This commit: - Introduces helper functions gcDone and gc. gcDone simply returns true as the gc is currently not incremental. gc is a helper method which has been copied into various tests already, which runs the garbage collections and sends events to clean up objects scheduled for deletion. The new helpers are placed in qmlutils.cpp. - It adds a flag to gc which allows not sending the posted events. That allows using gc in more places, while highlighting the fact that we don't want to process events at this point. This will also help upcoming changes to the incremental gc, which by default will use the event loop to drive the gc processing - It moves some gc calls from QML to C++ – this again will help later to ensure that the gc actually has completed As a driveby, the logging rules early in tst_qv4mm are reset earlier. Task-number: QTBUG-119274 Change-Id: I75d6ffcb3aa459b020e8257155faa91c39653d43 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
This commit:
- Introduces helper functions gcDone and gc. gcDone simply returns true
  as the gc is currently not incremental. gc is a helper method which
  has been copied into various tests already, which runs the garbage
  collections and sends events to clean up objects scheduled for
  deletion. The new helpers are placed in qmlutils.cpp.
- It adds a flag to gc which allows not sending the posted events. That
  allows using gc in more places, while highlighting the fact that we
  don't want to process events at this point. This will also help
  upcoming changes to the incremental gc, which by default will use the
  event loop to drive the gc processing
- It moves some gc calls from QML to C++ – this again will help later to
  ensure that the gc actually has completed

As a driveby, the logging rules early in tst_qv4mm are reset earlier.

Task-number: QTBUG-119274
Change-Id: I75d6ffcb3aa459b020e8257155faa91c39653d43
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
QuickTestUtils: Make 'data' subdir configurable 2022-09-07T14:57:00+00:00 Ulf Hermann ulf.hermann@qt.io 2022-09-02T10:55:39+00:00 5cda89ce030ff5fbc9e95be1b9ca74adb401a9d7 tst_ecmascripttests wants to call it "test262". Task-number: QTBUG-100242 Change-Id: I978171a85fe6ade1cc40129db42ef9a5177fe90f Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> 
tst_ecmascripttests wants to call it "test262".

Task-number: QTBUG-100242
Change-Id: I978171a85fe6ade1cc40129db42ef9a5177fe90f
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Add convenience API for making QQmlDataTest-based tests fail on warnings 2022-07-05T06:34:37+00:00 Mitch Curtis mitch.curtis@qt.io 2022-06-07T02:23:31+00:00 234afb5502ab20b4f58ddd9b01a4245330a7e5a4 After this patch, if a QQmlDataTest-derived class passes FailOnWarningsPolicy::FailOnWarnings to the base constructor, any non-empty warning encountered by that test will result in a test failure. This avoids the need to duplicate the catch-all regex in tests that want to fail on warnings. The goal is to gradually enable failure-on-warnings over time. Leave comments and explicitly pass DoNotFailOnWarnings for tests that should never fail on warnings. Task-number: QTBUG-98718 Pick-to: 6.2 6.3 6.4 Change-Id: I4b647d93a0f28ac891c4bdb19ef74569f2918e8f Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
After this patch, if a QQmlDataTest-derived class passes
FailOnWarningsPolicy::FailOnWarnings to the base constructor, any
non-empty warning encountered by that test will result in a test
failure.

This avoids the need to duplicate the catch-all regex in tests that
want to fail on warnings.

The goal is to gradually enable failure-on-warnings over time.

Leave comments and explicitly pass DoNotFailOnWarnings for tests that
should never fail on warnings.

Task-number: QTBUG-98718
Pick-to: 6.2 6.3 6.4
Change-Id: I4b647d93a0f28ac891c4bdb19ef74569f2918e8f
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
QQmlDataTest: fix dataDirectoryUrl generation for paths in qrc 2022-04-29T07:47:43+00:00 Ivan Solovev ivan.solovev@qt.io 2022-04-27T13:40:48+00:00 0f9abd63b9093f7f9878be697dbda7813201ffcc When the data directory is located in qrc (like on Android), the data directory url was generated incorrectly, missing the last '/'. As a result QQmlDataTest::dataDirectoryUrl().resolved("something") call was providing incorrect results. This patch fixes it, which allows to unblacklist tst_qqmlqt::resolvedUrl() for Android. Task-number: QTBUG-100014 Pick-to: 6.3 6.2 Change-Id: Id336a698b493edaa6e2ab7d36efbbef1f5acd1d6 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
When the data directory is located in qrc (like on Android), the data
directory url was generated incorrectly, missing the last '/'.
As a result QQmlDataTest::dataDirectoryUrl().resolved("something") call
was providing incorrect results.
This patch fixes it, which allows to unblacklist
tst_qqmlqt::resolvedUrl() for Android.

Task-number: QTBUG-100014
Pick-to: 6.3 6.2
Change-Id: Id336a698b493edaa6e2ab7d36efbbef1f5acd1d6
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
QuickTestUtilsPrivate: includemocs 2022-04-29T04:39:13+00:00 Marc Mutz marc.mutz@qt.io 2022-04-28T14:10:13+00:00 3c51c8bbeb1c819f856b4abebb50877ed284b802 Including moc files directly into their classes' TU tends to improve codegen and enables extended compiler warnings, e.g. about unused private functions or fields. Pick-to: 6.3 6.2 5.15 Task-number: QTBUG-102948 Change-Id: I3c9d74e94b0fbbf1e5e9d59522f400485c959cb5 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Including moc files directly into their classes' TU tends to improve
codegen and enables extended compiler warnings, e.g. about unused
private functions or fields.

Pick-to: 6.3 6.2 5.15
Task-number: QTBUG-102948
Change-Id: I3c9d74e94b0fbbf1e5e9d59522f400485c959cb5
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
QQmlDataTest: Use custom cache directory and clean it up 2021-11-26T14:57:05+00:00 Fabian Kosmale fabian.kosmale@qt.io 2021-11-23T13:57:59+00:00 716aa788188dc48aed0a24ed012976407cc9e800 This should help with tests failing due to stale cachegen files. Task-number: QTBUG-98404 Change-Id: I9f9846f30e1c0e9335fc15fbfe8689c9a4f5d60b Reviewed-by: Mitch Curtis <mitch.curtis@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
This should help with tests failing due to stale cachegen files.

Task-number: QTBUG-98404
Change-Id: I9f9846f30e1c0e9335fc15fbfe8689c9a4f5d60b
Reviewed-by: Mitch Curtis <mitch.curtis@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Replace 0 pointer constants with nullptr 2021-10-18T10:39:28+00:00 Allan Sandfeld Jensen allan.jensen@qt.io 2021-10-15T14:09:09+00:00 72c3befaa24e7e6021898061b5bc5389554e7126 Replaced in most common patterns. Change-Id: Idcaff1f2e915f29922702d3600a2e5f1e2418a7a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Replaced in most common patterns.

Change-Id: Idcaff1f2e915f29922702d3600a2e5f1e2418a7a
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>