This reverts commit fb654eed74ac94807a8bba22f0b4b17c4b37fd13. Reason for revert: Documents without imports are valid Change-Id: I074e2ec573a4df428fb98573f52bdd93d6f6e279 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Our documentation claims imports are non-optional. This is not actual true. The parser is happy with such files and the compiler can even generate C++ code for them. This can work in simple cases because the QML module is always imported even when not explicitly asked by the user. Therefore, types such as QtObject are still available. However, this is not the case of most types and we want to point our users to the likely source of their issues instead of showing them more cryptic errors that result from the missing imports. Note that Parser::parse() still cannot return false on files with no imports, as that breaks qmlls. We want to accept such files and show diagnostics instead of nothing. Change-Id: Iffc2c628e681ae576d7b4f0bd309908044805616 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Move the warning from the QDeferredFactory<QQmlJSScope> to the LinterVisitor. Adapt a test to expect the warning only on the singleton file, instead of the previous behavior of seeing the warnings on all qml files importing the QML module with the faulty singleton. Remove the test files that imported the faulty QML Module. Set the singleton flag on QQmlJSScope in the importer based on the singleton entry in the qmldir instead of using the singleton pragma value. This mimics the way the QML Engine ignores the singleton pragma value. Move m_rootIsSingleton from QQmlJSImportVisitor to LinterVisitor now that its unused in QQmlJSImportVisitor. Change-Id: I398738c816fbd273c51626954860a724b3110990 Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
Move the file selector warning from QQmlJSImporter to LinterVisitor, as the importer can't access the fields of scopes to check if file-selected scopes are compatible to their original scopes, while the LinterVisitor can. Use opt-in 'import-file-selector' warning category to warn on types that are file-selected but "compatible", and use opt-out 'import' category to warn on incompatible file-selected types. This changes the way we warn on file selected components. Previously, we would warn about all file selected components in an imported module, even if the QML file was not part of the QML module with the file-selected QML components. Also, we need to disable the "TolerateFileSelectors" flag during module linting so that we still warn about file selected files during module linting (we don't seem to currently run the import visitor when doing module linting). Now, we only warn in the actually file-selected QML components, so if we have: * Toolbar.qml * Broken.qml * +Material/ToolBar.qml * +Material/Broken.qml, for example, then qmllint will warn in * ToolBar.qml and * +Material/ToolBar.qml about ToolBar being file selected or potentially compatible. We don't complain about Broken.qml. Similarly, qmllint wil complain on the Broken.qml files about Broken using file selectors without mentioning the unrelated ToolBar.qml Support file selected variants in QQmlJS::ContextualTypes, and separate them from the actual types. Use the TolerateFileSelectors flag in QQmlJSImporter to keep the previous way of warning during compilation. Pick-to: 6.11 Fixes: QTBUG-145074 Change-Id: I492cfc71818c3a3f83e50e89152f3d0ee71a0283 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Don't warn in the importer on types where qqmljsimportvisitor didn't run yet. Those types are marked with a "$InProcess$" base type, and don't contain any information on their base type, methods, properties, etc, and therefore would always fail the heuristic. Pick-to: 6.11 Task-number: QTBUG-145074 Change-Id: Ic0646ac2b492a3cf0dbbea33d72d62712cf4964e Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
The base case is fixed. The more complex case is not and is marked by a QEXPECT_FAIL. Task-number: QTBUG-117786 Change-Id: I25ca3c6dc57fb4f0e71615a996e1a455fa264dd3 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
The suggested fix to a warning may require multiple document edits to properly fix the issue. Imagine an unqualified lookup across a component boundary. One of the fixes the user should be able to choose from is to qualify the lookup by adding the id _and_ set 'pragma ComponentBehavior: Bound'. This fix requires editing the document in two different places. To this end, FixSuggestion no longer holds a single replacement string directly but instead holds a list of, newly introduced, DocumentEdit. Note that FixSuggestion itself still keeps a location as well. This is intended to point out the location of the warning to the user, which may differ from the places where the fixes are applied. And, this is also needed in case we need to warn and suggest a fix but cannot do it automatically for the user. The fix suggesting to change 'new Array(1, 2)' into '[1, 2]' was updated to use the new multiple edits, simplifying the logic. The output of qmllint was updated to communicate the edits associated with a fix to the user. The json format was also updated. The qmllint integration in qmlls was also updated. Testing in creator shows that multiple edits can be applied correctly for a single fix. The QQmlSA API was also updated to include a DocumentEdit of its own and to update FixSuggestion as a consequence. QQmlSA is still in tech preview. Change-Id: Ifedb9a50329f0f3e9e59a74981a51e0daab52ae9 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Add a missing import to avoid a missing type warning. Pick-to: 6.11 Change-Id: I58476661c27e136f47be401cc354abc8940e7d22 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
The QML runtime uses precedences to import types, types imported via qmldir's import are less relevant than types with the same name imported via a QML `import ...` statement, for example. Mimic the precedence from the runtime in the tooling (but make the default 1, so that inline components, who should always be considered first, are 0 and don't need special casing), and increase the precedence during imports when importing QML module dependencies. Force users of QQmlJSImporter to specify a precedence, and provide an enum with default precedence values. QQmlJS::ContextualTypes only replaces types with the same name if they have the same or higher precedence, therefore only keeping types in the QHash that the QML runtime would select at runtime. Add new ContextualType type that contains the precedence, and inherits ImportedScope<QQmlJSScope::ConstPtr> to not change all the users that expect a ImportedScope. Only the QQmlJSImporter needs the precedence, the other users don't care about the precedence. Remove ContextualTypes::addTypes(&&) that didn't make use of the temporary argument anymore, and update the names accordingly to the preference. Pick-to: 6.11 6.10 6.8 Fixes: QTBUG-132452 Change-Id: Id83cfdd0b9b293b00c7459cc397e307e91590ded Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
We don't use the attribute so far, but we should certainly welcome its usage. Pick-to: 6.11 6.10 6.8 Fixes: QTBUG-144585 Change-Id: Iaa69c9401d411a4ad986d4c46ace0bad049b9881 Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>