When QAbstractItemModel::data() returns an invalid QVariant (representing 'undefined' in JS) for a role bound to a typed property like 'required property string foo', the property-to-property binding's write was silently failing. This happened because writeValueProperty() only uses QMetaType conversions which cannot convert an invalid QVariant to a QString. The property kept its old value, and subsequent valid writes of the same value would not trigger change signals. Update QQmlPropertyToUnbindablePropertyBinding::update() to perform proper type coercion using metaTypeToJS() and metaTypeFromJS(). Pick-to: 6.11 Fixes: QTBUG-145016 Change-Id: I8421e813ddde50d4c252907045448b22a36a0a70 Reviewed-by: Olivier De Cannière <olivier.decanniere@qt.io>
Pick-to: 6.11 6.10 Task-number: QTBUG-116296 Change-Id: Icc82fbf1bda7ec940940171b5f7ed786e00a274c Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Since QVector is just an alias, let's finally do what we could have done for Qt 6.0. Pick-to: 6.11 Change-Id: Ia9dbc8ecf4f099339cf7639acb22c14b24fa680b Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
We need this in Binding, too, and extracting this part of the code for better unit testing is arguably a good idea anyway. Task-number: QTBUG-140858 Pick-to: 6.10 6.8 Change-Id: I74f7a4f022068b9f599cf55433b5e337bc002178 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Returning an invalid QVariant from toVariant() is not helpful. We can't produce a QQmlListReference in that case because there is no object, but a QObjectList works just fine. Writing to list properties via the metaobject is very much supported. We can easily implement it using the same technique we use for reading. Finally, to get the signal counts right, we also need to compare the lists before assignment when taking the QQmlProperty code path. Pick-to: 6.10 6.8 Fixes: QTBUG-140690 Change-Id: I09d6412f3f2ec86144810f47d0d620b63dfcd280 Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
It's dangerous since you can't use it for derived classes. Instead, provide a factory function. Make it possible to specialize the QQmlElement ctor so that we can plug in the two-argument QQmlPropertyMap ctor when someone explicitly registers QQmlPropertyMap as creatable type (such as tst_qqmlpropertymap does). Fixes: QTBUG-140554 Change-Id: I264156ae27e5e234daad47fec3e0333f3ea89f4a Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Make debugging of failing tests less painful. The tests that had to be changed as a result are listed in the comments of the linked task. Fixes: QTBUG-138662 Task-number: QTBUG-81979 Change-Id: Iee50f2d4f2160e3e9bc2c7985925583fad810811 Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
When we introduced value type lists, we didn't adjust the QQmlProperty code which assumed that any list property could be represented as QQmlListProperty. This was of course no longer the case, and attempting to use it with such a property would result in UB, and most likely in crashes. Fix this by detecting what kind of list we are dealing with. Pick-to: 6.9 6.8 6.5 Fixes: QTBUG-136735 Change-Id: I1e4531da3e5f26994809f02d630820541849691c Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
We need to retrieve the object from the current context, not from the innermost one. Amends commit 21f15ede606df028479335c64c333db5fb1bb3f7 Pick-to: 6.9 6.8 6.5 Fixes: QTBUG-134778 Change-Id: I1abc24dfdbb1c2f0d61a2848ad55e441cdda54a9 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
Alias property signals were only connected when their corresponding signal handlers were explicitly defined in QML. This approach missed cases where signal handlers are created and connected in C++ code, causing alias property changes to fail to emit their signals. Fixes: QTBUG-120951 Change-Id: Ia84b078795e9c89668f916de92c1be41f07b6694 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>