qt/qtdeclarative.git/tests/auto/quick/qquickitemlayer/tst_qquickitemlayer.cpp, branch dev Qt Declarative (Quick 2) Correct license for test files 2024-02-27T09:32:21+00:00 Lucie Gérard lucie.gerard@qt.io 2024-02-22T14:51:16+00:00 9c5fc883881799fa28cf74535351e76dcea10a0a According to QUIP-18 [1], all test files should be LicenseRef-Qt-Commercial OR GPL-3.0-only [1]: https://contribute.qt-project.org/quips/18 Pick-to: 6.7 Task-number: QTBUG-121787 Change-Id: I26d72e8de04d4c7c57b3b7838af5d033265de5ba Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> Reviewed-by: Kai Köhne <kai.koehne@qt.io> Reviewed-by: Ulf Hermann <ulf.hermann@qt.io> 
According to QUIP-18 [1], all test files should be
LicenseRef-Qt-Commercial OR GPL-3.0-only

[1]: https://contribute.qt-project.org/quips/18

Pick-to: 6.7
Task-number: QTBUG-121787
Change-Id: I26d72e8de04d4c7c57b3b7838af5d033265de5ba
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Reviewed-by: Kai Köhne <kai.koehne@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Ensure that when an item resizes, its layer resizes immediately 2022-06-30T18:26:21+00:00 Shawn Rutledge shawn.rutledge@qt.io 2022-06-29T15:33:01+00:00 b0fc5287b8378e0be13765e2f8dc90aa938a25fb geometryChange() notifies QQuickItemLayer::updateGeometry() to update its internal bounds; at that moment, QQuickImagePrivate::paintedHeight has not yet been updated, so the QQuickImage::boundingRect() override returns the old size. It gets updated in updatePaintedGeometry(); but until then, it's better to use QQuickItem::boundingRect() without polymorphism, because that simply returns the item width and height. An alternative would be to use clipRect(), as it was before 9b62f4c27ac3fb3dc563c7f4657094c14d752bac; but that is more complex now: in case ItemObservesViewport is set, we would need to worry about whether it's more appropriate to have the item's layer the same size as the viewport (and update it more often during scrolling), or the same size as the item, as it was before. Amends 9b62f4c27ac3fb3dc563c7f4657094c14d752bac Fixes: QTBUG-104442 Fixes: QTBUG-104536 Pick-to: 6.4 6.3 Change-Id: I51e25402d358a57cea9fd718ee8fe759b572b1a2 Reviewed-by: Igor Bugaev <freedbrt@gmail.com> Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io> 
geometryChange() notifies QQuickItemLayer::updateGeometry() to update
its internal bounds; at that moment, QQuickImagePrivate::paintedHeight
has not yet been updated, so the QQuickImage::boundingRect() override
returns the old size. It gets updated in updatePaintedGeometry(); but
until then, it's better to use QQuickItem::boundingRect() without
polymorphism, because that simply returns the item width and height.
An alternative would be to use clipRect(), as it was before
9b62f4c27ac3fb3dc563c7f4657094c14d752bac; but that is more complex now:
in case ItemObservesViewport is set, we would need to worry about
whether it's more appropriate to have the item's layer the same size
as the viewport (and update it more often during scrolling), or the
same size as the item, as it was before.

Amends 9b62f4c27ac3fb3dc563c7f4657094c14d752bac

Fixes: QTBUG-104442
Fixes: QTBUG-104536
Pick-to: 6.4 6.3
Change-Id: I51e25402d358a57cea9fd718ee8fe759b572b1a2
Reviewed-by: Igor Bugaev <freedbrt@gmail.com>
Reviewed-by: Laszlo Agocs <laszlo.agocs@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Add offscreen platform skip where missing in tst_qquickitemlayer 2022-01-23T17:41:17+00:00 Laszlo Agocs laszlo.agocs@qt.io 2022-01-20T12:48:47+00:00 3fdd64e6e75ebfec82b6824801ebf11b6fd3aac3 Anything that calls runTest() can very well have the skip, given runTest() uses grabWindow(). Task-number: QTBUG-100046 Change-Id: I5c15a5dba65c98fca757dd5a11fcf34cb7b4c775 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Anything that calls runTest() can very well have the skip, given
runTest() uses grabWindow().

Task-number: QTBUG-100046
Change-Id: I5c15a5dba65c98fca757dd5a11fcf34cb7b4c775
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Consolidate test helpers into private libraries 2021-09-13T19:17:04+00:00 Mitch Curtis mitch.curtis@qt.io 2021-08-06T10:27:35+00:00 e310dadef779b28845b41fb091634cd001cda9de Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Previously each test would include and build sources from the shared
folder. Now we make those sources a library, build it once, then have
each test link to it instead.

We also take the opportunity to move some helpers that qtquickcontrols2
had added into the quicktestutils library where it makes sense, and
for the helpers that don't make sense to be there, move them into
quickcontrolstestutils.

We add the libraries to src/ so that they are internal modules built as
part of Qt, rather than tests. That way we can use them in a standalone
test outside of qtdeclarative.

Task-number: QTBUG-95621
Pick-to: 6.2
Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
tst_qquickitemlayer: skip tests when running on offscreen platform 2021-02-05T11:44:51+00:00 Samuli Piippo samuli.piippo@qt.io 2021-02-02T15:03:15+00:00 34477bdbb00b351fe254fc42155e876d06b0c994 More tests fail on offscreen platform when tested on QEMU on CI. Pick-to: 6.1 Task-number: QTBUG-63185 Change-Id: I293e9b32078bf2567fbb9773cedf6777ad182a69 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> 
More tests fail on offscreen platform when tested on QEMU on CI.

Pick-to: 6.1
Task-number: QTBUG-63185
Change-Id: I293e9b32078bf2567fbb9773cedf6777ad182a69
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
tests: Port qquickitemlayer and remove direct GL checks 2020-10-16T14:32:54+00:00 Laszlo Agocs laszlo.agocs@qt.io 2020-10-15T14:48:47+00:00 51a66f473286e4c374b4441b8da11f31151f0496 Change-Id: I7362ae0dcbc67005c09df5c5c704912d10a74827 Reviewed-by: Andy Nichols <andy.nichols@qt.io> 
Change-Id: I7362ae0dcbc67005c09df5c5c704912d10a74827
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Add missing OpenGL check in qquickitemlayer/layerEffect 2020-05-11T06:43:16+00:00 Laszlo Agocs laszlo.agocs@qt.io 2020-05-08T11:51:50+00:00 4a38c24ef64f5affb81d0ef0036014a0117eca3d Other ShaderEffect-related cases in the same test already test for using direct OpenGL. Add the same check to the layerEffect case too. The proper migration (away from the inline GLSL code) is left as a future exercise. Change-Id: I4b5eb054709fd60adda8f1d2d8f310eb3bddf960 Reviewed-by: Jonas Karlsson <jonas.karlsson@qt.io> Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io> 
Other ShaderEffect-related cases in the same test already test for using
direct OpenGL. Add the same check to the layerEffect case too.

The proper migration (away from the inline GLSL code) is left as a future
exercise.

Change-Id: I4b5eb054709fd60adda8f1d2d8f310eb3bddf960
Reviewed-by: Jonas Karlsson <jonas.karlsson@qt.io>
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
Merge remote-tracking branch 'origin/5.15' into dev 2020-03-20T00:00:59+00:00 Qt Forward Merge Bot qt_forward_merge_bot@qt-project.org 2020-03-20T00:00:59+00:00 1eef06e64fe91dc1f2148477fb932b293fba0312 Change-Id: I6f320ea43b5837444226228c118e57c4bda8702a 
Change-Id: I6f320ea43b5837444226228c118e57c4bda8702a
Fix copy-pasted typo minimimal -> minimal 2020-03-18T21:03:50+00:00 Allan Sandfeld Jensen allan.jensen@qt.io 2020-03-18T13:24:29+00:00 056016a1d88e6d03efed871b3aa62a633c07872b Change-Id: I4afef3fdbb9e3c3ec20ba5d00307992131b9ba3e Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> 
Change-Id: I4afef3fdbb9e3c3ec20ba5d00307992131b9ba3e
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>