qt/qtdeclarative.git/tests/auto/quick/qquickshape/tst_qquickshape.cpp, branch 6.5 Qt Declarative (Quick 2) Fix division by zero in QQuickSvgParser 2025-04-23T07:01:04+00:00 Mitch Curtis mitch.curtis@qt.io 2025-04-01T05:25:37+00:00 98edc631a960bca758dde79ec5e63496eaed1b55 df97b6b2de6282bd6422f1e531a42475dadc980d in Qt Base added an assert which detected this. This patch adds an early return if we're about to divide by zero, similar to 7ca1222296a9650f24979df57cc2c974a7e571ed. It also amends that patch to move the start point == end point check to pathArc(), since it's called from more places. Fixes: QTBUG-135387 Pick-to: 5.15 Change-Id: If9c5655d5e736825e98d3e93201bf889a1785e49 Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io> (cherry picked from commit 8d597bea22728268beff583a79e2005b1df423bf) Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io> (cherry picked from commit 503cbb4ad07a06941761607f46964c9540595225) Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io> (cherry picked from commit 5482f67da7705ede34c987c61ee45e3221d7b2b7) 
df97b6b2de6282bd6422f1e531a42475dadc980d in Qt Base added an
assert which detected this.

This patch adds an early return if we're about to divide by zero,
similar to 7ca1222296a9650f24979df57cc2c974a7e571ed. It also
amends that patch to move the start point == end point check
to pathArc(), since it's called from more places.

Fixes: QTBUG-135387
Pick-to: 5.15
Change-Id: If9c5655d5e736825e98d3e93201bf889a1785e49
Reviewed-by: Eskil Abrahamsen Blomfeldt <eskil.abrahamsen-blomfeldt@qt.io>
(cherry picked from commit 8d597bea22728268beff583a79e2005b1df423bf)
Reviewed-by: Eirik Aavitsland <eirik.aavitsland@qt.io>
(cherry picked from commit 503cbb4ad07a06941761607f46964c9540595225)
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
(cherry picked from commit 5482f67da7705ede34c987c61ee45e3221d7b2b7)
Port from container::count() and length() to size() 2022-10-07T21:38:48+00:00 Marc Mutz marc.mutz@qt.io 2022-10-05T05:29:16+00:00 958cd3ee1094a068b6d0ff27c73a4b3caff088ad This is a semantic patch using ClangTidyTransformator as in qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8: auto QtContainerClass = anyOf( expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o), expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o)); makeRule(cxxMemberCallExpr(on(QtContainerClass), callee(cxxMethodDecl(hasAnyName({"count", "length"), parameterCountIs(0))))), changeTo(cat(access(o, cat("size"), "()"))), cat("use 'size()' instead of 'count()/length()'")) a.k.a qt-port-to-std-compatible-api with config Scope: 'Container', with the extended set of container classes recognized. Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This is a semantic patch using ClangTidyTransformator as in
qtbase/df9d882d41b741fef7c5beeddb0abe9d904443d8:

  auto QtContainerClass = anyOf(
      expr(hasType(cxxRecordDecl(isSameOrDerivedFrom(hasAnyName(classes))))).bind(o),
      expr(hasType(namedDecl(hasAnyName(<classes>)))).bind(o));
  makeRule(cxxMemberCallExpr(on(QtContainerClass),
                             callee(cxxMethodDecl(hasAnyName({"count", "length"),
                                                  parameterCountIs(0))))),
           changeTo(cat(access(o, cat("size"), "()"))),
           cat("use 'size()' instead of 'count()/length()'"))

a.k.a qt-port-to-std-compatible-api with config Scope: 'Container',
with the extended set of container classes recognized.

Change-Id: Idb1f75dfe2323bd1d9e8b4d58d54f1b4b80c7ed7
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Use SPDX license identifiers 2022-06-11T06:05:15+00:00 Lucie Gérard lucie.gerard@qt.io 2022-05-13T13:12:05+00:00 0dc4fd240a2897c5c443a0ef6d84c416843e4938 Replace the current license disclaimer in files by a SPDX-License-Identifier. Files that have to be modified by hand are modified. License files are organized under LICENSES directory. Pick-to: 6.4 Task-number: QTBUG-67283 Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace the current license disclaimer in files by
a SPDX-License-Identifier.
Files that have to be modified by hand are modified.
License files are organized under LICENSES directory.

Pick-to: 6.4
Task-number: QTBUG-67283
Change-Id: I63563bbeb6f60f89d2c99660400dca7fab78a294
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Fix test file inclusion in tst_qquickshape 2022-05-03T08:06:26+00:00 Andreas Buhr andreas.buhr@qt.io 2022-05-02T13:52:11+00:00 8c217e4e20708ba5608cc8bfce9d8a358fbc122b Test file paths were generated using testFileUrl("foo").toLocalFile(). This does not work on Android. This patch fixes it. Pick-to: 6.2 6.3 Task-number: QTBUG-103094 Task-number: QTBUG-101865 Change-Id: I24c8f0f1965b652fe66b5902368d54241bfec565 Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io> Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> 
Test file paths were generated using testFileUrl("foo").toLocalFile().
This does not work on Android. This patch fixes it.

Pick-to: 6.2 6.3
Task-number: QTBUG-103094
Task-number: QTBUG-101865
Change-Id: I24c8f0f1965b652fe66b5902368d54241bfec565
Reviewed-by: Assam Boudjelthia <assam.boudjelthia@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Enable passing tests that were skipped on offscreen 2022-03-07T17:19:43+00:00 Volker Hilsheimer volker.hilsheimer@qt.io 2022-02-06T23:16:22+00:00 b1d0136192b7451788dee79c865dede02438f96e grabWindow is now implemented for the offscreen plugin, so a large number of tests relying on that functionality don't need to be skipped any longer. Change-Id: I85bfc9e4b327389055041b6187a54f88d9cf81d2 Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org> Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
grabWindow is now implemented for the offscreen plugin, so a large
number of tests relying on that functionality don't need to be skipped
any longer.

Change-Id: I85bfc9e4b327389055041b6187a54f88d9cf81d2
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Skip the shapes tests on offscreen platform 2022-01-23T17:41:18+00:00 Shawn Rutledge shawn.rutledge@qt.io 2022-01-21T09:52:48+00:00 5d2ffc03f89d092f46ae14e958bedf9fc441b7ec Replace QEXPECT_FAIL with QSKIP so that grabWindow can be fixed in the offscreen plugin without XPASS-failing tests in qtdeclarative. Task-number: QTBUG-99962 Pick-to: 6.3 Change-Id: I470061a324c963e09b9ebcb48daabdf8d960ff90 Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io> 
Replace QEXPECT_FAIL with QSKIP so that grabWindow can be fixed in the
offscreen plugin without XPASS-failing tests in qtdeclarative.

Task-number: QTBUG-99962
Pick-to: 6.3
Change-Id: I470061a324c963e09b9ebcb48daabdf8d960ff90
Reviewed-by: Shawn Rutledge <shawn.rutledge@qt.io>
Consolidate test helpers into private libraries 2021-09-13T19:17:04+00:00 Mitch Curtis mitch.curtis@qt.io 2021-08-06T10:27:35+00:00 e310dadef779b28845b41fb091634cd001cda9de Previously each test would include and build sources from the shared folder. Now we make those sources a library, build it once, then have each test link to it instead. We also take the opportunity to move some helpers that qtquickcontrols2 had added into the quicktestutils library where it makes sense, and for the helpers that don't make sense to be there, move them into quickcontrolstestutils. We add the libraries to src/ so that they are internal modules built as part of Qt, rather than tests. That way we can use them in a standalone test outside of qtdeclarative. Task-number: QTBUG-95621 Pick-to: 6.2 Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Previously each test would include and build sources from the shared
folder. Now we make those sources a library, build it once, then have
each test link to it instead.

We also take the opportunity to move some helpers that qtquickcontrols2
had added into the quicktestutils library where it makes sense, and
for the helpers that don't make sense to be there, move them into
quickcontrolstestutils.

We add the libraries to src/ so that they are internal modules built as
part of Qt, rather than tests. That way we can use them in a standalone
test outside of qtdeclarative.

Task-number: QTBUG-95621
Pick-to: 6.2
Change-Id: I0a2ab3976fdbff2e4414df7bdc0808f16453b80a
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Rename setSceneGraphBackend to setGraphicsApi 2020-06-22T14:10:52+00:00 Laszlo Agocs laszlo.agocs@qt.io 2020-06-22T11:00:03+00:00 4e266103ad8b75d71fb176a2f774faf71997123d ...and fix up the docs. The string-based setSceneGraphBackend() stays of course (the docs have been enhanced, however). The GraphicsApi enum-based overload is now renamed to setGraphicsApi(). Using the same name for both functions is a historical artifact, reflecting the evolution (5.0 - 5.8 - 5.14). In 6.0 we can give it a more appropriate name, since it does not have much to do with "backends" from the user's perspective. Change-Id: Id75dbf81f50a148797e5b5de9be4000153737473 Reviewed-by: Andy Nichols <andy.nichols@qt.io> 
...and fix up the docs.

The string-based setSceneGraphBackend() stays of course (the docs have
been enhanced, however). The GraphicsApi enum-based overload is now
renamed to setGraphicsApi().

Using the same name for both functions is a historical artifact, reflecting
the evolution (5.0 - 5.8 - 5.14). In 6.0 we can give it a more appropriate
name, since it does not have much to do with "backends" from the user's
perspective.

Change-Id: Id75dbf81f50a148797e5b5de9be4000153737473
Reviewed-by: Andy Nichols <andy.nichols@qt.io>
Fix copy-pasted typo minimimal -> minimal 2020-03-18T21:03:50+00:00 Allan Sandfeld Jensen allan.jensen@qt.io 2020-03-18T13:24:29+00:00 056016a1d88e6d03efed871b3aa62a633c07872b Change-Id: I4afef3fdbb9e3c3ec20ba5d00307992131b9ba3e Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io> 
Change-Id: I4afef3fdbb9e3c3ec20ba5d00307992131b9ba3e
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@qt.io>
PathMultiline: handle directly-bound QVector<QPolygonF> 2019-09-03T15:33:32+00:00 Shawn Rutledge shawn.rutledge@qt.io 2019-09-02T20:28:43+00:00 e81ff5732f7884c5c1d9efb1f63ac7ad0dabbcb5 The autotest in 811b15bd161d12e5c85e093f9f492a0c4fa278d6 only tested what happens if the vector of polygons is passed via a QVariant to the PathMultiline paths property. But the intention (as documented) was to literally support an object with Q_PROPERTY(QVector<QPolygonF> paths ...) and binding that paths property to PathMultiline.paths. In that case it appears in QQuickPathMultiline::setPaths() as a QVariant<QJSValue>, canConvert<QVector<QPolygonF>>() returns false, then canConvert<QVariantList>() returns true. Nevertheless each variant in the QVariantList is a QPolygonF, as expected. So we need another check to detect this case. Also added a test specifically for that. Fixes: QTBUG-77929 Change-Id: I84d0a45326d5f007b8ba3cc9bb1fbccf0345d812 Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io> 
The autotest in 811b15bd161d12e5c85e093f9f492a0c4fa278d6 only tested
what happens if the vector of polygons is passed via a QVariant to the
PathMultiline paths property.  But the intention (as documented) was to
literally support an object with Q_PROPERTY(QVector<QPolygonF> paths ...)
and binding that paths property to PathMultiline.paths.  In that case
it appears in QQuickPathMultiline::setPaths() as a QVariant<QJSValue>,
canConvert<QVector<QPolygonF>>() returns false, then
canConvert<QVariantList>() returns true.  Nevertheless each variant
in the QVariantList is a QPolygonF, as expected.  So we need another
check to detect this case.  Also added a test specifically for that.

Fixes: QTBUG-77929
Change-Id: I84d0a45326d5f007b8ba3cc9bb1fbccf0345d812
Reviewed-by: Paolo Angelelli <paolo.angelelli@qt.io>