qt/qtdeclarative.git/tests, branch 6.6.0

QQmlSA: Don't expose QQmlJS namespace

2023-09-23T06:07:08+00:00

QQmlSA is meant as the public namespace, QQmlJS is (at least currently)
completely internal. However, LoggerWarningID currently only existed in
QQmlJS.
Move it into QQmlSA, add some minimal class documentation and add a
typedef in QQmlJS (inside a private header) to avoid the need to modify
all users.

Change-Id: Icff860c92054ac810c6e15eb26090d38fbc2c965
Reviewed-by: Ulf Hermann 
(cherry picked from commit d77693a028ce4c0faffafb612b8f4881d38e99ac)
Reviewed-by: Qt Cherry-pick Bot 
(cherry picked from commit ba9d23d051d08a34318af452d0f78a55d20caad3)

TextEdit/TextArea: don't deselect on release if IM just selected text

2023-09-12T21:46:13+00:00

After 90d3fac73a10b9363fd34e6757cc730d7a0c086c we got a regression on
Android at least: if you long-press to select a word, selection handles
appear; then when you release, there's a QTouchEvent which is left
unhandled, and then a synth-mouse release. In this case, we don't want
to call setCursorPosition(), because it de-selects the selection that
was just made by the input method.

But the intention was to be able to set the cursor position (and also
deselect text) by tapping on a touchscreen on other platforms that don't
have text selection handles. (It seems to be consistent with Android
behavior: there you can also deselect and move the cursor by simply
tapping.) To avoid changing that behavior, we now set a flag if we get
a mouse press and then a QInputMethodEvent with a Selection attribute,
indicating that text got selected that way; and in that case, don't
call setCursorPosition().

Fixes: QTBUG-115004
Pick-to: 6.5
Change-Id: I7e362da584f6e1cb1509dcc0eff024b291ef5df3
Reviewed-by: Santhosh Kumar 
Reviewed-by: Rami Potinkara 
(cherry picked from commit c1d5e46ea79762bfcc070fabbf10ff7fdf184e01)
Reviewed-by: Qt Cherry-pick Bot

Loader: re-set ItemObservesViewport flag on child if already set

2023-09-12T19:03:21+00:00

When QQuickLoaderPrivate::load() loads a Text item, its ctor calls
QQuickTextPrivate::init(), which calls setFlag(ItemObservesViewport).
QQuickItem::setFlag() tries to go up the parent hierarchy to get
subtreeTransformChangedEnabled turned on; but at that time, the Text
does not yet have a parent.

If a Flickable contains a Loader that loads a Text with large content,
QQuickTextPrivate::transformChanged() needs to get called during
scrolling. Loader is not interested in these notifications for itself;
so its parent's QQuickItemPrivate::transformChanged() detects that and
turns off subtreeTransformChangedEnabled. After the child is loaded,
QQuickLoader::itemChange() detects that the child's ItemObservesViewport
is already set, and sets the same flag again. setFlag() doesn't have a
guard, so the parent traversal happens again, and
subtreeTransformChangedEnabled gets turned back on.

If a different child were loaded, and that child did not want the
notifications, the next QQuickItemPrivate::transformChanged()
would detect it. If the child changed its own flag later on (e.g.
because a small amount of text was replaced with a larger document,
exceeding QQUICKTEXT_LARGETEXT_THRESHOLD), QQuickItem::setFlag() would
be able to go up the parent chain at that time.

For the autotest, long.qml has about 15KB of text. Maybe it will
be reusable. At least it should compress well in git packfiles,
since we have this license text elsewhere.

Fixes: QTBUG-115687
Change-Id: I87b6a42f5735b8f9c2267f91a4112681da05de5d
Reviewed-by: Santhosh Kumar 
(cherry picked from commit 8c7c60fff37ea7bb7420d925e2f88e62764bf86b)
Reviewed-by: Volker Hilsheimer

qmljsimportvisitor: add warnings for lower case

2023-09-12T19:03:21+00:00

Replace an assert with a warning, and warn when qualified import names
start with a lower case letter. Add a test for that.

Also warn when using a qualified import with a name starting with a
lower case, so users can fix their mistake more easily.

Change-Id: Iff2b9148c5a36625baad70798e2efe006905e2a3
Reviewed-by: Ulf Hermann 
(cherry picked from commit eae7381b91192f6021e84f99be4d5c416aae9510)

Remove resize guards from qml tool

2023-09-12T19:03:21+00:00

Resize guards were prohibiting the initialization of the top level
item size to the window size in a qml script when executed with
the qml tool. This is usually fine because the window size is set
to the item size. However, if this is not possible (minimum window
size from the system, no explicit size on the item), the item has
a different size than the window. The item would only be adapted to
the window size after resizing the window.

This patch removes the resize guards to make the item always fill
the window on startup. The resize guard should hopefully not be needed;
the QQuickItem setters for width and height return early if it's
unchanged; QWindow::resize() does not emit changed signals if there
is not yet a platform window and width or height is unchanged;
and we hope all the overrides of QPlatformWindow::setGeometry()
will avoid making unnecessary changes. However the guards were added
in 8d9a7e47aaa03efe2d3eddfc9ac37d02a99affc7 and I don't remember
exactly why.

Adds the test tst_qml::itemAndWindowGeometry to check combinations of
--config, --qwindowgeometry and qml files whose root item has or doesn't
have its own dimensions, or changes its dimensions after being shown.

Done-with: Matthias Rauter 
Pick-to: 6.5
Fixes: QTBUG-114068
Fixes: QTBUG-116753
Change-Id: Ib972e0bfc25809441d378c53dabb60653314f5a6
Reviewed-by: Ulf Hermann 
Reviewed-by: Qt CI Bot 
(cherry picked from commit 05e0dc2a88e751e97573610fd483f79da3e78854)
Reviewed-by: Qt Cherry-pick Bot

QQmlSA::ScriptBindingKind: Turn into scoped enumeration

2023-09-09T06:07:20+00:00

and remove the Script_ prefix from its entries. This is more aligned
with Qt's namings conventions.

Change-Id: Ie97c2ce204b5532ab6bd6b136145f2a537175fbb
Reviewed-by: Ulf Hermann 
Reviewed-by: Semih Yavuz 
Reviewed-by: Olivier De Cannière 
(cherry picked from commit d12d7a901f856311fc532a6f728b6e96e539d6e5)
Reviewed-by: Sami Shalayel

convert threading example to manual tests

2023-09-08T20:30:52+00:00

The threading example used a LauncherList to combine
two different but related examples into one.

I've now separated both into a shared directory called
'threading'

Change-Id: Iee8898e61adcf69dc67157a1eff5f6ac019a39ca
Reviewed-by: Shawn Rutledge 
(cherry picked from commit 38373b81f37ccbf6ec66f43a70fe9622bbcc9593)
Reviewed-by: Qt Cherry-pick Bot

Windows native style: Mark ScrollBar as non-customizable

2023-09-08T20:30:40+00:00

Consequently, remove code that supported setting a non-native
contentItem.

Task-number: QTBUG-107771
Change-Id: I871156c567f85db6e1b8247dcc6c2ea6a350cd4d
Reviewed-by: Mitch Curtis 
(cherry picked from commit 901a8bf768abc3672e512b3f481b24ac0e1afb52)
Reviewed-by: Qt Cherry-pick Bot

Make accent palette role available to QML

2023-09-08T20:30:13+00:00

By adding it to ColorGroup. It was added to QPalette in
17c589df94a2245ee92d45839c2cba73566d7310 (6.6).

Fixes: QTBUG-116106
Change-Id: Ief38c131c5c7c01e02839235914f2917b9ba8255
Reviewed-by: Shawn Rutledge 
Reviewed-by: Ulf Hermann 
(cherry picked from commit b82af7b42db3c206ce7dd44e39304bf1166024f2)
Reviewed-by: Qt Cherry-pick Bot

QQmlProperty: Accept badly capitalized signal handler names

2023-09-08T07:53:04+00:00

... but warn about them. Apparently we did accept them prior to 6.4.

Fixes: QTBUG-116576
Change-Id: If890db85f5a8d71c0bcdfaf646ee9f01765a0b3c
Reviewed-by: Sami Shalayel 
(cherry picked from commit 2fc19f2c627802d26bd385a6c9cc1f6412852ee2)