qt/qtdeclarative.git/tools/shared/scopetree.cpp, branch dev Qt Declarative (Quick 2) Long live libQtQmlCompiler! 2020-10-05T12:58:32+00:00 Ulf Hermann ulf.hermann@qt.io 2020-10-01T10:40:01+00:00 767dd738d3de9306062707fe05d32c91ed755da3 Move all the code from tools/shared into src/qmlcompiler and build a static library from it so that we can re-use it in external tools. Change-Id: I7c8d8e59063dc7c711f4072f103a01095e6f5997 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Move all the code from tools/shared into src/qmlcompiler and build a
static library from it so that we can re-use it in external tools.

Change-Id: I7c8d8e59063dc7c711f4072f103a01095e6f5997
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Remove member access chains from ScopeTree 2020-10-02T13:33:23+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-30T13:31:43+00:00 b2e1183cb7f4f552bb4409172f82327111f754bb What we need there is a proper type inference. This should be added separately. For now, keep the member access chains local in qmllint and don't pollute ScopeTree with them. Change-Id: I9f50aa4e54b285bd93e7bd4cd17797509df0c168 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
What we need there is a proper type inference. This should be added
separately. For now, keep the member access chains local in qmllint and
don't pollute ScopeTree with them.

Change-Id: I9f50aa4e54b285bd93e7bd4cd17797509df0c168
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Remove ScopeTree::m_unmatchedSignalHandlers 2020-10-02T13:33:17+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-30T13:03:04+00:00 65b6365ffbde369894f7af1ed735ea34a584d357 Rather, immediately output the warnings when we encounter them. Change-Id: I4bd1a5491a47cb0232bfdd4e325f8f122593aa39 Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io> Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Rather, immediately output the warnings when we encounter them.

Change-Id: I4bd1a5491a47cb0232bfdd4e325f8f122593aa39
Reviewed-by: Maximilian Goldstein <max.goldstein@qt.io>
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Unify injected and "normal" JavaScript identifiers 2020-10-02T13:33:10+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-30T12:44:24+00:00 7957752447fbd2581521b13156ef29ffc80ad7bf The specifics of how to warn about the injected identifiers are moved out of ScopeTree as that is not related to the structure of the scopes. Change-Id: I26418c3fa492da8339abf045a4034a8464b7bbb8 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
The specifics of how to warn about the injected identifiers are moved
out of ScopeTree as that is not related to the structure of the scopes.

Change-Id: I26418c3fa492da8339abf045a4034a8464b7bbb8
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Remove ComponentVersion 2020-10-02T13:33:04+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-30T09:02:53+00:00 b078890608344f0556a0ff50aab62ede83e0e180 QTypeRevision does all we need there. Change-Id: Ib27ae2d58167a7a45fac31262a45e387d047af89 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
QTypeRevision does all we need there.

Change-Id: Ib27ae2d58167a7a45fac31262a45e387d047af89
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Remove ScopeTree::isVisualRootScope() 2020-10-02T13:32:58+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-30T08:50:11+00:00 85dd91f27b16fabe04575bd3b01bccc44b43d43f This is not a property of the ScopeTree itself, but rather a property of how qmllint sets up its scopes. Change-Id: Ifb7c0f1f841046a6ae68e246fbd706f67bedb2af Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
This is not a property of the ScopeTree itself, but rather a property of
how qmllint sets up its scopes.

Change-Id: Ifb7c0f1f841046a6ae68e246fbd706f67bedb2af
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Remove C++ types from the importer interface 2020-10-02T13:32:51+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-29T15:56:46+00:00 5296c163acb520706177807c2a12c30177046fab We don't use them anymore. Now we can also make all the ScopeTrees const again as we don't need to modify them anymore after importing. Change-Id: I3ece767f4f62f06cb0640f1f191eb8d98400717c Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
We don't use them anymore. Now we can also make all the ScopeTrees const
again as we don't need to modify them anymore after importing.

Change-Id: I3ece767f4f62f06cb0640f1f191eb8d98400717c
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Don't use C++ names of QML types 2020-10-02T13:32:42+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-29T15:33:17+00:00 e548c8576d1794cdac4b9a679b90cb74cf307e44 The C++ names are an implementation detail of the importer, and qmllint has no business messing with them. All the types are supplied as ScopeTree by the importer now. Change-Id: I3ef2b5da1dc19f95c7f2a5d80fa1297ba10bef8f Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
The C++ names are an implementation detail of the importer, and qmllint
has no business messing with them. All the types are supplied as
ScopeTree by the importer now.

Change-Id: I3ef2b5da1dc19f95c7f2a5d80fa1297ba10bef8f
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
qmllint: Fix updating of parent property 2020-10-02T13:31:59+00:00 Ulf Hermann ulf.hermann@qt.io 2020-10-02T09:17:29+00:00 febb6ba891616b71476b736d4c583054685c7766 We need to check for the baseTypeName, not for the internalName. Also, this is not really the scope's business but a property of how qmllint sets up its scopes. Task-number: QTBUG-87116 Change-Id: I8f0e558a4a5861164c6e85f90e3d88e469ea0769 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> Reviewed-by: Evgeniy Dushistov <dushistov@mail.ru> 
We need to check for the baseTypeName, not for the internalName. Also,
this is not really the scope's business but a property of how qmllint
sets up its scopes.

Task-number: QTBUG-87116
Change-Id: I8f0e558a4a5861164c6e85f90e3d88e469ea0769
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>
Reviewed-by: Evgeniy Dushistov <dushistov@mail.ru>
qmllint: Make imports local 2020-09-28T11:26:52+00:00 Ulf Hermann ulf.hermann@qt.io 2020-09-25T14:14:53+00:00 4cd06638c198c7ed48680c63e9df943e3680e89e Imports are not transitive. qmllint gets this wrong so far. Fixing it reveals two tests where we use types we haven't imported. Import the relevant modules. Change-Id: I45f3229468d54137f97d6b699f3a98a1349bc412 Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io> 
Imports are not transitive. qmllint gets this wrong so far. Fixing it
reveals two tests where we use types we haven't imported. Import the
relevant modules.

Change-Id: I45f3229468d54137f97d6b699f3a98a1349bc412
Reviewed-by: Fabian Kosmale <fabian.kosmale@qt.io>