diff options
| author | Frédéric Lefebvre <frederic.lefebvre@qt.io> | 2025-09-02 13:14:59 +0200 |
|---|---|---|
| committer | Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> | 2026-03-10 04:15:01 +0000 |
| commit | 54b20152031ec63b7184878333a6ab2301a234ff (patch) | |
| tree | 90523308e96cb3d9730b3e305f0b184f135f80af | |
| parent | e75fd18b5a3813e06513407bca673b3debc568ff (diff) | |
Remove redundant calls to requestActivate() in tst_focus
tst_focus include calls to requestActivate() after a window is shown.
This call is superfluous for the current test and should be removed.
Remove the unnecessary requestActivate() calls to simplify the code.
Task-number: QTBUG-139705
Change-Id: I0c0117023499b7b4370a610684c5c01031f69934
Reviewed-by: Axel Spoerl <axel.spoerl@qt.io>
(cherry picked from commit e581b872cf2d8d54a483f188b6de4af35551c1c0)
Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org>
(cherry picked from commit 1ec06bc0f009182e0935d56ffdf7fcfc14e757a6)
| -rw-r--r-- | tests/auto/quickcontrols/focus/tst_focus.cpp | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/tests/auto/quickcontrols/focus/tst_focus.cpp b/tests/auto/quickcontrols/focus/tst_focus.cpp index ce95785582..455f2fa2c2 100644 --- a/tests/auto/quickcontrols/focus/tst_focus.cpp +++ b/tests/auto/quickcontrols/focus/tst_focus.cpp @@ -99,7 +99,6 @@ void tst_focus::navigation() view.setSource(testFileUrl(testFile)); view.show(); - view.requestActivate(); QVERIFY(QTest::qWaitForWindowActive(&view)); QVERIFY(QGuiApplication::focusWindow() == &view); @@ -235,7 +234,6 @@ void tst_focus::reason() QQuickView view; view.setSource(testFileUrl("focusReason.qml")); view.show(); - view.requestActivate(); QVERIFY(QTest::qWaitForWindowActive(&view)); QQuickControl *control = view.findChild<QQuickControl *>("control"); @@ -457,7 +455,6 @@ void tst_focus::visualFocus() QQuickView view; view.setSource(testFileUrl("visualFocus.qml")); view.show(); - view.requestActivate(); QVERIFY(QTest::qWaitForWindowActive(&view)); QQuickItem *column = view.rootObject(); @@ -514,7 +511,6 @@ void tst_focus::scope() QVERIFY(child); window->show(); - window->requestActivate(); QVERIFY(QTest::qWaitForWindowActive(window.data())); |