aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorFrédéric Lefebvre <frederic.lefebvre@qt.io>2025-09-02 12:57:14 +0200
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2026-03-10 04:14:42 +0000
commitc9b4c0ec2eea1c75a967ef5f47a9f11785ced8ba (patch)
tree433628aa50a0bee626af8a0bda722f5164cd76b1
parentf5684b73364f9bf624ee6b9e1f0a954856ae5f6d (diff)
Remove redundant calls to requestActivate in tst_QQuickTextInput
tst_QQuickTextInput include calls to requestActivate() after a window is shown. This call is superfluous for the current test and should be removed. Remove the unnecessary requestActivate() calls to simplify the code. Task-number: QTBUG-139705 Change-Id: I864a9b2d8165d87f6115abc025aac265baef718c Reviewed-by: Axel Spoerl <axel.spoerl@qt.io> (cherry picked from commit ecc321b8b8b6abb93c5d607162f96d2e6208d8dc) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 8f9979f2bf27c2938dc5bef7f4b7dd9c07ebaaa0)
-rw-r--r--tests/auto/quick/qquicktextinput/tst_qquicktextinput.cpp11
1 files changed, 0 insertions, 11 deletions
diff --git a/tests/auto/quick/qquicktextinput/tst_qquicktextinput.cpp b/tests/auto/quick/qquicktextinput/tst_qquicktextinput.cpp
index 81ec1c5c88..ec5bfd1964 100644
--- a/tests/auto/quick/qquicktextinput/tst_qquicktextinput.cpp
+++ b/tests/auto/quick/qquicktextinput/tst_qquicktextinput.cpp
@@ -1781,7 +1781,6 @@ void tst_qquicktextinput::positionAt()
QQuickView window(testFileUrl("positionAt.qml"));
QVERIFY(window.rootObject() != nullptr);
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QQuickTextInput *textinputObject = qobject_cast<QQuickTextInput *>(window.rootObject());
@@ -1871,7 +1870,6 @@ void tst_qquicktextinput::maxLength()
QQuickView window(testFileUrl("maxLength.qml"));
QVERIFY(window.rootObject() != nullptr);
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QQuickTextInput *textinputObject = qobject_cast<QQuickTextInput *>(window.rootObject());
@@ -2220,7 +2218,6 @@ void tst_qquicktextinput::inputMethods()
{
QQuickView window(testFileUrl("inputmethods.qml"));
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
// test input method hints
@@ -2342,7 +2339,6 @@ void tst_qquicktextinput::signal_accepted()
{
QQuickView window(testFileUrl("signal_accepted.qml"));
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QVERIFY(window.rootObject() != nullptr);
@@ -2384,7 +2380,6 @@ void tst_qquicktextinput::signal_editingfinished()
{
QQuickView window(testFileUrl("signal_editingfinished.qml"));
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QVERIFY(window.rootObject() != nullptr);
@@ -2454,7 +2449,6 @@ void tst_qquicktextinput::signal_textEdited()
{
QQuickWindow window;
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QQuickTextInput *input = new QQuickTextInput(window.contentItem());
@@ -2705,7 +2699,6 @@ void tst_qquicktextinput::copyAndPasteKeySequence()
QQuickWindow window;
textInput->setParentItem(window.contentItem());
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
// copy and paste
@@ -2805,7 +2798,6 @@ void tst_qquicktextinput::middleClickPaste()
QQuickView window(testFileUrl("mouseselectionmode_default.qml"));
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QVERIFY(window.rootObject() != nullptr);
@@ -2871,7 +2863,6 @@ void tst_qquicktextinput::cursorDelegate()
QFETCH(QUrl, source);
QQuickView view(source);
view.show();
- view.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&view));
QQuickTextInput *textInputObject = view.rootObject()->findChild<QQuickTextInput*>("textInputObject");
QVERIFY(textInputObject != nullptr);
@@ -2990,7 +2981,6 @@ void tst_qquicktextinput::remoteCursorDelegate()
view.rootContext()->setContextProperty("contextDelegate", &component);
view.setSource(testFileUrl("cursorTestRemote.qml"));
view.show();
- view.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&view));
QQuickTextInput *textInputObject = view.rootObject()->findChild<QQuickTextInput*>("textInputObject");
QVERIFY(textInputObject != nullptr);
@@ -3346,7 +3336,6 @@ void tst_qquicktextinput::echoMode()
{
QQuickView window(testFileUrl("echoMode.qml"));
window.show();
- window.requestActivate();
QVERIFY(QTest::qWaitForWindowActive(&window));
QVERIFY(window.rootObject() != nullptr);