aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorMitch Curtis <mitch.curtis@qt.io>2025-03-21 11:18:41 +0800
committerQt Cherry-pick Bot <cherrypick_bot@qt-project.org>2025-04-15 04:11:42 +0000
commit4cd5e8b3ed8d469eed21401e7995dbf6ea595a41 (patch)
treee6beef6be70d367be96247f79734b2fdbdd2b65a
parent1c2c14200d7e4fa38c9cb64f9be8b94f20737a4d (diff)
tst_Snippets: fail on warnings
Task-number: QTBUG-98718 Change-Id: I24e641952ca4570f85928c53fb9752a595d50122 Reviewed-by: Santhosh Kumar <santhosh.kumar.selvaraj@qt.io> (cherry picked from commit 7aea117ffacc2c1fab8b3267b883f92af8b5efcd) Reviewed-by: Qt Cherry-pick Bot <cherrypick_bot@qt-project.org> (cherry picked from commit 0040bf3bce6292ee5a86dd84218e43e3ae2cfcf8)
-rw-r--r--src/quickcontrols/doc/snippets/qtquickcontrols-swipedelegate.qml6
-rw-r--r--tests/auto/quickcontrols/snippets/tst_snippets.cpp26
2 files changed, 20 insertions, 12 deletions
diff --git a/src/quickcontrols/doc/snippets/qtquickcontrols-swipedelegate.qml b/src/quickcontrols/doc/snippets/qtquickcontrols-swipedelegate.qml
index 9470de2d31..fcce355f0a 100644
--- a/src/quickcontrols/doc/snippets/qtquickcontrols-swipedelegate.qml
+++ b/src/quickcontrols/doc/snippets/qtquickcontrols-swipedelegate.qml
@@ -23,7 +23,11 @@ ListView {
required property string title
required property int index
- ListView.onRemove: SequentialAnimation {
+ ListView.onRemove: removeAnimation.start()
+
+ SequentialAnimation {
+ id: removeAnimation
+
PropertyAction {
target: swipeDelegate
property: "ListView.delayRemove"
diff --git a/tests/auto/quickcontrols/snippets/tst_snippets.cpp b/tests/auto/quickcontrols/snippets/tst_snippets.cpp
index 68e6ef5dfa..488e709c85 100644
--- a/tests/auto/quickcontrols/snippets/tst_snippets.cpp
+++ b/tests/auto/quickcontrols/snippets/tst_snippets.cpp
@@ -15,8 +15,8 @@ class tst_Snippets : public QObject
private slots:
void initTestCase();
- void verify();
void verify_data();
+ void verify();
private:
void loadSnippet(const QString &source);
@@ -59,11 +59,25 @@ void tst_Snippets::initTestCase()
Q_DECLARE_METATYPE(QList<QQmlError>)
+void tst_Snippets::verify_data()
+{
+ QTest::addColumn<QString>("input");
+ QTest::addColumn<QString>("output");
+
+ QMap<QString, QStringPair>::const_iterator it;
+ for (it = snippetPaths.constBegin(); it != snippetPaths.constEnd(); ++it)
+ QTest::newRow(qPrintable(it.key())) << it.value().first << it.value().second;
+}
+
void tst_Snippets::verify()
{
QFETCH(QString, input);
QFETCH(QString, output);
+ // TODO: QTBUG-135009
+ if (QTest::currentDataTag() != QLatin1String("qtquickcontrols-spinbox-custom"))
+ QTest::failOnWarning();
+
QQmlEngine engine;
QQmlComponent component(&engine);
@@ -124,16 +138,6 @@ void tst_Snippets::verify()
}
}
-void tst_Snippets::verify_data()
-{
- QTest::addColumn<QString>("input");
- QTest::addColumn<QString>("output");
-
- QMap<QString, QStringPair>::const_iterator it;
- for (it = snippetPaths.constBegin(); it != snippetPaths.constEnd(); ++it)
- QTest::newRow(qPrintable(it.key())) << it.value().first << it.value().second;
-}
-
QTEST_MAIN(tst_Snippets)
#include "tst_snippets.moc"