qmlformat: fix error message output

We don't need m_valid to check if there is an error. Do validity check
by m_error.isEmpty().

Prior to this commit, an invalid command line option given to qmlformat
wouldn't spit out the error message and qmlformat would silently ignore
the error and run with default settings. For example, the command
qmlformat -W -342523 <filepath> should error out with this commit since
a negative line length is given.

Pick-to: 6.8
Change-Id: Ie7d07e3b2b3714793f9abed4558003cc5ad77b34
Reviewed-by: Sami Shalayel <sami.shalayel@qt.io>
(cherry picked from commit f3a6026d11c9d7e9ec839aa2467364f09e35a025)
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>

1 files changed, 0 insertions, 2 deletions

diff --git a/tools/qmlformat/qmlformat.cpp b/tools/qmlformat/qmlformat.cpp
index e960072322..d4fb5b9e53 100644
--- a/tools/qmlformat/qmlformat.cpp
+++ b/tools/qmlformat/qmlformat.cpp
@@ -186,7 +186,6 @@ QQmlFormatOptions buildCommandLineOptions(const QCoreApplication &app)
     if (parser.isSet(writeDefaultsOption)) {
         QQmlFormatOptions options;
         options.setWriteDefaultSettingsEnabled(true);
-        options.setIsValid(true);
         return options;
     }
 
@@ -223,7 +222,6 @@ QQmlFormatOptions buildCommandLineOptions(const QCoreApplication &app)
     options.setNormalizeEnabled(parser.isSet("normalize"));
     options.setObjectsSpacing(parser.isSet("objects-spacing"));
     options.setFunctionsSpacing(parser.isSet("functions-spacing"));
-    options.setIsValid(true);
 
     options.setIndentWidth(indentWidth);
     options.setIndentWidthSet(parser.isSet("indent-width"));