From 593be86d543b220d4f47e915c39b45ca3cb6e6af Mon Sep 17 00:00:00 2001 From: Liang Jian Date: Thu, 13 Mar 2014 13:28:53 +0800 Subject: Fix CompiledData::CompilationUnit object leak Don't ref CompiledData::CompilationUnit in constructor of ScriptFunction since its has been referenced in its base class Change-Id: I9ad2d6e190c2ac11de4ccd63015c81d2dead3971 Reviewed-by: Simon Hausmann --- src/qml/jsruntime/qv4functionobject.cpp | 5 ----- 1 file changed, 5 deletions(-) (limited to 'src/qml/jsruntime/qv4functionobject.cpp') diff --git a/src/qml/jsruntime/qv4functionobject.cpp b/src/qml/jsruntime/qv4functionobject.cpp index c53c528e39..6bd56d8fb2 100644 --- a/src/qml/jsruntime/qv4functionobject.cpp +++ b/src/qml/jsruntime/qv4functionobject.cpp @@ -357,11 +357,6 @@ ScriptFunction::ScriptFunction(ExecutionContext *scope, Function *function) Scope s(scope); ScopedValue protectThis(s, this); - this->function = function; - this->function->compilationUnit->ref(); - Q_ASSERT(function); - Q_ASSERT(function->code); - // global function if (!scope) return; -- cgit v1.2.3