gitnex/GitNex

Use Gradle-native formatter #1208

Merged

mmarif merged 7 commits from :spotless into main

2022-09-21 07:43:03 +02:00

qwerty287 commented

2022-09-15 21:45:26 +02:00

Contributor

Run gradle :app:spotlessApply to apply formatting.

Changes from current code format

This does not match with the old intellij based code format because I can't apply some rules there.

newlines after else, catch etc. (means there are } else { statements)
no spaces around if braces (there are statements like if (true) { instead of if(true) {

Closes #1187
Closes #1202

Run `gradle :app:spotlessApply` to apply formatting. # Changes from current code format This does not match with the old intellij based code format because I can't apply some rules there. - newlines after `else`, `catch` etc. (means there are `} else {` statements) - no spaces around `if` braces (there are statements like `if (true) {` instead of `if(true) {` Closes https://codeberg.org/gitnex/GitNex/issues/1187 Closes https://codeberg.org/gitnex/GitNex/issues/1202

qwerty287 added 4 commits 2022-09-15 21:45:27 +02:00

Add Spotless dependency 36f9af9855

Update config a9a61e938f

Reformat files and change some configs a0df70fb75

Update wp config

ci/woodpecker/pr/locale Pipeline was successful

Details

ci/woodpecker/pr/build Pipeline was successful

Details

ci/woodpecker/pr/check Pipeline was successful

Details

c27abb4231

qwerty287 added the

label 2022-09-15 21:45:35 +02:00

qwerty287 self-assigned this 2022-09-15 21:45:41 +02:00

mmarif commented

2022-09-16 07:58:52 +02:00

Owner

It seems that is the default style for java with google formatter. We can't do much I guess in that.

It seems that is the default style for java with google formatter. We can't do much I guess in that.

qwerty287 commented

2022-09-16 10:10:03 +02:00

Author

Contributor

Yes, that's the issue I believe. I can/should change the IntelliJ code style.

Yes, that's the issue I believe. I can/should change the IntelliJ code style.

6543 approved these changes 2022-09-16 17:02:08 +02:00

6543 added this to the 5.0.0 milestone 2022-09-16 17:02:17 +02:00

6543 added 1 commit 2022-09-17 13:07:46 +02:00

Merge branch 'main' into spotless

ci/woodpecker/pr/locale Pipeline was successful

Details

ci/woodpecker/pr/check Pipeline was successful

Details

ci/woodpecker/pr/build Pipeline was successful

Details

6543 commented

2022-09-17 13:08:00 +02:00

Member

@mmarif I'm ready if you are

@mmarif I'm ready if you are

qwerty287 added 1 commit 2022-09-17 20:28:09 +02:00

Update intellij config and change checking in ci

ci/woodpecker/pr/locale Pipeline was successful

Details

ci/woodpecker/pr/check Pipeline was successful

Details

ci/woodpecker/pr/build Pipeline was successful

Details

8de5f90e6d

qwerty287 added 1 commit 2022-09-20 20:52:50 +02:00

Merge branch 'main' into spotless

ci/woodpecker/pr/locale Pipeline was successful

Details

ci/woodpecker/pr/check Pipeline was successful

Details

ci/woodpecker/pr/build Pipeline was successful

Details

0402cf19e5

mmarif approved these changes 2022-09-21 07:40:34 +02:00

mmarif referenced this pull request from a commit

2022-09-21 07:43:01 +02:00

Use Gradle-native formatter (#1208)

mmarif merged commit 325560c08d into main

2022-09-21 07:43:03 +02:00

Sign in to join this conversation.

No reviewers

No labels

⌚ Major-release

⌚ Minor-release

⛏️ Breaking

➡️ Frontport

➡️ Needs-frontport

🌐 Translation

🎯 Enhancement

👋 Good-first-issue

💀 Deprecation

💡 Suggestion

💬 Discussion

💭 Brainstorming

📄 Documentation

📈 Performance

📌 Priority-critical

📌 Priority-high

📍 Priority-low

📍 Priority-medium

📡 Needs-feedback

🔙 Has-backport

🔙 Needs-backport

🔙 Regression

🔭 Cannot-reproduce

🗄️ Repository

🗒️ Changelog

🗓️ Summary

🤾 Google-play

🧺 Needs-cleanup

🩹 External-dependecy

🙇‍♂️ Needs-help

🚀 Improvement

🚨 Investigate

🛡️ Blocked

🛰️ API-dependency

No milestone

No project

No assignees

3 participants

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: gitnex/GitNex#1208

No description provided.