tusky/Tusky
tusky/Tusky
11
165
Fork 15
Code Issues 524 Pull requests 5 Releases 133 Activity Actions

Modernize a bit #3171

Merged
Goooler merged 34 commits from modernize into develop 2023-02-04 19:58:53 +01:00
Conversation 10 Commits 34 Files changed 28 +241 -215
Goooler commented 2023-01-13 08:35:41 +01:00 (Migrated from github.com)
Copy link

Just all things.

Just all things.
connyduck (Migrated from github.com) reviewed 2023-01-13 20:20:07 +01:00
connyduck (Migrated from github.com) left a comment
Copy link

Nice, but a a lot of mixed changes for one PR

Nice, but a a lot of mixed changes for one PR
app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
connyduck (Migrated from github.com) commented 2023-01-13 20:09:37 +01:00
Copy link

What difference do these changes make?

What difference do these changes make?
gradle/libs.versions.toml
connyduck (Migrated from github.com) commented 2023-01-13 20:17:09 +01:00
Copy link

AndroidX dependencies are already being upgraded in https://github.com/tuskyapp/Tusky/pull/3169

AndroidX dependencies are already being upgraded in https://github.com/tuskyapp/Tusky/pull/3169
gradle/libs.versions.toml
connyduck (Migrated from github.com) commented 2023-01-13 20:16:39 +01:00
Copy link

Not used anywhere?

Not used anywhere?
settings.gradle
connyduck (Migrated from github.com) commented 2023-01-13 20:08:14 +01:00
Copy link

I don't think we need this plugin

I don't think we need this plugin
Goooler (Migrated from github.com) reviewed 2023-01-13 20:21:19 +01:00
app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
Goooler (Migrated from github.com) commented 2023-01-13 20:21:18 +01:00
Copy link

https://developer.android.com/studio/past-releases/past-agp-releases/agp-4-1-0-release-notes#4.1-nontransitive-r-class

https://developer.android.com/studio/past-releases/past-agp-releases/agp-4-1-0-release-notes#4.1-nontransitive-r-class
Goooler (Migrated from github.com) reviewed 2023-01-13 20:21:43 +01:00
gradle/libs.versions.toml
Goooler (Migrated from github.com) commented 2023-01-13 20:21:43 +01:00
Copy link

We can remove android-library.

We can remove `android-library`.
Goooler (Migrated from github.com) reviewed 2023-01-13 20:23:32 +01:00
gradle/libs.versions.toml
Goooler (Migrated from github.com) commented 2023-01-13 20:23:31 +01:00
Copy link

f84c5b980e

f84c5b980e78da12c4828dbad8aa4e59ed37f02c
Goooler (Migrated from github.com) reviewed 2023-01-13 20:23:39 +01:00
settings.gradle
Goooler (Migrated from github.com) commented 2023-01-13 20:23:39 +01:00
Copy link

f3be6d01a2

f3be6d01a2231b1134f341f8f708c306496628da
Goooler (Migrated from github.com) reviewed 2023-01-13 20:28:55 +01:00
gradle/libs.versions.toml
Goooler (Migrated from github.com) commented 2023-01-13 20:28:55 +01:00
Copy link

10aa548081

10aa548081f9554edd7b27dabd0332dc0e1f6340
connyduck (Migrated from github.com) reviewed 2023-01-13 20:37:01 +01:00
app/src/main/java/com/keylesspalace/tusky/MainActivity.kt
connyduck (Migrated from github.com) commented 2023-01-13 20:37:01 +01:00
Copy link

Oh learned something new, thx

Oh learned something new, thx
connyduck (Migrated from github.com) approved these changes 2023-01-13 20:37:24 +01:00
Goooler commented 2023-01-15 04:16:20 +01:00 (Migrated from github.com)
Copy link

@connyduck Ready to merge?

@connyduck Ready to merge?
connyduck commented 2023-01-15 15:16:01 +01:00 (Migrated from github.com)
Copy link

Yes, I'll merge it after Tusky 21 is released

Yes, I'll merge it after Tusky 21 is released
Sign in to join this conversation.
Reviewers
No reviewers
connyduck
Labels
Clear labels   
blocked

   
bug

   
duplicate

   
enhancement

   
good first issue

   
help wanted

   
invalid

   
question

   
wontfix
No labels
blocked
bug
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
tusky/Tusky!3171
No description provided.