Updated patch for std::list: Performance and memory usage improvements.

[Gawain Bolton]

Benjamin Kosnik wrote:

>Sorry, I was confused by the long time these patches took to get in.
>
No problem, it certainly did take a while.

>
>It looks like there has been some fall out with your patches and -Wcast-qual. 
>
>http://gcc.gnu.org/ml/libstdc++/2003-07/msg00147.html
>
>Can you take a look please?
>
Yes I'm taking a look.  The warning is absolutely correct and is indeed 
due to the first stl_tree.h patch.

>>The patch changed the std::list class.  The main change is to the 
>>behaviour of the constructor and destructor as the list header node is 
>>no longer dynamically allocated/de-allocated.  This improves performance 
>>and saves memory.
>>    
>>
>
>I added this to your ChangeLog entry.
>
Thanks.

>>Yes, using the attached performance test program here are some numbers 
>>tested on i686-pc-linux-gnu.
>>    
>>
>
>I'd like to add this as:
>
>2003-07-08  Gawain Bolton  <gp.bolton@computer.org>
>
>	* testsuite/performance/list_create_fill_sort.cc: New.
>
Looks good thanks.

>
>Please consider adding similar bits for the other changed containers, or
>modifying this to deal with all of them. 
>
Ok.

By the way, any comment on my suggestion to move functionality out of 
stl_tree.h into an stl_tree.cc source file to be part of libstdc++ 
library as described in:

    http://gcc.gnu.org/ml/libstdc++/2003-07/msg00107.html

Cheers,


Gawain

-- 
Gawain Bolton
Coignieres, France
PGP Info: Key server: http://wwwkeys.pgp.net
          Key id: 6EBEDEA6
          Fingerprint: 65C0 0030 21D1 7A01 546A  E7DB D60F 47E0 6EBE DEA6