[PATCH]libstdc++-v3/test: Skip "use_service.cc" for aarch64 baremetal
Jonathan Wakely
jwakely@redhat.com
Wed Apr 1 15:59:54 GMT 2020
On 01/04/20 16:56 +0100, Jonathan Wakely wrote:
>On 01/04/20 17:28 +0200, Andrea Corallo wrote:
>>Hi all,
>>
>>"use_service.cc" libstdc++ test does not compile for baremetal,
>>unfortunately AFAIK we don't have an appropriate selector to skip
>>these.
>>
>>https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89760
>>
>>https://gcc.gnu.org/legacy-ml/gcc-patches/2018-10/msg01089.html
>>
>>While the full issue is tackled would be possible to install this
>>patch to have it disabled on aarch64 baremetal where it is known to
>>be failing?
>
>No, I don't want to paper over the problem on every individual target
>where they fail.
>
>The correct fix is either to mark the tests as requiring gthreads (as
>most tests under libstdc++-v3/testsuite/30_threads/ do) or to modify
e.g. something like:
// { dg-do run }
// { dg-options "-pthread" }
// { dg-require-effective-target c++14 }
// { dg-require-effective-target pthread }
// { dg-require-gthreads "" }
Does that help, or does it still fail for other reasons?
>the library code to work without mutexes for targets without thread
>support.
>
More information about the Libstdc++
mailing list