diff options
| author | Álvaro Herrera | 2026-01-21 17:55:43 +0000 |
|---|---|---|
| committer | Álvaro Herrera | 2026-01-21 17:55:43 +0000 |
| commit | 098a1fab8a9bfe2b37eda8d790efbc15c9bdf7bc (patch) | |
| tree | 15ae53dbb319e9305f6559df354069bde2014431 /doc | |
| parent | d852d105e760672a1c4e9f796fdae1e0585632db (diff) | |
amcheck: Fix snapshot usage in bt_index_parent_check
We were using SnapshotAny to do some index checks, but that's wrong and
causes spurious errors when used on indexes created by CREATE INDEX
CONCURRENTLY. Fix it to use an MVCC snapshot, and add a test for it.
Backpatch of 6bd469d26aca to branches 14-16. I previously misidentified
the bug's origin: it came in with commit 7f563c09f890 (pg11-era, not
5ae2087202af as claimed previously), so all live branches are affected.
Also take the opportunity to fix some comments that we failed to update
in the original commits and apply pgperltidy. In branch 14, remove the
unnecessary test plan specification (which would have need to have been
changed anyway; c.f. commit 549ec201d613.)
Diagnosed-by: Donghang Lin <donghanglin@gmail.com>
Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Reviewed-by: Andrey Borodin <x4mmm@yandex-team.ru>
Backpatch-through: 17
Discussion: https://postgr.es/m/CANtu0ojmVd27fEhfpST7RG2KZvwkX=dMyKUqg0KM87FkOSdz8Q@mail.gmail.com
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/src/sgml/amcheck.sgml | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/src/sgml/amcheck.sgml b/doc/src/sgml/amcheck.sgml index 2b9c1a9205f..4c7c6e88820 100644 --- a/doc/src/sgml/amcheck.sgml +++ b/doc/src/sgml/amcheck.sgml @@ -353,7 +353,7 @@ SET client_min_messages = DEBUG1; verification functions is <literal>true</literal>, an additional phase of verification is performed against the table associated with the target index relation. This consists of a <quote>dummy</quote> - <command>CREATE INDEX</command> operation, which checks for the + <command>CREATE INDEX CONCURRENTLY</command> operation, which checks for the presence of all hypothetical new index tuples against a temporary, in-memory summarizing structure (this is built when needed during the basic first phase of verification). The summarizing structure |